Re: [PATCH] omap-cpufreq: Fix regulator resource leak in probe()

Viresh Kumar
2026-01-05T05:16:22Z

On 15-12-25, 11:03, Haotian Zhang wrote:
> The current omap_cpufreq_probe() uses regulator_get() to obtain the MPU
> regulator but does not release it in omap_cpufreq_remove() or when
> cpufreq_register_driver() fails, leading to a potential resource leak.
>
> Use devm_regulator_get() instead of regulator_get() so that the regulator
> resource is automatically released.
>
> Fixes: 53dfe8a884e6 ("cpufreq: OMAP: scale voltage along with frequency")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
> drivers/cpufreq/omap-cpufreq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c
> index bbb01d93b54b..f83f85996b36 100644
> --- a/drivers/cpufreq/omap-cpufreq.c
> +++ b/drivers/cpufreq/omap-cpufreq.c
> @@ -157,7 +157,7 @@ static int omap_cpufreq_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - mpu_reg = regulator_get(mpu_dev, "vcc");
> + mpu_reg = devm_regulator_get(mpu_dev, "vcc");
> if (IS_ERR(mpu_reg)) {
> pr_warn("%s: unable to get MPU regulator\n", __func__);
> mpu_reg = NULL;
> @@ -169,7 +169,6 @@ static int omap_cpufreq_probe(struct platform_device *pdev)
> if (regulator_get_voltage(mpu_reg) < 0) {
> pr_warn("%s: physical regulator not present for MPU\n",
> __func__);
> - regulator_put(mpu_reg);
> mpu_reg = NULL;
> }
> }

Kevin ?

--
viresh