From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>
Cc: "open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>
Subject: Re: [PATCH v2 0/2] thunderbolt: Fix S4 resume incongruities
Date: Wed, 7 Jan 2026 10:33:53 +0100 [thread overview]
Message-ID: <20260107093353.GO2275908@black.igk.intel.com> (raw)
In-Reply-To: <20260106053749.61440-1-superm1@kernel.org>
Hi,
On Mon, Jan 05, 2026 at 11:37:47PM -0600, Mario Limonciello (AMD) wrote:
> When a machine is restored from S4 if the firmware CM has created
> tunnels there can be an incongruity of expectation from the kernel
> when compared to booting from S5. This series addresses those.
I suspect there is no Firmware CM in AMD platforms so this actually means
the BIOS CM, correct?
However, on S4 we actually do reset host router when the "boot kernel" is
started before loading and jumping to the hibernation image. It might be
that this boot kernel tunnel configuration is causing the issues you are
seeing (can you elaborate on those?) but given that it is (typically the
same kernel binary) it should be creating the tunnels the same way.
>
> v1:
> Link: https://lore.kernel.org/linux-usb/20251023050354.115015-1-superm1@kernel.org/
>
> Mario Limonciello (AMD) (2):
> thunderbolt: Move nhi_reset before pmops declaration
> thunderbolt: Reset NHI during S4 restore_noirq() callback
>
> drivers/thunderbolt/nhi.c | 77 ++++++++++++++++++++++-----------------
> drivers/thunderbolt/tb.c | 29 ++++++++-------
> drivers/thunderbolt/tb.h | 1 +
> 3 files changed, 61 insertions(+), 46 deletions(-)
>
> --
> 2.43.0
next prev parent reply other threads:[~2026-01-07 9:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 5:37 [PATCH v2 0/2] thunderbolt: Fix S4 resume incongruities Mario Limonciello (AMD)
2026-01-06 5:37 ` [PATCH v2 1/2] thunderbolt: Move nhi_reset before pmops declaration Mario Limonciello (AMD)
2026-01-06 5:37 ` [PATCH v2 2/2] thunderbolt: Reset NHI during S4 restore_noirq() callback Mario Limonciello (AMD)
2026-01-07 9:33 ` Mika Westerberg [this message]
2026-01-07 20:50 ` [PATCH v2 0/2] thunderbolt: Fix S4 resume incongruities Mario Limonciello
2026-01-08 11:42 ` Mika Westerberg
2026-01-08 19:18 ` Mario Limonciello
2026-01-09 7:23 ` Mika Westerberg
2026-01-09 15:38 ` Mario Limonciello
2026-01-10 0:42 ` Katiyar, Pooja
2026-01-13 18:44 ` Mario Limonciello (AMD) (kernel.org)
2026-01-17 16:57 ` Katiyar, Pooja
2026-01-19 19:59 ` Mario Limonciello (AMD) (kernel.org)
2026-01-19 22:13 ` Kenneth Crudup
2026-01-29 23:13 ` Katiyar, Pooja
2026-01-30 1:39 ` Kenneth Crudup
2026-01-30 1:42 ` Kenneth Crudup
2026-02-04 0:50 ` Katiyar, Pooja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107093353.GO2275908@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox