From: Christoph Hellwig <hch@lst.de>
To: Wilfred Mallawa <wilfred.opensource@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Wilfred Mallawa <wilfred.mallawa@wdc.com>,
Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH v2] nvme/host: fixup some typos
Date: Wed, 7 Jan 2026 11:09:20 +0100 [thread overview]
Message-ID: <20260107100920.GA26943@lst.de> (raw)
In-Reply-To: <20260105040829.732046-2-wilfred.opensource@gmail.com>
Bit: the subject prefix is we usually use is just "nvme: ".
> /*
> * Handle ioctls that apply to the controller instead of the namespace
> - * separately and drop the ns SRCU reference early. This avoids a
> + * separately and drop the ns SRCU reference early. This avoids a
I don't see a typo here, just a reformatting to a different comment
style not very commonly used in the nvme code.
> -/* Define the socket priority to use for connections were it is desirable
> +/* Define the socket priority to use for connections where it is desirable
The change looks good, but if you touch this, you might as well fix up
the comment style to match the normal kernel style:
/*
* Define the socket priority to use for connections where it is desirable
next prev parent reply other threads:[~2026-01-07 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 4:08 [PATCH v2] nvme/host: fixup some typos Wilfred Mallawa
2026-01-07 10:09 ` Christoph Hellwig [this message]
2026-01-07 10:33 ` Wilfred Mallawa
2026-01-07 13:15 ` hch
2026-01-07 23:09 ` Wilfred Mallawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107100920.GA26943@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=wilfred.mallawa@wdc.com \
--cc=wilfred.opensource@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox