From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A7C43563CC for ; Wed, 7 Jan 2026 18:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767809829; cv=none; b=fEHcx97I0vPqqrJlUxflRZayDSlkbLCMV+EB/a2mbhCnvpqJ+R8i2OVMvOJzpR4QKfCx2+ozbTiGDTbvrmioTxz+J+0HpgBLijm4I+fqk5M5rlz+vlWIYXj7Uj4mcXpGYku8/scz5DgOTCmsXgfY6SbNMUV5MiDfF6rlGPWkukU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767809829; c=relaxed/simple; bh=cXjWywB4AwxOwxQEEwNp0jBxQVQk5T0xDGIAVw1JYhU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=h/UTnAFfXovHnTCxsRnpXakLikCs6sg2/1pO24tWToNCSvOhXwmg3O+ao7wv+MU0dtVUvLqdDcLOdTt99/KgVnWkmDoJ9P0xN97xqbHZZ/PtqS4y0EhOwG1sJ5s246mw8anIujvOI5Ojvfd9w4ri7KPjf8lCwBz6mLu4AmiXEzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=diheGpgP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="diheGpgP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F2ECC4CEF1; Wed, 7 Jan 2026 18:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1767809826; bh=cXjWywB4AwxOwxQEEwNp0jBxQVQk5T0xDGIAVw1JYhU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=diheGpgPUKqCl+iO1SQwee6L5Zv83Ncg2IJmb5ABH2Auwt+Di7ntrQoI8eD4h2++b DGFfemN9I2SvNlXTDBufys1bE2xCr+R39WsFHdAaCvCA5Q+yQvTvloHxL25XX9O1Yn FRJYxnZjFGArAFcTnWqcBcm2mY6PNptXfJJI/+1U= Date: Wed, 7 Jan 2026 10:17:05 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: Yosry Ahmed , Nhat Pham , Minchan Kim , Johannes Weiner , Brian Geffon , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 2/2] zsmalloc: simplify read begin/end logic Message-Id: <20260107101705.0469e87ffc60120120500e76@linux-foundation.org> In-Reply-To: <20260107052145.3586917-2-senozhatsky@chromium.org> References: <20260107052145.3586917-1-senozhatsky@chromium.org> <20260107052145.3586917-2-senozhatsky@chromium.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 7 Jan 2026 14:21:45 +0900 Sergey Senozhatsky wrote: > From: Yosry Ahmed > > When we switched from using class->size (for spans detection) > to actual compressed object size, we had to compensate for > the fact that class->size implicitly took inlined handle > into consideration. In fact, instead of adjusting the size > of compressed object (adding handle offset for non-huge size > classes), we can move some lines around and simplify the > code: there are already paths in read_begin/end that compensate > for inlined object handle offset. Updated, thanks. > Signed-off-by: Yosry Ahmed > --- This patch should have had your Signed-off-by: also, as you were on the delivery path. I have made that change to the mm.gt copy.