From: "Ionut Nechita (Sunlight Linux)" <sunlightlinux@gmail.com>
To: alexdeucher@gmail.com
Cc: alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org,
christian.koenig@amd.com, dri-devel@lists.freedesktop.org,
ionut_n2001@yahoo.com, linux-kernel@vger.kernel.org,
sunlightlinux@gmail.com, superm1@kernel.org
Subject: Re: [PATCH 1/1] drm/amdgpu: Fix TLB flush failures after hibernation resume
Date: Wed, 7 Jan 2026 12:52:25 +0200 [thread overview]
Message-ID: <20260107105225.37703-1-sunlightlinux@gmail.com> (raw)
In-Reply-To: <CADnq5_OXJnREtCUhyq4JWjKmih=k7hnc4w_y8mNd3J1g437V8Q@mail.gmail.com>
Hi Alex,
Thank you for the detailed review and for pointing out the ordering issue.
You're absolutely right - I misunderstood the call sequence. Setting
resume_gpu_stable to false in amdgpu_device_resume() happens after
gfx_v9_0_cp_resume(), which defeats the purpose and permanently
disables the KIQ path.
However, I'm still experiencing the TLB flush failures after hibernation
resume on AMD Cezanne (Renoir):
amdgpu: TLB flush failed for PASID xxxxx
amdgpu: failed to write reg 28b4 wait reg 28c6
amdgpu: failed to write reg 1a6f4 wait reg 1a706
If kiq sched.ready is being handled correctly as you described, what
else could cause these failures during resume? Are there any known
issues with KIQ-based TLB invalidation after hibernation on GFX9?
Should I investigate:
- Timing issues with KIQ command submission during early resume?
- Power/clock gating states affecting KIQ functionality?
- Missing synchronization after KIQ initialization?
Any guidance on the correct direction to investigate would be appreciated.
Thanks,
Ionut
next prev parent reply other threads:[~2026-01-07 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 12:59 [PATCH 0/1] drm/amdgpu: Fix TLB flush failures after hibernation resume Ionut Nechita (Sunlight Linux)
2026-01-06 12:59 ` [PATCH 1/1] " Ionut Nechita (Sunlight Linux)
2026-01-06 16:26 ` Alex Deucher
2026-01-07 10:52 ` Ionut Nechita (Sunlight Linux) [this message]
2026-01-08 12:36 ` Christian König
2026-01-26 19:40 ` Ionut Nechita (Sunlight Linux)
2026-01-26 20:25 ` Alex Deucher
2026-01-26 20:28 ` Mario Limonciello (AMD) (kernel.org)
2026-01-26 20:32 ` Mario Limonciello (AMD) (kernel.org)
2026-01-26 20:46 ` Ionut Nechita (Sunlight Linux)
2026-01-26 20:37 ` Ionut Nechita (Sunlight Linux)
2026-01-27 11:35 ` Christian König
2026-02-01 19:05 ` Ionut Nechita (Sunlight Linux)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107105225.37703-1-sunlightlinux@gmail.com \
--to=sunlightlinux@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ionut_n2001@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox