Re: [PATCH v5 4/7] ptp: ptp_vmclock: Add device tree support

Jakub Kicinski
2026-01-13T03:46:21Z

On Wed, 7 Jan 2026 13:26:01 +0000 Chalios, Babis wrote:
> +static int vmclock_setup_notification(struct device *dev,
> + struct vmclock_state *st)
> +{
> + /* The device does not support notifications. Nothing else to do */
> + if (!(le64_to_cpu(st->clk->flags) & VMCLOCK_FLAG_NOTIFICATION_PRESENT))
> + return 0;
> +
> + if (has_acpi_companion(dev)) {
> + return vmclock_setup_acpi_notification(dev);
> + } else {
> + return vmclock_setup_of_notification(dev);
> + }
> +
> +}
> +
> +
> static void vmclock_put_idx(void *data)

Please run checkpatch.

CHECK: Blank lines aren't necessary before a close brace '}'
#109: FILE: drivers/ptp/ptp_vmclock.c:636:
+
+}

CHECK: Please don't use multiple blank lines
#111: FILE: drivers/ptp/ptp_vmclock.c:638:
+
+