From: Simon Horman <horms@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 00/15] net: ftgmac100: Various probe cleanups
Date: Wed, 7 Jan 2026 15:54:27 +0000 [thread overview]
Message-ID: <20260107155427.GB345651@kernel.org> (raw)
In-Reply-To: <20260105-ftgmac-cleanup-v1-0-b68e4a3d8fbe@aspeedtech.com>
On Mon, Jan 05, 2026 at 03:08:46PM +0800, Jacky Chou wrote:
> The probe function of the ftgmac100 is rather complex, due to the way
> it has evolved over time, dealing with poor DT descriptions, and new
> variants of the MAC.
>
> Make use of DT match data to identify the MAC variant, rather than
> looking at the compatible string all the time.
>
> Make use of devm_ calls to simplify cleanup. This indirectly fixes
> inconsistent goto label names.
>
> Always probe the MDIO bus, when it exists. This simplifies the logic a
> bit.
>
> Move code into helpers to simply probe.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
Hi,
I'm slightly unclear on the providence of this patchset.
But overall it looks good to me. And I particularly like
how it has been split up into bite-sized chunks.
I don't see anything that should block progress, but I do have a few
minor nits that I'll raise just in case there is a v2 for other reasons.
The first nit is that the patch-set should be targeted at net-next,
by including inet-next in the Subjects, like this:
[PATCH net-net 00/15] ...
The other minor nits are patch-specifically, so I'll respond to those patches
accordingly.
Again, overall this looks good to me.
So for the series:
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-01-07 15:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 7:08 [PATCH 00/15] net: ftgmac100: Various probe cleanups Jacky Chou
2026-01-05 7:08 ` [PATCH 01/15] net: ftgmac100: List all compatibles Jacky Chou
2026-01-05 7:08 ` [PATCH 02/15] net: ftgmac100: Add match data containing MAC ID Jacky Chou
2026-01-05 7:08 ` [PATCH 03/15] net: ftgmac100: Replace all of_device_is_compatible() Jacky Chou
2026-01-05 7:08 ` [PATCH 04/15] net: ftgmac100: Use devm_alloc_etherdev() Jacky Chou
2026-01-07 15:55 ` Simon Horman
2026-01-08 1:31 ` Jacky Chou
2026-01-05 7:08 ` [PATCH 05/15] net: ftgmac100: Use devm_request_memory_region/devm_ioremap Jacky Chou
2026-01-05 7:08 ` [PATCH 06/15] net: ftgmac100: Use devm_clk_get_enabled Jacky Chou
2026-01-05 7:08 ` [PATCH 07/15] net: ftgmac100: Simplify error handling for ftgmac100_initial_mac Jacky Chou
2026-01-05 7:08 ` [PATCH 08/15] net: ftgmac100: Move NCSI probe code into a helper Jacky Chou
2026-01-07 15:55 ` Simon Horman
2026-01-08 1:32 ` Jacky Chou
2026-01-05 7:08 ` [PATCH 09/15] net: ftgmac100: Always register the MDIO bus when it exists Jacky Chou
2026-01-05 7:08 ` [PATCH 10/15] net: ftgmac100: Simplify legacy MDIO setup Jacky Chou
2026-01-05 7:08 ` [PATCH 11/15] net: ftgmac100: Move DT probe into a helper Jacky Chou
2026-01-05 7:08 ` [PATCH 12/15] net: ftgmac100: Remove redundant PHY_POLL Jacky Chou
2026-01-05 7:08 ` [PATCH 13/15] net: ftgmac100: Simplify error handling for ftgmac100_setup_mdio Jacky Chou
2026-01-05 7:09 ` [PATCH 14/15] net: ftgmac100: Simplify condition on HW arbitration Jacky Chou
2026-01-05 7:09 ` [PATCH 15/15] net: ftgmac100: Fix wrong netif_napi_del in release Jacky Chou
2026-01-07 15:54 ` Simon Horman [this message]
2026-01-07 16:09 ` [PATCH 00/15] net: ftgmac100: Various probe cleanups Andrew Lunn
2026-01-12 15:02 ` Simon Horman
2026-01-08 1:37 ` Jacky Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107155427.GB345651@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacky_chou@aspeedtech.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox