* [PATCH net 1/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_MAJOR/MINOR
2026-01-07 14:58 [PATCH net 0/3] cpsw_ale: Remove obsolete macros Stefan Wiehler
@ 2026-01-07 14:58 ` Stefan Wiehler
2026-01-07 14:58 ` [PATCH net 2/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_IR3 Stefan Wiehler
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Wiehler @ 2026-01-07 14:58 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Siddharth Vadapalli, Roger Quadros, linux-omap, netdev,
linux-kernel, Stefan Wiehler
These macros are no longer used following the transition to regmaps.
Fixes: bbfc7e2b9ebe ("net: ethernet: ti: cpsw_ale: use regfields for ALE registers")
Signed-off-by: Stefan Wiehler <stefan.wiehler@nokia.com>
---
drivers/net/ethernet/ti/cpsw_ale.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c
index fbe35af615a6..e13df62448f1 100644
--- a/drivers/net/ethernet/ti/cpsw_ale.c
+++ b/drivers/net/ethernet/ti/cpsw_ale.c
@@ -23,8 +23,6 @@
#define BITMASK(bits) (BIT(bits) - 1)
-#define ALE_VERSION_MAJOR(rev, mask) (((rev) >> 8) & (mask))
-#define ALE_VERSION_MINOR(rev) (rev & 0xff)
#define ALE_VERSION_1R3 0x0103
#define ALE_VERSION_1R4 0x0104
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net 2/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_IR3
2026-01-07 14:58 [PATCH net 0/3] cpsw_ale: Remove obsolete macros Stefan Wiehler
2026-01-07 14:58 ` [PATCH net 1/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_MAJOR/MINOR Stefan Wiehler
@ 2026-01-07 14:58 ` Stefan Wiehler
2026-01-07 14:58 ` [PATCH net 3/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_IR4 Stefan Wiehler
2026-01-08 16:12 ` [PATCH net 0/3] cpsw_ale: Remove obsolete macros Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Wiehler @ 2026-01-07 14:58 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Siddharth Vadapalli, Roger Quadros, linux-omap, netdev,
linux-kernel, Stefan Wiehler
Entry mask bits are no longer hardcoded, so this macro is unused.
Fixes: b5d31f294027 ("net: ethernet: ti: ale: optimize ale entry mask bits configuartion")
Signed-off-by: Stefan Wiehler <stefan.wiehler@nokia.com>
---
drivers/net/ethernet/ti/cpsw_ale.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c
index e13df62448f1..aac4db3f7656 100644
--- a/drivers/net/ethernet/ti/cpsw_ale.c
+++ b/drivers/net/ethernet/ti/cpsw_ale.c
@@ -23,7 +23,6 @@
#define BITMASK(bits) (BIT(bits) - 1)
-#define ALE_VERSION_1R3 0x0103
#define ALE_VERSION_1R4 0x0104
/* ALE Registers */
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net 3/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_IR4
2026-01-07 14:58 [PATCH net 0/3] cpsw_ale: Remove obsolete macros Stefan Wiehler
2026-01-07 14:58 ` [PATCH net 1/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_MAJOR/MINOR Stefan Wiehler
2026-01-07 14:58 ` [PATCH net 2/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_IR3 Stefan Wiehler
@ 2026-01-07 14:58 ` Stefan Wiehler
2026-01-08 16:12 ` [PATCH net 0/3] cpsw_ale: Remove obsolete macros Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Wiehler @ 2026-01-07 14:58 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Siddharth Vadapalli, Roger Quadros, linux-omap, netdev,
linux-kernel, Stefan Wiehler
This macro has never been used in the first place.
Fixes: ca47130a744b ("net: netcp: ale: update to support unknown vlan controls for NU switch")
Signed-off-by: Stefan Wiehler <stefan.wiehler@nokia.com>
---
drivers/net/ethernet/ti/cpsw_ale.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c
index aac4db3f7656..bb969dd435b4 100644
--- a/drivers/net/ethernet/ti/cpsw_ale.c
+++ b/drivers/net/ethernet/ti/cpsw_ale.c
@@ -23,8 +23,6 @@
#define BITMASK(bits) (BIT(bits) - 1)
-#define ALE_VERSION_1R4 0x0104
-
/* ALE Registers */
#define ALE_IDVER 0x00
#define ALE_STATUS 0x04
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net 0/3] cpsw_ale: Remove obsolete macros
2026-01-07 14:58 [PATCH net 0/3] cpsw_ale: Remove obsolete macros Stefan Wiehler
` (2 preceding siblings ...)
2026-01-07 14:58 ` [PATCH net 3/3] net: ethernet: ti: cpsw_ale: Remove obsolete ALE_VERSION_IR4 Stefan Wiehler
@ 2026-01-08 16:12 ` Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2026-01-08 16:12 UTC (permalink / raw)
To: Stefan Wiehler
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Siddharth Vadapalli, Roger Quadros, linux-omap, netdev,
linux-kernel
On Wed, 7 Jan 2026 15:58:16 +0100 Stefan Wiehler wrote:
> Remove a bunch of obsolete macros from the CPSW ALE driver.
Dead code is not a bug, this should target net-next without the fixes
tags. Probably a single commit is best. You can just quote the 3
commits which removed the used of the macros in the body.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 5+ messages in thread