From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53CDB3D1CCA for ; Thu, 8 Jan 2026 14:08:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767881283; cv=none; b=RPJzbihyFQ1Wrxu244Mo9lVf+eRdcbCW+K3f62sc/0wbTW1v6qjBhMGUa+IAkAXW7UMteJSzcgWdJD3WP4mijQ2YQY7vthZS2y8A43Xw9KZvIvSD5wsbUwJiLsV3f/wq8HWFfHNKm0eDOUSK2kRgsBTnXgrNDzU7ZHHod+6I6Y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767881283; c=relaxed/simple; bh=KaqiKIrSwJ+ZnBNZThkRID6OHOTJLOwB/Uij0QQJV1Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sO/z1BafPC4tvF7wCuJXKzCIJ68orIMRgmdRN3IiSg7JUZMnq3R+svIPIxTGNYbCh5iVgTM75U2xVcr3l45rQ0Y3EbhtNQaO3CIk7Ezhn1FKfjIhMa9VMr8KMAoS1P0/OxjQsTVZ1rA26Hk1PfHscyY08mXRF2gLGLwY/QOKyXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DC+z1wRw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=JJtvfR4w; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DC+z1wRw"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="JJtvfR4w" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767881280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o3dV3iJKWcALTHlfMC1TmWQCBk2jAXP+lliSQZRypr4=; b=DC+z1wRwPZkoDB0V0nMq+zA2bs5MIJYw6bINgXSFjswyryJ2mTCrLatbKQcGDywcl4AY4c eKHEl1A+UnE4VMdCeTw7WV+p9T6ZhhZ4lswneW3nNG770YRFTVy5tkuXUu05TSgrEMyhMM 1paeVsIad1KhDgwvR2ZRh4+89SfFcdc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-5ES_ZCM-O3-tIkm4iGnZYg-1; Thu, 08 Jan 2026 09:07:59 -0500 X-MC-Unique: 5ES_ZCM-O3-tIkm4iGnZYg-1 X-Mimecast-MFC-AGG-ID: 5ES_ZCM-O3-tIkm4iGnZYg_1767881278 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47a97b719ccso20930535e9.2 for ; Thu, 08 Jan 2026 06:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767881278; x=1768486078; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o3dV3iJKWcALTHlfMC1TmWQCBk2jAXP+lliSQZRypr4=; b=JJtvfR4w4xzmRRJLIFv0Z2Ls4vcVnxXpVq0cDbdZAEDqA9oJlAEnLpS47UXoffDo0c Tuv0DGAZbIwG4Q/byrvWw+PmIJiLcKMTbHVXMNqjBK5t4WtuO+r4oZCGSHEndY44gNzM LTBiVFnmpoU+6OgAJJtOsPePT2Z0d4rB/7WV4BnuctdP/p5VMd2r2fj+ammVO+UiPBQ7 Y/EO0Z0X5f3aQTbIIcVkWFpIjkd7YLncBknXk9ZOigYHgCE4EPeFa+LV3610GDrg2WNT zWrgFo+hzkL7V9NLI13Mi2c2FMPhzKaI48L+00N50mbySmahQoWxvuhO3pE2cNZEAFJ4 aZQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767881278; x=1768486078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o3dV3iJKWcALTHlfMC1TmWQCBk2jAXP+lliSQZRypr4=; b=AewMVsKmqQY+q5i+zjCSLb28ZKrfyYNs7Y7jFqmY3VyQtZvrHn8npT1FQu1XLyKhnt AKaewUmmDUEfmIPKE+vHZqN9zB39rhKwhw+kstPbw+CaFj8RMJHIuQ3dcbe/OZ4a7FDG hBdm3bRN04FHtg3928Np2aekGHIAUl3yfms80ouHd3QE1MxZuD+xrRSjAvtjQqiaoMC4 ozjmIgnGcMTfp6bLn+XMj8kCl0ut+GtGpMLZIEzEzUzqNfn1CDIkLpWmonAGAagKXRx2 fNnTcme8oFLfQ/cwjtcp1c5BE0Vb9t2arc5Geg5av5iF4eG7vKhy5joLfP//V0DBuGnt Zb8w== X-Gm-Message-State: AOJu0YySbgehgbEweIVfd7yFqNeK6bW/E3rCG/XC/3l+n0nJfYd1PN5Q V4Tx1ph2N1sAbteen48MRaTdov7fPIf2YD+ITO8DZHCghLoEp1MG+6pHu8BWH1BmgxdGT44aohs DlWMFiRc383A42VzG97sILVdVYa7yXlW1ybWqEC81h4EI591ZZlPoWE2FhTNOG45/rw== X-Gm-Gg: AY/fxX7C0aUvNoXdgZNjPR5yZYDToMxj5Nui/uPq8YrUAZwCYfIg/qHC2gBMdoq3/cP xHcNXRyLJ8n4ia6ls9FkUOTCbkq9mCd8cXLB9pZZRPGXwcFI6G/tfQj8LbDu+FH5zUK+zRYrWWM uZ5gyXAYt44CdA6D2RMAS/9OsFFFOEqhRDClSdsvLsfC93mFM7jZfjS71cwALX8DQjsgKAnHPdn 2ApiA+qgLsROcJY6iIWR3uaK4/TupubcqNrpt9xWLgM/ZdVMZCUv1AQRuiKeulVrqJq9UG7c78c NR5/3LevSLDvrtPfTMYxbgE4ONyuRUyRz7em/fOOzkjkbORumvxXDxcAuVn7mO2JezDTKJKXkWb AKN9kFC3pWYsWlyrbzQomI4Oo5A+rdnM/Lg== X-Received: by 2002:a05:600c:1385:b0:47d:4fbe:e6d2 with SMTP id 5b1f17b1804b1-47d84b2cd6dmr72552985e9.12.1767881277888; Thu, 08 Jan 2026 06:07:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRCfp6entO3V/BR31Far6TJcGMp3EAPQ3dAY6QbDFNrKF2+2e3Jhs1Nmifuq8757Npv4Rh0Q== X-Received: by 2002:a05:600c:1385:b0:47d:4fbe:e6d2 with SMTP id 5b1f17b1804b1-47d84b2cd6dmr72552445e9.12.1767881277386; Thu, 08 Jan 2026 06:07:57 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f68f4ddsm160806445e9.2.2026.01.08.06.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:07:56 -0800 (PST) Date: Thu, 8 Jan 2026 09:07:53 -0500 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?iso-8859-1?Q?P=E9rez?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 07/15] vsock/virtio: fix DMA alignment for event_list Message-ID: <20260108090639-mutt-send-email-mst@kernel.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jan 08, 2026 at 03:04:07PM +0100, Stefano Garzarella wrote: > On Mon, Jan 05, 2026 at 03:23:17AM -0500, Michael S. Tsirkin wrote: > > On non-cache-coherent platforms, when a structure contains a buffer > > used for DMA alongside fields that the CPU writes to, cacheline sharing > > can cause data corruption. > > > > The event_list array is used for DMA_FROM_DEVICE operations via > > virtqueue_add_inbuf(). The adjacent event_run and guest_cid fields are > > written by the CPU while the buffer is available, so mapped for the > > device. If these share cachelines with event_list, CPU writes can > > corrupt DMA data. > > > > Add __dma_from_device_group_begin()/end() annotations to ensure event_list > > is isolated in its own cachelines. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > net/vmw_vsock/virtio_transport.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c > > index 8c867023a2e5..bb94baadfd8b 100644 > > --- a/net/vmw_vsock/virtio_transport.c > > +++ b/net/vmw_vsock/virtio_transport.c > > @@ -17,6 +17,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -59,8 +60,9 @@ struct virtio_vsock { > > */ > > struct mutex event_lock; > > bool event_run; > > + __dma_from_device_group_begin(); > > struct virtio_vsock_event event_list[8]; > > - > > + __dma_from_device_group_end(); > > Can we keep the blank line before `guest_cid` so that the comment before > this section makes sense? (regarding the lock required to access these > fields) > > Thanks, > Stefano A follow up patch re-introduces it, so I don't think it matters? > > u32 guest_cid; > > bool seqpacket_allow; > > > > -- > > MST > >