From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 251253559E2 for ; Thu, 8 Jan 2026 14:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767881882; cv=none; b=NB25JRMldR+X1nDWlFsdbbqpDIQMOZxpvjN66+H/QjKYPZH609phJGlWcF3Pk75rJswMCmXDtAnNQESo0B9HjskxcQbpNKoHhVWgQI/QEIMU2fnkncT8mqdwIe00tZeqD7ED57N6CBO5gTCU53BV98WRJN3egCnUbkxtADkRlEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767881882; c=relaxed/simple; bh=OyIQ4x46NnhuAF46QiC0P1xvTdYkXW0VaN1yOEbVEDQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=he1mSGBmMUHiR3Bi/afsuaZ2qJHxxkWirRX1vWaNABR7391rtWEW/bCv9Gfg+ZKKt2i79+BHvmWYaTBcD/Cmpve8JJlnJQL5+nk8pkKcxo+kEOridfLd2TjExxcwDthjTZE7BdviSuQLybTyGuyG+vubdemwY8K9bfoLItPfb8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EFaI6RME; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=g7sjFu/e; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EFaI6RME"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="g7sjFu/e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767881879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fJ1lT1EolLhB5JifwSURg3jL1WOY3ilSvQ0LTyMqODM=; b=EFaI6RMEHSnU9gmHaA99LRttqdbfIt3HhPooQFitNOqBbY1hGmRHMOjcg34frqBn57PACn MHdznQ8g0UMxAI6SzMozMBb8uANT8lHdKAcSjEwDLr8CyWuP5NrNS6w5n4grV/3ealEdUj B+KNswtHByK1TKpFGGWyULw2OVRS2BQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-dcEtwBC2MQa6BZs_JJbCow-1; Thu, 08 Jan 2026 09:17:55 -0500 X-MC-Unique: dcEtwBC2MQa6BZs_JJbCow-1 X-Mimecast-MFC-AGG-ID: dcEtwBC2MQa6BZs_JJbCow_1767881874 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43009df5ab3so2102156f8f.1 for ; Thu, 08 Jan 2026 06:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767881874; x=1768486674; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fJ1lT1EolLhB5JifwSURg3jL1WOY3ilSvQ0LTyMqODM=; b=g7sjFu/eqYd8CduJmJi5LBL/NthqffZdBfVYNP9sT9LiRma1mmPz+uA55dl8r3o+P2 9aBN8RtpmX+EPt+OSU70NItWuFCpzVP9lTzO0S3kjaEAW0RFCE4C7CO2Ltl1cdLuMs3p W8sWdOuDHqIBIt0/cnPwvqgIdzHzd87cOZFurOKy2x8JxaKVsuYFUzU7ZK+2zl8wtf9T Tb7WN5/aoUOwSPnXG3rg8+yL4DHPmPSzDFUEmdDn5I8bj2p8nMFEBa2BpHH2YHRdGGOh Et33RI16Zoj2qaq8Cp0r6TJxLtyzonv2QFxTt5Bsh4ILImaEXYrqpadVDKj6B2lb4ABZ 4AYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767881874; x=1768486674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fJ1lT1EolLhB5JifwSURg3jL1WOY3ilSvQ0LTyMqODM=; b=b+4rj9ixC/skhGjZZLCoixAMLL4JG6TpbkhqqShcZfU2vpvqgQKMkSP67+KrGpiWzm 96q6oFunXYdIqx5s93yklhvMhP3iKUG90VkOMyu0w4IlitdizBCfb8oDVZZh5SbyCiCN 3SQpcb6Qf2Ubnmc8sBiG193ibFEWAZ4XivdoVdWfnFvGApGi4LXYjx8nivUokFMacTwk jI6U5W6AeyoclqoohulCh2spzEe+OflogruRPCRnqpNp1byQxyUxzpRhjoiC8wd5f8nO sYzFBL3YIcBpkhYo/27voGUyXQQhQ9W9f46nG2xFvRG5vfPdbylXKAzvB4IETKrR3i1H WHAA== X-Gm-Message-State: AOJu0YylZjLcSK73CapdjvJa2Q5rU8JBisXXx6UGFswTFM2UxSKtq7wW 0AGa73qoH3aDZVqSPRRfcConLjZnoPZUm6KuxyD4CPYHraibVky6BHKWW0vLR8VN2YK9SCrmu5b eFnBGBRP3QawKUUblqtJtLP7uUU++uBe6/vMqWoehKqPUhlCdAIOQmND13e0nJsmIMQ== X-Gm-Gg: AY/fxX7iGFwEEp66lhIxblTFhsMO8lWqTrrH6Ld9iU//XHU75NAB0ZHl8Wci/MWfpcU fK8Do8/zJyhknaIauWvdyFMP6t73eIGc9mhGFaXedLT470+4l+GeLt7mc5nVGfEZ6vpdkXA0FLz jUSbzgAJuYD1m91bgxzq+lJf2ek99GswfXBAgmYLUpxFU+7EDDoZiVTroK9V3LCVa9H0L1wWpkq FPp23so40wBu1y0r9nXhnQ29HTHNTDBjxrGoUuYAAx8b7YsbvaM6GEVjjGsjS7W8oxuWqqe4Oqs c+bPFo9Fw4IIuOnWZIqUjXkRi9S3th/LTXZ1YGbfL2ExHiXc9zXvl3n+eOU1UT7X4EK3W7mRQqZ 5u1Pu2+7AQULtabrHjm4r6jRN+KQ5IZB7cQ== X-Received: by 2002:a05:6000:2483:b0:42f:b0ab:7b48 with SMTP id ffacd0b85a97d-432c3627fbamr7468075f8f.1.1767881874427; Thu, 08 Jan 2026 06:17:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlUVHuOj7/HPTlOMU0+NpCVpFuCnGhMJ1KC00yBihfngclSciPQ4cpm1QXhZzj17NQ1UZXYA== X-Received: by 2002:a05:6000:2483:b0:42f:b0ab:7b48 with SMTP id ffacd0b85a97d-432c3627fbamr7468022f8f.1.1767881873896; Thu, 08 Jan 2026 06:17:53 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee5eesm16735262f8f.34.2026.01.08.06.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:17:53 -0800 (PST) Date: Thu, 8 Jan 2026 09:17:49 -0500 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?iso-8859-1?Q?P=E9rez?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 13/15] vsock/virtio: reorder fields to reduce padding Message-ID: <20260108091514-mutt-send-email-mst@kernel.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jan 08, 2026 at 03:11:36PM +0100, Stefano Garzarella wrote: > On Mon, Jan 05, 2026 at 03:23:41AM -0500, Michael S. Tsirkin wrote: > > Reorder struct virtio_vsock fields to place the DMA buffer (event_list) > > last. This eliminates the padding from aligning the struct size on > > ARCH_DMA_MINALIGN. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > net/vmw_vsock/virtio_transport.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c > > index ef983c36cb66..964d25e11858 100644 > > --- a/net/vmw_vsock/virtio_transport.c > > +++ b/net/vmw_vsock/virtio_transport.c > > @@ -60,9 +60,7 @@ struct virtio_vsock { > > */ > > struct mutex event_lock; > > bool event_run; > > - __dma_from_device_group_begin(); > > - struct virtio_vsock_event event_list[8]; > > - __dma_from_device_group_end(); > > + > > u32 guest_cid; > > bool seqpacket_allow; > > > > @@ -76,6 +74,10 @@ struct virtio_vsock { > > */ > > struct scatterlist *out_sgs[MAX_SKB_FRAGS + 1]; > > struct scatterlist out_bufs[MAX_SKB_FRAGS + 1]; > > + > > IIUC we would like to have these fields always on the bottom of this struct, > so would be better to add a comment here to make sure we will not add other > fields in the future after this? not necessarily - you can add fields after, too - it's just that __dma_from_device_group_begin already adds a bunch of padding, so adding fields in this padding is cheaper. do we really need to add comments to teach people about the art of struct packing? > Maybe we should also add a comment about the `event_lock` requirement we > have in the section above. > > Thanks, > Stefano hmm which requirement do you mean? > > > + __dma_from_device_group_begin(); > > + struct virtio_vsock_event event_list[8]; > > + __dma_from_device_group_end(); > > }; > > > > static u32 virtio_transport_get_local_cid(void) > > -- > > MST > >