public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node
@ 2026-01-08 21:53 Rob Herring (Arm)
  2026-01-08 21:53 ` [PATCH 2/2] ASoC: dt-bindings: realtek,rt5640: Allow 7 for realtek,jack-detect-source Rob Herring (Arm)
  2026-01-12 20:31 ` [PATCH 1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-01-08 21:53 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
	Neil Armstrong
  Cc: linux-sound, devicetree, linux-kernel

The RT5640 has an MCLK pin and several users already define a clocks
entry. A 'port' node is also in use and a common node for codecs.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/sound/realtek,rt5640.yaml        | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
index 3f4f59287c1c..a0b8bf6cb110 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
@@ -47,6 +47,12 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: mclk
+
   interrupts:
     maxItems: 1
     description: The CODEC's interrupt output.
@@ -121,6 +127,9 @@ properties:
       - 2 # Scale current by 1.0
       - 3 # Scale current by 1.5
 
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+
 required:
   - compatible
   - reg
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ASoC: dt-bindings: realtek,rt5640: Allow 7 for realtek,jack-detect-source
  2026-01-08 21:53 [PATCH 1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node Rob Herring (Arm)
@ 2026-01-08 21:53 ` Rob Herring (Arm)
  2026-01-12 20:31 ` [PATCH 1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-01-08 21:53 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
	Neil Armstrong
  Cc: linux-sound, devicetree, linux-kernel

The driver accepts and uses a value of 7 for realtek,jack-detect-source.
What exactly it means isn't clear though.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/sound/realtek,rt5640.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
index a0b8bf6cb110..cd95d7189d34 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
@@ -104,6 +104,7 @@ properties:
       - 4 # Use GPIO2 for jack-detect
       - 5 # Use GPIO3 for jack-detect
       - 6 # Use GPIO4 for jack-detect
+      - 7 # HDA?
 
   realtek,jack-detect-not-inverted:
     description:
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node
  2026-01-08 21:53 [PATCH 1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node Rob Herring (Arm)
  2026-01-08 21:53 ` [PATCH 2/2] ASoC: dt-bindings: realtek,rt5640: Allow 7 for realtek,jack-detect-source Rob Herring (Arm)
@ 2026-01-12 20:31 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2026-01-12 20:31 UTC (permalink / raw)
  To: Liam Girdwood, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
	Rob Herring (Arm)
  Cc: linux-sound, devicetree, linux-kernel

On Thu, 08 Jan 2026 15:53:05 -0600, Rob Herring (Arm) wrote:
> The RT5640 has an MCLK pin and several users already define a clocks
> entry. A 'port' node is also in use and a common node for codecs.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node
      commit: 101b982654ac0305ab286b54d46de79b5b982f3a
[2/2] ASoC: dt-bindings: realtek,rt5640: Allow 7 for realtek,jack-detect-source
      commit: f66e7da2a6b1ba055d47d7c97c9c855729f868ed

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-12 20:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 21:53 [PATCH 1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node Rob Herring (Arm)
2026-01-08 21:53 ` [PATCH 2/2] ASoC: dt-bindings: realtek,rt5640: Allow 7 for realtek,jack-detect-source Rob Herring (Arm)
2026-01-12 20:31 ` [PATCH 1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox