[PATCH] mfd: max77759: drop use of irqd_get_trigger_type

[PATCH] mfd: max77759: drop use of irqd_get_trigger_type

[André Draszik]

irqd_get_trigger_type() is meant for cases where the driver needs to
know the configured IRQ trigger type and e.g. wants to change its
behaviour accordingly. Furthermore, platform support code, e.g. DT
handling, will configure the hardware based on that, and drivers don't
need to pass the trigger type into request_irq() and friends.

Drop the use from this driver, as it doesn't need to know the trigger
type.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/mfd/max77759.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/mfd/max77759.c b/drivers/mfd/max77759.c
index 6cf6306c4a3b25655ff08077b6f94316ab8cae04..a7efe233ec8c829eac20c5ef65bc61856dc8e06e 100644
--- a/drivers/mfd/max77759.c
+++ b/drivers/mfd/max77759.c
@@ -587,9 +587,7 @@ static int max77759_add_chained_charger(struct i2c_client *client,
 static int max77759_probe(struct i2c_client *client)
 {
 	struct regmap_irq_chip_data *irq_chip_data_pmic;
-	struct irq_data *irq_data;
 	struct max77759 *max77759;
-	unsigned long irq_flags;
 	unsigned int pmic_id;
 	int ret;
 
@@ -628,16 +626,8 @@ static int max77759_probe(struct i2c_client *client)
 			return ret;
 	}
 
-	irq_data = irq_get_irq_data(client->irq);
-	if (!irq_data)
-		return dev_err_probe(&client->dev, -EINVAL,
-				     "invalid IRQ: %d\n", client->irq);
-
-	irq_flags = IRQF_ONESHOT | IRQF_SHARED;
-	irq_flags |= irqd_get_trigger_type(irq_data);
-
 	ret = devm_regmap_add_irq_chip(&client->dev, max77759->regmap_top,
-				       client->irq, irq_flags, 0,
+				       client->irq, IRQF_ONESHOT | IRQF_SHARED, 0,
 				       &max77759_pmic_irq_chip,
 				       &irq_chip_data_pmic);
 	if (ret)

---
base-commit: 12b95d29eb979e5c4f4f31bb05817bc935c52050
change-id: 20251217-max77759-mfd-irq-trigger-9063d50fce88

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>

Re: (subset) [PATCH] mfd: max77759: drop use of irqd_get_trigger_type

[Lee Jones]

On Wed, 17 Dec 2025 12:03:58 +0000, André Draszik wrote:
> irqd_get_trigger_type() is meant for cases where the driver needs to
> know the configured IRQ trigger type and e.g. wants to change its
> behaviour accordingly. Furthermore, platform support code, e.g. DT
> handling, will configure the hardware based on that, and drivers don't
> need to pass the trigger type into request_irq() and friends.
> 
> Drop the use from this driver, as it doesn't need to know the trigger
> type.
> 
> [...]

Applied, thanks!

[1/1] mfd: max77759: drop use of irqd_get_trigger_type
      commit: 9a04d9a9d936ec902e5d8a3d1a5079724dca5452

--
Lee Jones [李琼斯]

Re: (subset) [PATCH] mfd: max77759: drop use of irqd_get_trigger_type

[Lee Jones]

On Fri, 09 Jan 2026, Lee Jones wrote:

> On Wed, 17 Dec 2025 12:03:58 +0000, André Draszik wrote:
> > irqd_get_trigger_type() is meant for cases where the driver needs to
> > know the configured IRQ trigger type and e.g. wants to change its
> > behaviour accordingly. Furthermore, platform support code, e.g. DT
> > handling, will configure the hardware based on that, and drivers don't
> > need to pass the trigger type into request_irq() and friends.
> > 
> > Drop the use from this driver, as it doesn't need to know the trigger
> > type.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] mfd: max77759: drop use of irqd_get_trigger_type
>       commit: 9a04d9a9d936ec902e5d8a3d1a5079724dca5452

I applied this for you.  However, if you are going to keep submitting to
MFD, please start using the expected subject line format.

  mfd: subdev: Succinct summary starting with an upper-case char

It would save me a bunch of fixing up if you did.  Thanks.

-- 
Lee Jones [李琼斯]

Re: (subset) [PATCH] mfd: max77759: drop use of irqd_get_trigger_type

[André Draszik]

On Fri, 2026-01-09 at 10:48 +0000, Lee Jones wrote:
> On Fri, 09 Jan 2026, Lee Jones wrote:
> 
> > On Wed, 17 Dec 2025 12:03:58 +0000, André Draszik wrote:
> > > irqd_get_trigger_type() is meant for cases where the driver needs to
> > > know the configured IRQ trigger type and e.g. wants to change its
> > > behaviour accordingly. Furthermore, platform support code, e.g. DT
> > > handling, will configure the hardware based on that, and drivers don't
> > > need to pass the trigger type into request_irq() and friends.
> > > 
> > > Drop the use from this driver, as it doesn't need to know the trigger
> > > type.
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [1/1] mfd: max77759: drop use of irqd_get_trigger_type
> >       commit: 9a04d9a9d936ec902e5d8a3d1a5079724dca5452
> 
> I applied this for you.  However, if you are going to keep submitting to
> MFD, please start using the expected subject line format.
> 
>   mfd: subdev: Succinct summary starting with an upper-case char
> 
> It would save me a bunch of fixing up if you did.  Thanks.

I must admit I indeed forgot to do that on these. Thanks for fixing it
up and applying Lee.

A.