From: Lee Jones <lee@kernel.org>
To: Felix Gu <gu_0233@qq.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd:tc3589:fix a potential resource leak
Date: Fri, 9 Jan 2026 15:41:39 +0000 [thread overview]
Message-ID: <20260109154139.GA1808297@google.com> (raw)
In-Reply-To: <tencent_EFCFAE871E8872447FF88F99091A51701D08@qq.com>
On Fri, 26 Dec 2025, Felix Gu wrote:
> Use devm_request_threaded_irq to repalce request_threaded_irq to avoid
> a potential resource leak.
>
> Signed-off-by: Felix Gu <gu_0233@qq.com>
> ---
> drivers/mfd/tc3589x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
> index 2d4eb771e230..e3aaeb4701b8 100644
> --- a/drivers/mfd/tc3589x.c
> +++ b/drivers/mfd/tc3589x.c
> @@ -410,7 +410,7 @@ static int tc3589x_probe(struct i2c_client *i2c)
> if (ret)
> return ret;
>
> - ret = request_threaded_irq(tc3589x->i2c->irq, NULL, tc3589x_irq,
> + ret = devm_request_threaded_irq(tc3589x->dev, tc3589x->i2c->irq, NULL, tc3589x_irq,
> IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> "tc3589x", tc3589x);
These two lines no longer line-up. Please fix.
> if (ret) {
>
> ---
> base-commit: 3d845d25026c5b1050e927e3ee4c515977a9b490
> change-id: 20251226-tc3589x-fix-50ce3358c7bf
>
> Best regards,
> --
> Felix Gu <gu_0233@qq.com>
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2026-01-09 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 17:39 [PATCH] mfd:tc3589:fix a potential resource leak Felix Gu
2026-01-09 15:41 ` Lee Jones [this message]
2026-01-09 16:08 ` Felix Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109154139.GA1808297@google.com \
--to=lee@kernel.org \
--cc=gu_0233@qq.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox