From: Simon Horman <horms@kernel.org>
To: Chen Zhen <chenzhen126@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, huyizhen2@huawei.com,
gaoxingwang1@huawei.com
Subject: Re: [PATCH v2 net 2/2] selftests: vlan: add test for turn on hw offload with reorder_hdr off
Date: Fri, 9 Jan 2026 17:52:20 +0000 [thread overview]
Message-ID: <20260109175220.GM345651@kernel.org> (raw)
In-Reply-To: <20260107033423.1885071-3-chenzhen126@huawei.com>
On Wed, Jan 07, 2026 at 11:34:23AM +0800, Chen Zhen wrote:
> If vlan dev was created with reorder_hdr off and hw offload both
> off but up with hw offload on, it will trigger a skb_panic bug in
> vlan_dev_hard_header().
>
> Add a test to automatically catch re-occurrence of the issue.
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Chen Zhen <chenzhen126@huawei.com>
Shellcheck warns that cleanup is never invoked.
SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
But is only true if only direct invocations are taken into
account (which I assume is what shellcheck does).
cleanup is actually called on exit as it has been
registered to do so by trap.
In order to keep shellcheck quiet I'd recommend adding the following
to vlan_hw_offload.sh.
#shellcheck disable=SC2329
...
prev parent reply other threads:[~2026-01-09 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 3:34 [PATCH v2 net 0/2] net: vlan: fix skb_panic bug in vlan_dev_hard_header() Chen Zhen
2026-01-07 3:34 ` [PATCH v2 net 1/2] net: vlan: set header_ops to match hard_header_len when hw offload is toggled Chen Zhen
2026-01-07 3:34 ` [PATCH v2 net 2/2] selftests: vlan: add test for turn on hw offload with reorder_hdr off Chen Zhen
2026-01-09 17:52 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109175220.GM345651@kernel.org \
--to=horms@kernel.org \
--cc=chenzhen126@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gaoxingwang1@huawei.com \
--cc=huyizhen2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox