From: Jakub Kicinski <kuba@kernel.org>
To: Suraj Gupta <suraj.gupta2@amd.com>
Cc: <mturquette@baylibre.com>, <sboyd@kernel.org>,
<radhey.shyam.pandey@amd.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<michal.simek@amd.com>, <sean.anderson@linux.dev>,
<linux@armlinux.org.uk>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <bmasney@redhat.com>
Subject: Re: [PATCH 2/2] net: axienet: Fix resource release ordering
Date: Sat, 10 Jan 2026 11:53:06 -0800 [thread overview]
Message-ID: <20260110115306.4049b2cb@kernel.org> (raw)
In-Reply-To: <20260109071051.4101460-3-suraj.gupta2@amd.com>
On Fri, 9 Jan 2026 12:40:51 +0530 Suraj Gupta wrote:
> Device-managed resources are released after manually-managed resources.
> Therefore, once any manually-managed resource is acquired, all further
> resources must be manually-managed too.
only for resources which have dependencies. Please include in the commit
message what exactly is going wrong in this driver. The commit under
Fixes seems to be running ioremap, I don't see how that matters vs
netdev allocation for example..
> Convert all resources before the MDIO bus is created into device-managed
> resources. In all cases but one there are already devm variants available.
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-10 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 7:10 [PATCH 0/2] Add devm_clk_bulk_get_optional_enable() helper and use in AXI Ethernet driver Suraj Gupta
2026-01-09 7:10 ` [PATCH 1/2] clk: Add devm_clk_bulk_get_optional_enable() helper Suraj Gupta
2026-01-09 7:10 ` [PATCH 2/2] net: axienet: Fix resource release ordering Suraj Gupta
2026-01-10 19:53 ` Jakub Kicinski [this message]
2026-01-12 14:53 ` Sean Anderson
2026-01-13 5:32 ` Gupta, Suraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260110115306.4049b2cb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bmasney@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=sboyd@kernel.org \
--cc=sean.anderson@linux.dev \
--cc=suraj.gupta2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox