From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92FFC1E515 for ; Sat, 10 Jan 2026 23:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768088794; cv=none; b=HiTS2VmQe5azPVxTtisVEVxVaHmqyP9R0QVcxUWrZO/BrKtrFKSNX40n7CZPShVX0oJ4a0VQmQH+QolHnrR9JV54W49iaIq/TpBvOPjF/NNmSauiNAxGo8DfZPD1yA097Mt7a4Lq8sf3JHZBAM7YAZT1246qadns5dpinNAEZtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768088794; c=relaxed/simple; bh=jz3bvB1PHTGPTSjDNldaMYUAl7EV4XOYsnYZI7MEa/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E1czE7TNSgTtdSSUePG8fbFTtAN3lbjwLj3MVvoOtxmi44XWH4wB+Dkk5tBODu/cVTmxitZWZJIRHriUjOWgTC049SlsBKgNZK3b/gdap5z5s1UrlbiH834G+l+5gSQnFEyujxSpD2iMUx1KnNzlE2leWJQfz2N8UENDMCLgumM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IA4nTvQq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LNtdS73L; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IA4nTvQq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LNtdS73L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768088792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a6elRUNWlenmQfN0BXFXD2AZTB0rmwpfsMViEoPTV8U=; b=IA4nTvQqhaB/6lCkODFAZFWUDvYGtpqf+W/kRKfOrtQ3/DSxwN7Jn5Qj1RB3kjVdOiCMjx +WoVmD7Kmi5lAfuHTm8CIonLMSE4cAyIf+cEayFD8N9m/VlBRR4G7uvR+psGe7ZW/U3ylt z74EIhSin+yAnGC9/UdWABkA/XDMLQQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-mVy7cfNgNweDKgiePrNUzg-1; Sat, 10 Jan 2026 18:46:29 -0500 X-MC-Unique: mVy7cfNgNweDKgiePrNUzg-1 X-Mimecast-MFC-AGG-ID: mVy7cfNgNweDKgiePrNUzg_1768088788 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477b8a667bcso62306935e9.2 for ; Sat, 10 Jan 2026 15:46:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768088788; x=1768693588; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=a6elRUNWlenmQfN0BXFXD2AZTB0rmwpfsMViEoPTV8U=; b=LNtdS73LZGVRvi8YM4fiPap86TdTpSMXBwAMQSK3jl69bGoDqGYnOiOk+eabxP/Ge/ tPaud6U3sbScpe1BLGxyR3nctd6uZoRPtKKRh6TOspThyI3fg37CZVAsfZsB/7emjXS7 IqxpQteVFE6brFbr2LDmmKStkNVnkoDQ9VorWPt3S8kdzpiSibrk5QntAZoMgWeVneAP xGFD4G3W40zbM99COikmpI5XEh5BiYxAbTojoIRiTXA/QD6j+WttEzjt6SZ7HPey10xf 1NS0TDjPofc24pgQbl+Jd3Y61t3tUN/5ojsP0YT/OlUXRTscB6qFKRpIM7FREPYBjMyp TeEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768088788; x=1768693588; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a6elRUNWlenmQfN0BXFXD2AZTB0rmwpfsMViEoPTV8U=; b=qkhkVbwN4Jm204AXBnpCyrZfcb6GgXKFBAxl5n6z4aa0+L9bNQBVOkYxAvcsw0Y5B5 K1dx2bW2nSnE90vb9oNCDcgD6ZiOOZgGtiAxfRzRdLr2YAjSN9ReZBnydZmL8M8tUopC mYJs3o9UVknGnEwvaR/b1jJUhpE9pB2NyY9jtYsJStfiJLFEY+CCnq0FEoxca63jAlGG PnD4fYmiDHeXKpqQ17EyTPN/kDlYL3LgOb+WunxoW0lXTRrPmFJ54VGZhO8348VDtJLF uHIfQafEAiIDr2LZFUTNdQjkecns+Isr+FWlIVj8Oap0m23sQsgccwNzyBG4BHiS5U/X MQNA== X-Gm-Message-State: AOJu0Yzb+pvYXkWREf/qzk2EeNdDQb0ZHm/dSKGSUVWhhR2idNAJUYnf yAwb8hUOae7cAoPr8nrZYTzyXUcyY7BvJWs5Q129IvJPH9oUhUudRBjp3B9ljOrc0T4IbTVIjXc dq/c/JhRowOfFjsT3I2sWlm9w4twRiVls+vX1v6BFiOzd+C0OF0XBftiCphO8FSjwrA== X-Gm-Gg: AY/fxX7RkiE9nARY/LwRSZPaucBJoIQajm6PnW6FKFgyb0+Cxe599aqcbI/43rGjHKD vr7P4yr+idHBtE6qB/QKa8Xbag4G5yrbaluheZcwVQUg5zceWxcvKH83NJ01muKID8vNgkQ2BGB U8KAe9NY5twMvs5Wf3jIPvKdQyc0+IaSVlPjFQOr16oL1MLhRLruY+6MqTnlYK6Vgjt+Xr4E4Tu fA+MEh7a4CGW/83xh/RNPO0P07Vg+0dX3LF4L+81+ZeHXaSdEZGK5t7hj6jpvki6aDH/WiXNeHG Ct6iOpRnakbk91mrXTg/oBTVxzzFHbYIu4jOMFRt3eLBXNLxFXw06zn10z1JW4vbRU28HQXbLyf mfhnd4Rt90B9tF317Hcxs0tXi1ov1GZE= X-Received: by 2002:a05:600c:a106:b0:47d:73a4:45a7 with SMTP id 5b1f17b1804b1-47d84b3badfmr148899935e9.24.1768088787730; Sat, 10 Jan 2026 15:46:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2ab/QGx2TbXl9n4Rd/6gILYQe8AK5QFNV9Yjv10GRzRcB5XzNkX8wK50oU0rhKiS2cVIRmA== X-Received: by 2002:a05:600c:a106:b0:47d:73a4:45a7 with SMTP id 5b1f17b1804b1-47d84b3badfmr148899705e9.24.1768088787269; Sat, 10 Jan 2026 15:46:27 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f668e03sm289862035e9.14.2026.01.10.15.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jan 2026 15:46:26 -0800 (PST) Date: Sat, 10 Jan 2026 18:46:23 -0500 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, Maxime Coquelin , Laurent Vivier , Cindy Lu , jasowang@redhat.com, Xuan Zhuo , Stefano Garzarella , Yongji Xie Subject: Re: [PATCH v11 04/12] vhost: move vdpa group bound check to vhost_vdpa Message-ID: <20260110184515-mutt-send-email-mst@kernel.org> References: <20260109152430.512923-1-eperezma@redhat.com> <20260109152430.512923-5-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260109152430.512923-5-eperezma@redhat.com> On Fri, Jan 09, 2026 at 04:24:22PM +0100, Eugenio Pérez wrote: > Remove duplication by consolidating these here. This reduces the > posibility of a parent driver missing them. > > Signed-off-by: Eugenio Pérez > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 6 ------ > drivers/vhost/vdpa.c | 2 +- > 3 files changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index ddaa1366704b..44062e9d68f0 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -3640,9 +3640,6 @@ static int mlx5_set_group_asid(struct vdpa_device *vdev, u32 group, > struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev); > int err = 0; > > - if (group >= MLX5_VDPA_NUMVQ_GROUPS) > - return -EINVAL; > - > mvdev->mres.group2asid[group] = asid; > > mutex_lock(&mvdev->mres.lock); > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index c1c6431950e1..df9c7ddc5d78 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -606,12 +606,6 @@ static int vdpasim_set_group_asid(struct vdpa_device *vdpa, unsigned int group, > struct vhost_iotlb *iommu; > int i; > > - if (group > vdpasim->dev_attr.ngroups) > - return -EINVAL; > - BTW is the original ">" here an off by one error? Should have been >= ? if yes then this is a kind of bugfix and maybe needs a fixes tag. > - if (asid >= vdpasim->dev_attr.nas) > - return -EINVAL; > - > iommu = &vdpasim->iommu[asid]; > > mutex_lock(&vdpasim->mutex); > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 05a481e4c385..9d25b735b43d 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -680,7 +680,7 @@ static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd, > case VHOST_VDPA_SET_GROUP_ASID: > if (copy_from_user(&s, argp, sizeof(s))) > return -EFAULT; > - if (s.num >= vdpa->nas) > + if (idx >= vdpa->ngroups || s.num >= vdpa->nas) > return -EINVAL; > if (!ops->set_group_asid) > return -EOPNOTSUPP; > -- > 2.52.0