From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 194791519B4 for ; Sat, 10 Jan 2026 23:48:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768088929; cv=none; b=NsVho/06Fqs5aFCJqmrnbiQJyb9w2JWIoc/741WV6ByL4552hsQthH/p4HPbI5PM5FhJ/IpAr59CvevCpDBLCNDoUPzBXBWPCyCdN63y+y4+c4QI/miq3lEhFMyRmwcSPbGsDKi2hSCelbbL437zyzJorN1VmZ1ykuygCGLftQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768088929; c=relaxed/simple; bh=h0ql6NNHkH04blOJcCQeJQVZ/quwcbXv+V+NyIc09ZU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k3AhInDgnDuApeROEISPkqknsYirC/Qmj0H0/ZX18QY6NyE0EMgOfjLOps5bmbg/37FeFl8V/W7tLUuxOKl99eZo4o9rgAZwd7o1kdsifFSHT7bmbv12azMTuCdr2mEuqFteyXyFj1mXJOLT1y+1xwBOFGMRuvXIsl9Uwc6jraE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bs5YmDVC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ABzx26ru; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bs5YmDVC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ABzx26ru" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768088927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rlBQhD5n0Xt0auvthwhqai5/1JwyKFSNih4sW0Sc9kg=; b=bs5YmDVCJgVwy00gqvr7tTvoLP1AmdgeVrGpVAP1wep0IYlojaR8H3vGhUP7uL4ZZ/3aUy byL+6h2mFEUB9OmJpgfEke2H4uJkMX6jGxTJn23PAwayJmnTyRxToYqw8V/s/gdBarc3qZ +XVGLj+sK8AUBNxugL8HCyyCuE4Vgg8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-q5PhqOlpMGq2WDx_xVDi7Q-1; Sat, 10 Jan 2026 18:48:45 -0500 X-MC-Unique: q5PhqOlpMGq2WDx_xVDi7Q-1 X-Mimecast-MFC-AGG-ID: q5PhqOlpMGq2WDx_xVDi7Q_1768088924 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43284edbbc8so3572841f8f.0 for ; Sat, 10 Jan 2026 15:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768088924; x=1768693724; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rlBQhD5n0Xt0auvthwhqai5/1JwyKFSNih4sW0Sc9kg=; b=ABzx26ru0T+u2fwCyzoMkuR1GlK8zT5BpWEhr52MxddhNUZVtsWIgnSEFKNT1sIf9z zwzrwmIiKEkTuhpHXVyiPZimUHk5Djgp8CcV24C/LhX+2O/Ep8p4R3FgfBbMXSM7j2XJ DGqyMxjWeRGfO3saRFJwfi99iiF2StKFngt099Ucd/7r6wVHv6zPF97RdZ2YRq36acKP qJ/XKToDLI11dNsTpTXR6KF+CxmVFSDm06X1neGMwGH+W+CIn08sVjlIHNu8PwTqaRcx v21kPWfvZJgT3+b2bjSqL30c2g7R156wzijwcRGKiHbzKI5QusiE6ZekSdf9g+UjJ5V6 sSgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768088924; x=1768693724; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rlBQhD5n0Xt0auvthwhqai5/1JwyKFSNih4sW0Sc9kg=; b=Ok8e1aW20vfb4yh9uyYVqED30e1NX/ZCRxLwLnbKo2NkElfAFB14RhpXWlwWIaK46Z yVpRFCbL5TXnisKw1TmqL10S8OZpzr+UIfMl3QadlZzQ+B4moDU3p8k/KfLDn+oQQXjn 491pkzlOfd22C+YOdc1vt6j7JKhKFp8DL961gPowIH+8IvZTMaXGckR5IF6E1akj5+Qw UokBw9QPUCeEN2oLImNNEHeuxBJl+zR86eVfCWMdaUFN7bm0/SQKNAZufwsIeI0gZAHV yR6wfpRHbgaTJnJsHP/mq0YcxELgRq0AQY7FQ7lP1Xk+MXXi6YdEaJ9bc6QbP09BtWyX FV+g== X-Gm-Message-State: AOJu0YyCddxLFT4fLfe1kepNCguC/uYuxtALt6sbQi643LFBDvvTZQxp 0481zJnQ9CbFvvJ0EEiYzKlgSiPUv/JZZ4WTZygLD+CQcpdIc5shkGee2My4D2hi2kRnTWtzRSt KvEE1p26ZYVQZ0+NC7Q0rfTaJA6W25qxaRE2zVevFjURvMezODQ/BUR3XMzVi2wkfDA== X-Gm-Gg: AY/fxX6LT5HpDQ+izt7927ZJ5hmmusG5EH/T/4sc7O4CFcs2v7LpimRDC1Q2YoQ7Tu+ HvjOMaRqyCCo0992097WS6oibFCpwGBAkF2jlwKlDjy0ZDgEYmHHq18yZ0uawza2CpfBSsb7giR SyCsiHGMVPTnWX0m03IXqOOnRvK0raVISCiAjb+IUWmXTHawGJJ5wudaCkOz2qk2Jm+7bir/aVJ WQ7jaf2YocGe6zjKS7XlHg29YJ5KCe+yOYfMCoGEpHBLbD15IvQNkBNDadWri24xAcfJaIg3YQS cxP5zUO/1oIgf4EFphzHFPiVrME6Ao3MtjSjXdoP8u2l2/GhzabyWDoD2L49ZpCIJnxurKg75f0 HB+2XPNXfJiLJASUFE+riLuIwtbMgDa0= X-Received: by 2002:a05:6000:60f:b0:432:84ef:715b with SMTP id ffacd0b85a97d-432c3635410mr14859548f8f.0.1768088923859; Sat, 10 Jan 2026 15:48:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFy/XTpD8HvLWgUxV5E725ZVupCTTaM+lg4Ha1P92WnC07ztkKnxCIls1B33ddmlBmlX2WWWQ== X-Received: by 2002:a05:6000:60f:b0:432:84ef:715b with SMTP id ffacd0b85a97d-432c3635410mr14859531f8f.0.1768088923361; Sat, 10 Jan 2026 15:48:43 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432dd78f5a8sm10071488f8f.27.2026.01.10.15.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jan 2026 15:48:42 -0800 (PST) Date: Sat, 10 Jan 2026 18:48:39 -0500 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, Maxime Coquelin , Laurent Vivier , Cindy Lu , jasowang@redhat.com, Xuan Zhuo , Stefano Garzarella , Yongji Xie Subject: Re: [PATCH v11 05/12] vdpa: document set_group_asid thread safety Message-ID: <20260110184728-mutt-send-email-mst@kernel.org> References: <20260109152430.512923-1-eperezma@redhat.com> <20260109152430.512923-6-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260109152430.512923-6-eperezma@redhat.com> On Fri, Jan 09, 2026 at 04:24:23PM +0100, Eugenio Pérez wrote: > Document that the function races with the check of DRIVER_OK. > > Signed-off-by: Eugenio Pérez > --- > Requested at > https://lore.kernel.org/lkml/CACGkMEvXdV4ukZE6xhLL0sSN70G=AWVQgpRnH98Fr4btzMkK9g@mail.gmail.com/ > --- > include/linux/vdpa.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index 4cf21d6e9cfd..cd1b1f1321b9 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -312,7 +312,9 @@ struct vdpa_map_file { > * @idx: virtqueue index > * Returns the affinity mask > * @set_group_asid: Set address space identifier for a > - * virtqueue group (optional) > + * virtqueue group (optional). It's not thread > + * safe to call this function concurrently with > + * set_status. Let's be explicit about what to do. "Caller must prevent this from being executed concurrently with set_status"? > * @vdev: vdpa device > * @group: virtqueue group > * @asid: address space id for this group > -- > 2.52.0