From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FC9E21D00A for ; Sat, 10 Jan 2026 23:49:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768088954; cv=none; b=Zu55+YCcPRZLkPAoSL4EB2S1QE4HqsCH5fdth2tfhIHYBPqy9oLoj7MDOmPPIAdoovPQk9CKNqWtIPxtavEHYSMno9mjHrXsUDI7f9iiAaP64ztDtt9n3F72vqk/dq1hmY4hn+Vd7JbY9rGj3sfckL/B+boZypT7sxq58f7h74s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768088954; c=relaxed/simple; bh=g8wCfRbUUXiCJohgKskRoYiN0bBaR39H3saqrlPe6WQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GM7DZCzH9zeLQr1yd0KtteMm+Kco8lULdvbHWG1DeGv1QsOXjX8kFEnFke3QtcSxbrOsaWPUOaRKS8hPZ8E8vhcyrQXYYWgIjX7t9WcmTQ2sEiUZyAhHAWqe7/nh0OKRtCz30B1B2l7pa+YkimCPpMgUXMmwQsTZFHDMrn+RThc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IcpQbFaY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=PLAGNLBb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IcpQbFaY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="PLAGNLBb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768088952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v8xEP+5qvKDlBMCCBF0MgL7LbkuTz0yEVMfMRy9ehdM=; b=IcpQbFaYtnVbClPNTf6KH6mzVlaXwm547684GrxoHLIyjeJ16P7ZOFGsTetyOgs4EzFmn4 euWhyh+5YhATh2hDmjak0PKGwDtCif3VNyJeqrgOd+9b0roEY+8vsVyEvlhpl+yLdMGYBz jNkTlEMRyRHlRn1dotYo63YZXcHPId4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-MK-Its-MNxKvltYF99_ozw-1; Sat, 10 Jan 2026 18:49:11 -0500 X-MC-Unique: MK-Its-MNxKvltYF99_ozw-1 X-Mimecast-MFC-AGG-ID: MK-Its-MNxKvltYF99_ozw_1768088950 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-430fdc1fff8so3157111f8f.3 for ; Sat, 10 Jan 2026 15:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768088949; x=1768693749; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=v8xEP+5qvKDlBMCCBF0MgL7LbkuTz0yEVMfMRy9ehdM=; b=PLAGNLBbZ5jlOSfrpBVstY2gyMZR5p1s0t3zRljYV9vnbpBujAxsOJGFHujvz4wprF hNRMsWIHreOM3x9YuD3IBPtpSeSICKkqZSgQWAVRvGnU4pZZ5tpBNf0EFcbB/Akyb1YG lMkcRMYFxFkPymXBnFOsc6w4/4jUvy9KNX7KsgPRhTdq9+FFZNk5mzTpOsuBjSLJ59pk zFZl4E0hAH5uK5t9kNNyN0vsHOzI+p8EcECjveiNaTdiks2LkrIHS/HKRTqiKNYvHPSi 34qTTke7CF4rSjqQhWT5vHTk66VMAzRTjKSnH6zLjaJvtAdUvB2Vlq0VS2lPgccW0kCH Hp7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768088949; x=1768693749; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v8xEP+5qvKDlBMCCBF0MgL7LbkuTz0yEVMfMRy9ehdM=; b=whStpZZ9/NWwNvjh8au9P8uj+Gy+VnThJImpICy3yKX0ZqSzdXBb+L9dZq+lVGcuCK 2G/d9L6ssDvILwLux07R9812N+FbgKCyMrwV4jiKA8wdrJYPfdIMjXS65vdAJqe8d2jw ddnEmLsAeP7zHC5wlBtBS+fbRaDnVUoqBhX7SkuCnSNXrPK7oVzC4G2oA7Ou9XNYLiMr yu5geLn7OZWlvv0j3Vx9I09UUC/IBHAmt4rkx52CNV65neNHLegVFaMbA8rCdWAsq/Th Z4XESmqkSvksEY1kzucwbFNmvep29iZLm2u7pQda7SJI2JGbSaLuMOXwhrmoY8T73XQW RW4Q== X-Gm-Message-State: AOJu0Yzvxi3w9qiM+Tl3U+88D2jQEcSISuZzd+Ou9FpwZKsYAFOj0/yI hg3cBbEc8kb3rpyllflIGshbTWpwwgz6JzfJ8ASbgP61j1rgyw3yKPLdvIuj2+XzW9dZYp4Lx2N Mzz5KyWkNEz/0dHpBFM6DcxmR5hmtJnjb4nbUsa2TlyzNO5bLbbmXJC7q9Gnw/vQ0b7hiP01Jjg == X-Gm-Gg: AY/fxX5k3Muh04znwIDOvvg20FEAqm65wCpnvsDCzkpxBJt6/3B+v87ouP+MNzXgtUt rlk4HxO9XYlWQf3MnN6Yrhjak3RvctolXFOvZkvBY6mCoCztQAsBXDiIGx9dYvQxtpxPK8RpIRd cEQFRyDKMApsqCdECJ6b2LEnAcCvJuymJO8gqZnaZCM029A47X0CvIppffzWuchWKmkxZe0eEqc aAdzJcWFMG0IpyFOtzYQao3fl2FbW8/jCPierjHrytg0S9Lib0GJQT2wP5OIGAmMR/jvFyul8Yj cD4STLFbZFkSa/MFbEkg4I1icNSVhvInfKlvNrImQwMgviiPOS1EDCaaec39mxXO5LvKCi/Ejqf xh0M589iECmknflZ3rFqxuTcL095wr30= X-Received: by 2002:a05:6000:1a8e:b0:432:84ef:713a with SMTP id ffacd0b85a97d-432c3628263mr17160287f8f.12.1768088949660; Sat, 10 Jan 2026 15:49:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHV+eLxIDz0DYsCmG6rwg47r6evQDgeyRNThqqOHlW80rDw+1cEXxEZiRcZ0FcG6DJxB66hdg== X-Received: by 2002:a05:6000:1a8e:b0:432:84ef:713a with SMTP id ffacd0b85a97d-432c3628263mr17160279f8f.12.1768088949227; Sat, 10 Jan 2026 15:49:09 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df90dsm30153428f8f.20.2026.01.10.15.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jan 2026 15:49:08 -0800 (PST) Date: Sat, 10 Jan 2026 18:49:04 -0500 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, Maxime Coquelin , Laurent Vivier , Cindy Lu , jasowang@redhat.com, Xuan Zhuo , Stefano Garzarella , Yongji Xie Subject: Re: [PATCH v11 06/12] vhost: forbid change vq groups ASID if DRIVER_OK is set Message-ID: <20260110184849-mutt-send-email-mst@kernel.org> References: <20260109152430.512923-1-eperezma@redhat.com> <20260109152430.512923-7-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260109152430.512923-7-eperezma@redhat.com> On Fri, Jan 09, 2026 at 04:24:24PM +0100, Eugenio Pérez wrote: > Only vdpa_sim support it. Forbid this behavious as there is no use for behaviour > it right now, we can always enable it in the future with a feature flag. > > Signed-off-by: Eugenio Pérez > --- > drivers/vhost/vdpa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 9d25b735b43d..3f0184d42075 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -682,6 +682,8 @@ static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd, > return -EFAULT; > if (idx >= vdpa->ngroups || s.num >= vdpa->nas) > return -EINVAL; > + if (ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK) > + return -EBUSY; > if (!ops->set_group_asid) > return -EOPNOTSUPP; > return ops->set_group_asid(vdpa, idx, s.num); > -- > 2.52.0