public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: kernel test robot <lkp@intel.com>
Cc: "Eric Dumazet" <edumazet@google.com>,
	oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Maciej Żenczykowski" <maze@google.com>
Subject: Re: include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
Date: Sat, 10 Jan 2026 22:15:08 +0000	[thread overview]
Message-ID: <20260110221508.GF3634291@ZenIV> (raw)
In-Reply-To: <202601110443.5ENBRFej-lkp@intel.com>

On Sun, Jan 11, 2026 at 05:06:31AM +0800, kernel test robot wrote:

Folks, could your bot be taught to recognize that kind of situation?
It's very clear what's going on - an inline function that gets the
same warning with this config every time it is called.  Commit in
question has added several calls of that thing; the origin of warning
has nothing whatsoever to do with it, and that can be guessed without
even looking at the source - the quoted diff between the logs is quite
enough for that.

Looking at the function in question,

> sparse warnings: (new ones prefixed by >>)
>    net/ipv4/datagram.c: note: in included file (through include/net/inet_sock.h, include/net/ip.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> --
>    net/ipv4/raw.c: note: in included file (through include/linux/mroute_base.h, include/linux/mroute.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> --
>    net/ipv4/inet_connection_sock.c:328:36: sparse: sparse: context imbalance in 'inet_csk_find_open_port' - wrong count at exit
>    net/ipv4/inet_connection_sock.c:605:23: sparse: sparse: context imbalance in 'inet_csk_get_port' - unexpected unlock
>    net/ipv4/inet_connection_sock.c: note: in included file (through include/net/inet_sock.h, include/net/inet_connection_sock.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
>    net/ipv4/inet_connection_sock.c:1467:9: sparse: sparse: context imbalance in 'inet_csk_complete_hashdance' - unexpected unlock
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> --
>    net/ipv4/route.c: note: in included file (through include/linux/mroute_base.h, include/linux/mroute.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> --
>    net/ipv4/ip_output.c: note: in included file (through include/net/inet_sock.h, include/net/ip.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> --
>    net/ipv4/af_inet.c: note: in included file (through include/net/inet_sock.h, include/net/ip.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> --
>    net/ipv4/tcp_ipv4.c:3415:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *data @@     got struct tcp_congestion_ops const [noderef] __rcu *tcp_congestion_control @@
>    net/ipv4/tcp_ipv4.c:3415:41: sparse:     expected void const *data
>    net/ipv4/tcp_ipv4.c:3415:41: sparse:     got struct tcp_congestion_ops const [noderef] __rcu *tcp_congestion_control
>    net/ipv4/tcp_ipv4.c:3537:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *data @@     got struct tcp_congestion_ops const [noderef] __rcu *extern [addressable] [toplevel] tcp_congestion_control @@
>    net/ipv4/tcp_ipv4.c:3537:45: sparse:     expected void const *data
>    net/ipv4/tcp_ipv4.c:3537:45: sparse:     got struct tcp_congestion_ops const [noderef] __rcu *extern [addressable] [toplevel] tcp_congestion_control
>    net/ipv4/tcp_ipv4.c:3541:50: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct tcp_congestion_ops const [noderef] __rcu *tcp_congestion_control @@     got struct tcp_congestion_ops * @@
>    net/ipv4/tcp_ipv4.c:3541:50: sparse:     expected struct tcp_congestion_ops const [noderef] __rcu *tcp_congestion_control
>    net/ipv4/tcp_ipv4.c:3541:50: sparse:     got struct tcp_congestion_ops *
>    net/ipv4/tcp_ipv4.c: note: in included file (through include/net/inet_sock.h, include/net/icmp.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
>    net/ipv4/tcp_ipv4.c:1846:25: sparse: sparse: context imbalance in 'tcp_v4_syn_recv_sock' - unexpected unlock
>    net/ipv4/tcp_ipv4.c:2139:17: sparse: sparse: context imbalance in 'tcp_add_backlog' - unexpected unlock
>    net/ipv4/tcp_ipv4.c:2401:21: sparse: sparse: context imbalance in 'tcp_v4_rcv' - different lock contexts for basic block
>    net/ipv4/tcp_ipv4.c:2612:13: sparse: sparse: context imbalance in 'listening_get_first' - wrong count at exit
>    net/ipv4/tcp_ipv4.c:2660:29: sparse: sparse: context imbalance in 'listening_get_next' - unexpected unlock
>    net/ipv4/tcp_ipv4.c:2693:13: sparse: sparse: context imbalance in 'established_get_first' - wrong count at exit
>    net/ipv4/tcp_ipv4.c:2738:40: sparse: sparse: context imbalance in 'established_get_next' - unexpected unlock
>    net/ipv4/tcp_ipv4.c:2870:36: sparse: sparse: context imbalance in 'tcp_seq_stop' - unexpected unlock
>    net/ipv4/tcp_ipv4.c:3091:20: sparse: sparse: context imbalance in 'bpf_iter_tcp_listening_batch' - unexpected unlock
>    net/ipv4/tcp_ipv4.c:3119:40: sparse: sparse: context imbalance in 'bpf_iter_tcp_established_batch' - unexpected unlock
>    net/ipv4/tcp_ipv4.c:3416:41: sparse: sparse: dereference of noderef expression
>    net/ipv4/tcp_ipv4.c:3416:41: sparse: sparse: dereference of noderef expression
>    net/ipv4/tcp_ipv4.c:3538:45: sparse: sparse: dereference of noderef expression
>    net/ipv4/tcp_ipv4.c:3538:45: sparse: sparse: dereference of noderef expression
> --
>    net/ipv4/ping.c: note: in included file (through include/net/inet_sock.h, include/net/ip.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
> --
>    net/ipv4/udp.c: note: in included file (through include/linux/bpf-cgroup.h):
> >> include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
>    include/net/sock.h:2100:16: sparse: sparse: cast from non-scalar
>    net/ipv4/udp.c:1668:28: sparse: sparse: context imbalance in 'udp_rmem_release' - unexpected unlock
>    net/ipv4/udp.c:1700:19: sparse: sparse: context imbalance in 'busylock_acquire' - wrong count at exit
>    net/ipv4/udp.c:1712:28: sparse: sparse: context imbalance in 'busylock_release' - unexpected unlock
>    net/ipv4/udp.c:3305:9: sparse: sparse: context imbalance in 'udp_get_first' - wrong count at exit
>    net/ipv4/udp.c:3322:39: sparse: sparse: context imbalance in 'udp_get_next' - unexpected unlock
>    net/ipv4/udp.c:3370:31: sparse: sparse: context imbalance in 'udp_seq_stop' - unexpected unlock
> 
> vim +2100 include/net/sock.h
> 
>   2096	
>   2097	static inline kuid_t sk_uid(const struct sock *sk)
>   2098	{
>   2099		/* Paired with WRITE_ONCE() in sockfs_setattr() */
> > 2100		return READ_ONCE(sk->sk_uid);
>   2101	}
>   2102	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
> 

  reply	other threads:[~2026-01-10 22:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10 21:06 include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar kernel test robot
2026-01-10 22:15 ` Al Viro [this message]
2026-01-10 22:35   ` Al Viro
2026-01-11 10:08     ` Eric Dumazet
2026-01-12 12:33       ` Peter Zijlstra
2026-01-11 18:20     ` Al Viro
2026-01-11 18:51       ` Al Viro
2026-01-12 12:37       ` Peter Zijlstra
2026-01-12 15:02         ` Will Deacon
2026-01-12 19:21         ` Al Viro
2026-01-12 21:16           ` Al Viro
2026-01-12 22:39             ` David Laight
2026-01-13  0:28               ` Al Viro
2026-01-12 12:32     ` Peter Zijlstra
2026-01-12 19:30       ` Al Viro
2026-01-13 15:27         ` Peter Zijlstra
2026-01-12  0:49   ` Philip Li
  -- strict thread matches above, loose matches on Subject: below --
2025-12-06 10:09 kernel test robot
2025-08-25  4:45 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260110221508.GF3634291@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=maze@google.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox