From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81DB7F507 for ; Sun, 11 Jan 2026 06:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768114014; cv=none; b=Y7PIHfV/WTTniFyHqef4mxnT8wDtC+icaT7tvEwrv94+V2OWGVZmWaO2Rs0IloPnMy4JQl+ny1Tpy2pA8f9275iirL2G3HXTY/LJtbPCvqnxcbcFwbegCgUiNSfCObtOGBHTSEMbT4WpzjQkB34F1fEIizrgGRqM1F5j2LnM2oQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768114014; c=relaxed/simple; bh=oJg0P4BTaPqRMdngCealJvjnKfXREQ/BhzD4UuLebrM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gDrsPyuEoAdBfboicD1I40+/8k7n+spgP8YUFYnN3MMc4kFzrUdh1dD7SGqLhmzDJlJbYMwwo/p6tSmwdHTab1IWl16kvfqt5WehTETn+q81yWykiNZ+WXJBqiKxjHeJkegESvWrq9xA6pneG80e1EzhKJNnS7fbsjAsUmrJR/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O10Je4S/; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BVQkdGxl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O10Je4S/"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BVQkdGxl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768114010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iQ7hDBixKgHX7F8NTcaObvBvSlkQPDzeM4vIOMax5Nk=; b=O10Je4S/0mj3/LPejRBE7XpZW6dJZxWq7pdBqjSJ+NgpqtMdnLJa7kV148aeccSpUFP2ZL mfTtlZwZUnbujfXpqUHVVbEcM33Hnl53hNAIUIFn0gpF1N82jwnhhspOsD40Wk9KPeSkna etzSTUabdkMMByVjIfj1kCGJokTBzf4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-dnrObrgaNZGOshBzski1zA-1; Sun, 11 Jan 2026 01:46:49 -0500 X-MC-Unique: dnrObrgaNZGOshBzski1zA-1 X-Mimecast-MFC-AGG-ID: dnrObrgaNZGOshBzski1zA_1768114008 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47775585257so37139645e9.1 for ; Sat, 10 Jan 2026 22:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768114008; x=1768718808; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iQ7hDBixKgHX7F8NTcaObvBvSlkQPDzeM4vIOMax5Nk=; b=BVQkdGxlmes97/Xxz8ptRBGThZdXBaCNR0MDLkKbuAF+QAWaRq0aWy6rM5ANq0Ci8F ttKuQoJcdSZQ1K28OhZw520jH236Z1kKM63E9pHXMgmwg5S0jTZcCPyJ1l9kymFpk8og r0XSKqzB4ARKbQ7a2fy8jFmmIO2wzpmEDyldZtuEN4ahgEg9QA9y2UEtG8rV1Xz43BB2 z/1wrmbU996DGFBmBP3s5unkBEen2DHH+khnjxTV43UQXvukTqjg8bAjBnPLjdrsxnNI eCrI6+RnKHWIF+7UTKptHPiL65vXp8VbyuBhTuzFiobXPBsK/QNUEaTKCgjSBFg/sPsk wktg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768114008; x=1768718808; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iQ7hDBixKgHX7F8NTcaObvBvSlkQPDzeM4vIOMax5Nk=; b=nc9RQwBZH4h/hzbdg/EcS7hUns/6YcO5upbCPpDy1bsVA77RzEsSETpafWwsj6sOy3 Xx+saROSSF47rYGywhkcw6UVBzAhl6VDul0hr8qDyTl0zBFR2M97Gdq4mOkgp2ice22r 4P7tabyWxgUt2MePHpengpylbp5k1yPfdVW2GrNqa3rvH5KMDAAmTBwFW+HeqeFlP7gr 8x/bZtIK1O8i9gQmylzDp/ovoGvUWhWsBMJ0kAD56ArtcorFc46ww3S+bvJxva8sI8Bk DmFQcryJ7MwIG3X2Rq35tzQCYVLy7WKInAY61nYKFXHNgEhtvdS9u3nyyBW2AfnOnEH6 3qZg== X-Forwarded-Encrypted: i=1; AJvYcCVxES0ghX1r+UWy6fVJOMWqN0DGMfSUDs2svIB7fZ+Je/eGnGjyUdePW0ak0wR5x/rcJjrnwhLAUu/mP64=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu326cmM7CFYUM3h9LXqPreav7MHYRIrqf0MIi1I4mJYhX2AmG HdCl0zb6+lBDctj+lh2fiICwTMhJdyw/vd+qwUU2As1CsJQD50YnrXnQa/7tT+ISIpn/My0Zw0V Mz2MsAzomj4KNhIDvnkt54D109EOpEtmFssZF5UU1+wcDD+rgIL86dRsFIOH+DRiJGg== X-Gm-Gg: AY/fxX43FhO0CG+VdczPSUTT0Zs9BXfObVdnehRem2z5BA2+O1BLzpctzIKh6YHLXXI 0Aom+pU7mW8CnwC4eb1HIk8ptpV8lGJBzbZ9KznqFnh3sP2Fh1xub5g22ZuTt5+bI0E0jP+mmwn UPhpSD1WPydusHQHYUzuKy4VXmgGw2o9i9NK7ylonXLTn7m+m49z02nWeawTRKtocr303a2s2rL 5wEbbKT9oEzmDpUQApz+cZeFqhWtVGD6syGLU8wkbrRCJTqI0OfWZ+ImcM++H0pdVn9YvfjCmTy pRlZ4XbuyFVX1/t1RkbSl2mk6BOrNhZXAY3cyNUIj2h2vkcEXRuoMkXGauproH3PnjRxOM3rzCB nZi51bN0kxMYIibInf3Aupn7utYvrGf0= X-Received: by 2002:a05:600c:444c:b0:477:7b16:5f77 with SMTP id 5b1f17b1804b1-47d84b0b303mr138047665e9.3.1768114008096; Sat, 10 Jan 2026 22:46:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2KhXxY5wNvI0FhPEnxgIqYrJLuszMdozjkRjhQaSurG33CO00c2A2r97DP2kFBqnSLT0brQ== X-Received: by 2002:a05:600c:444c:b0:477:7b16:5f77 with SMTP id 5b1f17b1804b1-47d84b0b303mr138047395e9.3.1768114007653; Sat, 10 Jan 2026 22:46:47 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d865e3d22sm102237315e9.1.2026.01.10.22.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jan 2026 22:46:47 -0800 (PST) Date: Sun, 11 Jan 2026 01:46:43 -0500 From: "Michael S. Tsirkin" To: Bobby Eshleman Cc: Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan , Long Li , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , Bobby Eshleman Subject: Re: [PATCH RFC net-next v13 03/13] virtio: set skb owner of virtio_transport_reset_no_sock() reply Message-ID: <20260111014500-mutt-send-email-mst@kernel.org> References: <20251223-vsock-vmtest-v13-0-9d6db8e7c80b@meta.com> <20251223-vsock-vmtest-v13-3-9d6db8e7c80b@meta.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251223-vsock-vmtest-v13-3-9d6db8e7c80b@meta.com> On Tue, Dec 23, 2025 at 04:28:37PM -0800, Bobby Eshleman wrote: > From: Bobby Eshleman > > Associate reply packets with the sending socket. When vsock must reply > with an RST packet and there exists a sending socket (e.g., for > loopback), setting the skb owner to the socket correctly handles > reference counting between the skb and sk (i.e., the sk stays alive > until the skb is freed). > > This allows the net namespace to be used for socket lookups for the > duration of the reply skb's lifetime, preventing race conditions between > the namespace lifecycle and vsock socket search using the namespace > pointer. > > Reviewed-by: Stefano Garzarella > Signed-off-by: Bobby Eshleman > --- > Changes in v11: > - move before adding to netns support (Stefano) can you explain about the revert please? I looked at feedback from Stefano and all he said aparently was not to break bisect. > Changes in v10: > - break this out into its own patch for easy revert (Stefano) > --- > net/vmw_vsock/virtio_transport_common.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > index fdb8f5b3fa60..718be9f33274 100644 > --- a/net/vmw_vsock/virtio_transport_common.c > +++ b/net/vmw_vsock/virtio_transport_common.c > @@ -1165,6 +1165,12 @@ static int virtio_transport_reset_no_sock(const struct virtio_transport *t, > .op = VIRTIO_VSOCK_OP_RST, > .type = le16_to_cpu(hdr->type), > .reply = true, > + > + /* Set sk owner to socket we are replying to (may be NULL for > + * non-loopback). This keeps a reference to the sock and > + * sock_net(sk) until the reply skb is freed. > + */ > + .vsk = vsock_sk(skb->sk), > }; > struct sk_buff *reply; > > > -- > 2.47.3