From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B9DB30DEB2 for ; Mon, 12 Jan 2026 04:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768192412; cv=none; b=NZgGBSqXNQEtcooVRmlQrgHOg7WpacyHI4PapvgNZLOxpGjxUXgAl8QL5zAP3GDAUKkGy+KbIuQXAwXkrBZTuVupIflk3254/42NbV6WwKx2yQNK+yMrVs869rvP6BIrcHdQkqQT5fUoa/Jwu9719A84Lxr8JT0y0s3wbDM0Dtc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768192412; c=relaxed/simple; bh=JsECp4e88xlO5Vo5MlkaWcurekx6DybzbgYXNqaqYFQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k9Ka5o5DvlhVHsgfoAvJZsaz7taXwLAJLbqkJ09S+PSWKsADh3fuB3z10cqPg4wZmGjtWXA6Om5NuZON1OU0WeKyhIX4WirF6XD7JQ5qDG0g6X7ICXQA9Qn6QV9aK2Igu0te8FwSVR3plRisx6Rjo78wrjPMkPq3cfuNmFYRk0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LL3ls3Z8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=YFHfq020; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LL3ls3Z8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="YFHfq020" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768192399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=APuQMk+mj1Ir7IfbwA6rsBMcZIxIkKakSr4yNu5ZY2w=; b=LL3ls3Z8q7RhjKQs3zugKDbfkxrinnAKcf2x/xOSkb36WHq48dF0zZPTpLu4wcRZJs2Iwx N86qd9dXPl/pcqQ1AhHbLyK+TV8PU62SBbkJchk6m7eUw43Jpiw4CfKszYeuR7uS9wus6a n+CbBpQT33GRHTI2FT8sE8W1zcrnov0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-mqnqT1syOAyWwzwhgnnTuw-1; Sun, 11 Jan 2026 23:33:16 -0500 X-MC-Unique: mqnqT1syOAyWwzwhgnnTuw-1 X-Mimecast-MFC-AGG-ID: mqnqT1syOAyWwzwhgnnTuw_1768192396 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-430f527f5easo2543969f8f.1 for ; Sun, 11 Jan 2026 20:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768192395; x=1768797195; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=APuQMk+mj1Ir7IfbwA6rsBMcZIxIkKakSr4yNu5ZY2w=; b=YFHfq020Vt3bDyZRQW4KC3y5reYzFzeObefGorrgPwesZ5/BaDvKBK0oi0YtVRVgdW TNIE806/WoNrYxhwjBiEVJ2VMH8+UJwosB9Bf4fRjXw4LesWgJBYxC48FbC8cNg/92I0 LCq1NOfpyrCKV3ENRj3t3EI6aZz1ZueFGQFszHfs+RJAz7XFAXet7joTmMrk2Kkya3sj gl/WmDnm87twqD4gYOZegRr0gXniuhdAIMMyk3Ofz23Pz041SCT/CdCq3K3SxVw41EmL VI/c2sJMIbUvJ1l2JzrHfgzMRrDOvykrYh+4aAs+OBMmxG21p15IhrZA30oaqbLGtL6S qSgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768192396; x=1768797196; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=APuQMk+mj1Ir7IfbwA6rsBMcZIxIkKakSr4yNu5ZY2w=; b=UKN3WClrO5F3R3si0ui28xkycTsdeaNML3NTbOUN5oE4Fvbh7A0H6iJyMO2uEciLfw IYniluHkd3zEcmVRnLsvCmlC88AJDUYbyvMkBRYTf9hbC/DKTJ6mmgXTOiRoTO/5V6Jr K019DQd2NsiZFl7DsYa1NPypeRss1dPyCjP6j0fviQ8Aovma0rXcWrZRtXJCDffqWWBx lVnFXajYhRyJJ4R+sTWeaZ5Gj3ObHs7PqYaQxZJZWYXI49eQu7uuE5SsyvM3qhIcmfyU QCFB4uqxAGxOrL17DjYKu+arsEAIq5WfLUm3QEEvu45DbNw9s7EiPO5jANcN6A1nzPHX VQFw== X-Forwarded-Encrypted: i=1; AJvYcCXRZWSihegMxhNZdka6BBQ/7TWmt+xxC3dBNHOECN303EloNO/XOuC1onq89BpEmO7yogZVkxga0WbZgUw=@vger.kernel.org X-Gm-Message-State: AOJu0YznbCdIZZLR96yTTuG9ImpoPZ8VnX0Z/y1NVD3RYE/9jhyjP/59 2pWIU86CB51OyqJk7duXxpebUMiZZpS3U7pes1+BgtxViJPRiTjmslwLRCgpfyDOIwEp0Y4EhB/ 1UYncqPnQRBB45IfRcqkzTPgffXcR0g4Uuyp2/xHvSAr3nW/JQ+YJBVrVPXNfvAQi9w== X-Gm-Gg: AY/fxX7By3NKdQgdXgst1c4wphq+kpqM5m10MKEfW3xZEUg+TTcumtGOvCwAXJYAsLY tmXH8yEqZO84nkkp4TDtK6LzmAGPvTx7hR/r+NKoQx5UQKo5uhpumgFivAy+gST0cRsSWSHPsAz j4od6iF8KZcTSkfl+UUmuO0XKPXFT2bJYSmXIgjD2OYdHkxGRVB9dfHDd8X+DzWFsldMpv4hcni nbMS6goId5wScJ+04P1ZoQKpPjh9c2zP1sgMWSRDoYeYtWwIoa9rcXp8x7fHS3gqXvH2pPEh6RP 2q7ZxB5aEJMU4GQZCHfZlGIqK9Ske+gdwvggKy6opAgtsTDunsQoOSwGzDb6AZ6XuuRj814DkYQ ynXcvxBCUsYPg0zdlTEr1gOCIW3yApLY= X-Received: by 2002:a05:6000:18c5:b0:432:da7c:5750 with SMTP id ffacd0b85a97d-432da7c589cmr7999794f8f.20.1768192395664; Sun, 11 Jan 2026 20:33:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/BXpYp147sy8NHGo+1rbRx2BpHOkLFAtFBJEDqcFXZDM5sBWqhXQb6dEWZIhQYfgNrNPMPA== X-Received: by 2002:a05:6000:18c5:b0:432:da7c:5750 with SMTP id ffacd0b85a97d-432da7c589cmr7999782f8f.20.1768192395211; Sun, 11 Jan 2026 20:33:15 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee5e3sm35982021f8f.35.2026.01.11.20.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 20:33:14 -0800 (PST) Date: Sun, 11 Jan 2026 23:33:10 -0500 From: "Michael S. Tsirkin" To: Simon Schippers Cc: Jason Wang , willemdebruijn.kernel@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eperezma@redhat.com, leiyang@redhat.com, stephen@networkplumber.org, jon@nutanix.com, tim.gebauer@tu-dortmund.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH net-next v7 9/9] tun/tap & vhost-net: avoid ptr_ring tail-drop when qdisc is present Message-ID: <20260111233129-mutt-send-email-mst@kernel.org> References: <20260107210448.37851-1-simon.schippers@tu-dortmund.de> <20260107210448.37851-10-simon.schippers@tu-dortmund.de> <900c364b-f5ca-4458-a711-bf3e0433b537@tu-dortmund.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <900c364b-f5ca-4458-a711-bf3e0433b537@tu-dortmund.de> On Fri, Jan 09, 2026 at 11:14:54AM +0100, Simon Schippers wrote: > Am I not allowed to stop the queue and then return NETDEV_TX_BUSY? We jump through a lot of hoops in virtio_net to avoid using NETDEV_TX_BUSY because that bypasses all the net/ cleverness. Given your patches aim to improve precisely ring full, I would say stopping proactively before NETDEV_TX_BUSY should be a priority. -- MST