From: Rob Herring <robh@kernel.org>
To: William Zhang <william.zhang@broadcom.com>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Kamal Dasu" <kdasu.kdev@gmail.com>,
"Nick Terrell" <terrelln@fb.com>,
"David Sterba" <dsterba@suse.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Simon Glass" <sjg@chromium.org>,
"Linus Walleij" <linusw@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Tony Lindgren" <tony@atomide.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 01/10] dt-bindings: mtd: brcm,brcmnand: Drop "brcm,brcmnand" compatible for iProc
Date: Mon, 12 Jan 2026 09:48:05 -0600 [thread overview]
Message-ID: <20260112154805.GA271138-robh@kernel.org> (raw)
In-Reply-To: <CAHi4H7GvSsX=BO2AWy4BB=FfQ8bWx_C3PBh9UQHYOo+G247P_g@mail.gmail.com>
On Fri, Jan 09, 2026 at 10:05:04AM -0800, William Zhang wrote:
> Hi Rob,
>
> On Thu, Jan 8, 2026 at 9:53 AM Rob Herring (Arm) <robh@kernel.org> wrote:
> >
> > Some users of "brcm,nand-iproc" include "brcm,brcmnand" and some don't.
> > The "brcm,brcmnand" compatible is not useful for iProc systems as
> > there's a separate driver for iProc. So drop it as a fallback.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> > index 064e840aeaa1..3105f8e6cbd6 100644
> > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> > @@ -66,7 +66,6 @@ properties:
> > items:
> > - const: brcm,nand-iproc
> > - const: brcm,brcmnand-v6.1
> > - - const: brcm,brcmnand
> > - description: BCM63168 SoC-specific NAND controller
> > items:
> > - const: brcm,nand-bcm63168
> >
> > --
> > 2.51.0
> >
>
> Another fix would be adding brcm,brcmnand to the users of
> brcm,nand-iproc to keep consistency with all other brcmnand chips and
> utilize the fallback mechanism in the driver, although I agree it does
> not happen in real life case.
> I don't have any strong opinion either way but a follow-up change is
> needed to remove the fallback from the brcm,nand-iproc dts files if we
> go this route.
The question to ask on a fallback is "is it usable on its own?". IOW,
would a driver than only understands brcm,brcmnand function in this
case. Given iproc needs its own driver and specific handling, the answer
is no here.
Plus, this matches what dts files actually have at least for the arm64
ones.
Rob
next prev parent reply other threads:[~2026-01-12 15:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 17:53 [PATCH 00/10] dt-bindings: mtd: Partition binding fixes and restructuring Rob Herring (Arm)
2026-01-08 17:53 ` [PATCH 01/10] dt-bindings: mtd: brcm,brcmnand: Drop "brcm,brcmnand" compatible for iProc Rob Herring (Arm)
2026-01-09 8:56 ` Krzysztof Kozlowski
2026-01-09 18:05 ` William Zhang
2026-01-12 15:48 ` Rob Herring [this message]
2026-01-14 19:31 ` William Zhang
2026-01-08 17:53 ` [PATCH 02/10] dt-bindings: mtd: fixed-partitions: Move "compression" to partition node Rob Herring (Arm)
2026-01-09 8:58 ` Krzysztof Kozlowski
2026-01-09 11:31 ` Simon Glass
2026-01-08 17:53 ` [PATCH 03/10] dt-bindings: mtd: partitions: Move "sercomm,scpart-id" to partition.yaml Rob Herring (Arm)
2026-01-09 9:22 ` Krzysztof Kozlowski
2026-01-08 17:53 ` [PATCH 04/10] dt-bindings: mtd: partitions: Allow "nvmem-layout" in generic partition nodes Rob Herring (Arm)
2026-01-09 9:26 ` Krzysztof Kozlowski
2026-01-08 17:53 ` [PATCH 05/10] dt-bindings: mtd: partitions: Define "#{address,size}-cells" in specific schemas Rob Herring (Arm)
2026-01-09 9:31 ` Krzysztof Kozlowski
2026-01-12 15:50 ` Rob Herring
2026-01-08 17:53 ` [PATCH 06/10] dt-bindings: mtd: partitions: Drop partitions.yaml Rob Herring (Arm)
2026-01-09 9:34 ` Krzysztof Kozlowski
2026-01-12 22:57 ` Rob Herring
2026-01-08 17:53 ` [PATCH 07/10] dt-bindings: mtd: Ensure partition node properties are documented Rob Herring (Arm)
2026-01-09 9:02 ` Miquel Raynal
2026-01-10 0:34 ` Rob Herring
2026-01-14 13:58 ` Miquel Raynal
2026-01-14 17:47 ` Rob Herring
2026-01-09 9:36 ` Krzysztof Kozlowski
2026-01-10 0:25 ` Rob Herring
2026-01-11 9:45 ` Krzysztof Kozlowski
2026-01-08 17:53 ` [PATCH 08/10] dt-bindings: mtd: fixed-partitions: Restrict undefined properties Rob Herring (Arm)
2026-01-08 17:53 ` [PATCH 09/10] dt-bindings: mtd: partitions: Convert brcm,trx to DT schema Rob Herring (Arm)
2026-01-08 17:53 ` [PATCH 10/10] dt-bindings: mtd: partitions: Combine simple partition bindings Rob Herring (Arm)
2026-01-19 10:48 ` [PATCH 00/10] dt-bindings: mtd: Partition binding fixes and restructuring Miquel Raynal
2026-01-20 1:54 ` Rob Herring
2026-01-20 14:56 ` Miquel Raynal
2026-01-20 15:13 ` Krzysztof Kozlowski
2026-01-20 16:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112154805.GA271138-robh@kernel.org \
--to=robh@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsterba@suse.com \
--cc=hauke@hauke-m.de \
--cc=kdasu.kdev@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marcus.folkesson@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=rogerq@kernel.org \
--cc=sjg@chromium.org \
--cc=terrelln@fb.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox