From: Krzysztof Kozlowski <krzk@kernel.org>
To: Edelweise Escala <edelweise.escala@analog.com>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Add Support for LTC3220 18 Channel LED Driver V2
Date: Tue, 13 Jan 2026 09:02:25 +0100 [thread overview]
Message-ID: <20260113-remarkable-determined-pogona-bfb2ab@quoll> (raw)
In-Reply-To: <20260112-ltc3220-driver-v2-0-d043058fc4df@analog.com>
On Mon, Jan 12, 2026 at 04:55:53PM +0800, Edelweise Escala wrote:
> The LTC3220/LTC3220-1 is a multi-display LED driver, which contains a
> high-efficiency, low-noise charge pump to provide power to up to
> 18 LED current sources. The LEDs are individually configurable to
> 64-step linear brightness control, blinking and gradation control
> via 2-wire I2C interface. The blinking and gradation configuration
> is shared across all LED.
>
> LTC3220 has a quick write function which allows changing the brightness
> on all LEDS simultaneously when the brightness is changed on led 1.
> For this we made quick write a device property which user can set on the
> device tree. We would like to know if this approach is alright?
> Another way we might want to know is, is it alright to just make a
> virtual led for the quick write function. Changing brightness on
> the virtual led will change the brightness for all.
>
> V2 Changelog:
> leds-ltc3220.yaml changes
> -Fix wrapping on description
> -Improve description and commit messge to describe hardware
> -Drop ltc3220-1
> -Drop charge pump
> ltc3220.c changes
> -Fix wrapping
> -Drop ltc3220-1
> -Drop devname_mandatory
>
> Signed-off-by: Edelweise Escala <edelweise.escala@analog.com>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
Huh?
> - Link to v1: https://lore.kernel.org/r/20260106-ltc3220-driver-v1-0-73601d6f1649@analog.com
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-13 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 8:55 [PATCH v2 0/2] Add Support for LTC3220 18 Channel LED Driver V2 Edelweise Escala
2026-01-12 8:55 ` [PATCH v2 1/2] dt-bindings: leds: Add LTC3220 18 channel LED Driver Edelweise Escala
2026-01-13 8:06 ` Krzysztof Kozlowski
2026-01-14 0:16 ` Escala, Edelweise
2026-01-12 8:55 ` [PATCH v2 2/2] leds: ltc3220: Add Support for " Edelweise Escala
2026-01-12 16:38 ` kernel test robot
2026-01-13 8:02 ` Krzysztof Kozlowski [this message]
2026-01-13 8:12 ` [PATCH v2 0/2] Add Support for LTC3220 18 Channel LED Driver V2 Escala, Edelweise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113-remarkable-determined-pogona-bfb2ab@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=edelweise.escala@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox