From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71D272BE620 for ; Tue, 13 Jan 2026 12:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768307607; cv=none; b=JZFHEtSu/Qwr6rqINGuVhOxLqVsfpoC5U32WfJfY5ZBZ8srPrdeBeEj+NrIL42hxqa7uWwFZQLemi+tmBQSxM6XHSqyIIoO56dTeZ96lo5x8y/3mD2TTLqDZy5buHD2vr+sCEeAdyDJVRMBrgT6R+C4/9NEwTbf034poi3bye3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768307607; c=relaxed/simple; bh=6ecGZ2d0lixE/Vwo2sVcn63719XFUNP8WDR4oETdiLs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ouqGf6RT7qhpALSL2STiJmRnwvG1n1D4z9DRE6hHwaavQLdyefp12cPt549ZhslRRO/BOkQdi8rHMMRPlhp857ZmbTtkXxsPJ34OPRQBjIlnDSuvtWQaSlQaZ9+z/srTtlodxsBzc41t2Xu6h0cMwcDOZ8zITkmz2F+chCYVxhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FMsthlMr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FMsthlMr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F1C4C116C6; Tue, 13 Jan 2026 12:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768307607; bh=6ecGZ2d0lixE/Vwo2sVcn63719XFUNP8WDR4oETdiLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FMsthlMrK8E8Y5/a6o9VATO0HkcZvthmGbvrTqzfZ3WuhDVi0W3S0De4DVgwUiVVr jzFo/9vWpLkERor5cNa57bmrjTtUi8/f2AKMd04OkoyX/LL3sW0UbhHKCAqP1KyARP IpKbiOluHBc5E4/gblg4D90WFgqgGMf4sjzrDhN0eTsMCOOK4SVfcLhqyJ9mSF4DVM cV4xUXdhvTH8JuXbh89LzNMvVlbhuq9gFGf1kdbbuToBTqFL0p64w6ZmZzb6Sru71Z g8OjsSVi5AEQMwoQgVIz25MWdk3SZwoW646Ag80f3lKvn3lliolb5wKc4321VcNIGQ zyNN+B53YtRng== Date: Tue, 13 Jan 2026 12:33:22 +0000 From: Lee Jones To: Marek Vasut Cc: linux-kernel@vger.kernel.org, Pascal PAILLET-LME , Paul Cercueil , Sean Nyekjaer , kernel@dh-electronics.com Subject: Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused Message-ID: <20260113123322.GI1902656@google.com> References: <20260109041301.1344783-1-marex@nabladev.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260109041301.1344783-1-marex@nabladev.com> On Fri, 09 Jan 2026, Marek Vasut wrote: > Attempt to shut down again, in case the first attempt failed. > The STPMIC1 might get confused and the first regmap_update_bits() > returns with -ETIMEDOUT / -110 . If that or similar transient > failure occurs, try to shut down again. If the second attempt > fails, there is some bigger problem, report it to user. > > Fixes: 6e9df38f359a ("mfd: stpmic1: Add PMIC poweroff via sys-off handler") > Signed-off-by: Marek Vasut > --- > Cc: Lee Jones > Cc: Pascal PAILLET-LME > Cc: Paul Cercueil > Cc: Sean Nyekjaer > Cc: kernel@dh-electronics.com > --- > drivers/mfd/stpmic1.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c > index 081827bc05961..9ef4049d7db10 100644 > --- a/drivers/mfd/stpmic1.c > +++ b/drivers/mfd/stpmic1.c > @@ -121,9 +121,23 @@ static const struct regmap_irq_chip stpmic1_regmap_irq_chip = { > static int stpmic1_power_off(struct sys_off_data *data) > { > struct stpmic1 *ddata = data->cb_data; > + int ret; > + > + ret = regmap_update_bits(ddata->regmap, MAIN_CR, SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF); > + if (!ret) > + return NOTIFY_DONE; > + > + /* > + * Attempt to shut down again, in case the first attempt failed. > + * The STPMIC1 might get confused and the first regmap_update_bits() > + * returns with -ETIMEDOUT / -110 . If that or similar transient > + * failure occurs, try to shut down again. If the second attempt > + * fails, there is some bigger problem, report it to user. > + */ > + ret = regmap_update_bits(ddata->regmap, MAIN_CR, SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF); I think it would be better to put it into a loop with 2 retries. > + if (ret) > + dev_err(ddata->dev, "Failed to access PMIC I2C bus (%d)\n", ret); > > - regmap_update_bits(ddata->regmap, MAIN_CR, > - SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF); > > return NOTIFY_DONE; > } > -- > 2.51.0 > -- Lee Jones [李琼斯]