From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D49D1AAE13 for ; Tue, 13 Jan 2026 18:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768329845; cv=none; b=W0HIfpH74EKj0B39/VKrxhv+iXaf4KwVfajEzP9JPl5HSJ8SquC9Mj57Cp5zjp48h4QSHzhZtIidhQvrXcPCY/Hs2tX/rx1FAH4ue9fUW5lMjbg8d+mL4SWMdwru/jc/idM6VPnIyrLtUqtHflxyEENh2UYSTXiA5Dhp99/RXug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768329845; c=relaxed/simple; bh=xSblpv1+feR90aL5HFn3tAxo9ckC7A0g7egqXysDGJA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=USQhPMIRCzrTlgmvIuXqLkDXS9HB9B0QfV2htb5Oz6eVHTxqfokcU9mQ1ApiqIIO4FzSBeCylyEjX5ThacXuEyMVTW35xDhFKfhvbONZzf1FPo5lRPd7s/UunZWd3ualHZiwc/zLmw2PdyRgBfLbVjRuaKkuVVSSz35d9UN5UJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HhUM05yP; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HhUM05yP" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-47ee2aa5e9eso113315e9.2 for ; Tue, 13 Jan 2026 10:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768329842; x=1768934642; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=otjCmmwqJAoCrWGsYK9wh0yxCuYEdxKqK4Mr5JWnvkg=; b=HhUM05yPU3ET14f/DAKzRbhy1LaTOCyUka7omzYpz7PNh+1o4RlgX/6U0jHPM5Gl9+ 7RlwYaLEr4Ypbvmdtt0DJgkpS6I+JshFPxV+gwKgWEopUE4gahi9FV8+vd6N01EmXeIV Ks8f4qxnWL2GL/M60zXBLMniOl0PllJyUM9PVlkUaSIBR2axfsnqrTJHk4SftuFWOxlS G17F3BeKOa17Yba4OilPzOqqcE8VKAxO/mORa33ZduquNaw+52CJ/82CKWdWLclA16bg zedNf9hUp/Bu7sJnKJwnt8c4kJSVr4/2bnPI0cAQIWgujzCyR8gxuelvZzNj+SyRV1Ac tR8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768329842; x=1768934642; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=otjCmmwqJAoCrWGsYK9wh0yxCuYEdxKqK4Mr5JWnvkg=; b=Ch/Pp95+m0ABeKDxHwLkzILwU+zFn+BAM5OgG0FcFhVO4KOLlLOur297T6B92CyHiX haqQFAAeI3odVJAWRK8IFCm9mydJ1pHdLg/HA7kmXl9LHqWWXJdhBk02x3AvwFJXoyiN sYbH8kQdElEKlJueNqnhq+SHVd0YM5M4HQ3pbGbT3ZNNj0Yfk8bQCQE7TUQRFhSLoIkl cNgSIFW/zQlzAPyl8lbFQfXTZIBEjXUDwjgkw/XP7BMxeW47LpmWBS2uOaDnDQLLbFAU npLVfXR3CNRXi3udaR9pY2qTcrkrLw3du1uAhuu51vMVs92v58Ke0bgkr4xG7pjZX8Af JVaQ== X-Forwarded-Encrypted: i=1; AJvYcCVzSV0uZgQwLY+bhOk88LXNQp1UGgT/TSoWj7PRihpGoaFGtCqPaSb8Nx+0EOTV+WmsHaHtRaDTfjqPqDk=@vger.kernel.org X-Gm-Message-State: AOJu0YwsPssOgCsuVBItlJL/xYObMMLcy8ks5OCgqsHLf0XyNqlk1do0 NNJQ/O3+fC0V21TgsvLyXcvkHLhXPSv2LtxaLIoVFEXwCPEhOGnYBHG6 X-Gm-Gg: AY/fxX76RPKGlLQEhyGPevQgoBrpkuyHIS2ByPE0I79Te0lwm0foIHKrCgvRhiZjCeE 34/jSW/Ljz5IKrJeG+KWs8kMJtzAiVu4r9/wDVsxkWpCdK4cDY6lKkEpb7fZHJ0UiC7y/hiLOOI sZbazmOgB1qp2KUJLPO+WgyAAOoWUnP+XvTxj6wh0mZByXmMtup/SFdtFd8sWM10YCDoCnr7V7p u98rh+pJubjHTIqxs+Is8myRwpuuctVkoi7gwMAgKOOdUCpU2ppZ0EAeoaGw9iEUYs19tPMwURZ sFjGXHA31+UKbi6VK0HC0DF4HllnRdZEGM4CuQrldx9hF5pf8Lf3CK3RywQI6oKeClCes+94+OA xqJYekaonafvUea+OgOFt1XGjB+wQ8/OvO2mcj7ffKHzAu+6R1AmtbNHuWUNctXANYME9697mwY GfHw== X-Received: by 2002:a05:600c:314e:b0:47d:3ffa:9838 with SMTP id 5b1f17b1804b1-47ee32e142fmr1139285e9.1.1768329841453; Tue, 13 Jan 2026 10:44:01 -0800 (PST) Received: from skbuf ([2a02:2f04:d804:300:1d21:67b9:d397:6314]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f410c6csm435061025e9.1.2026.01.13.10.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 10:44:00 -0800 (PST) Date: Tue, 13 Jan 2026 20:43:57 +0200 From: Vladimir Oltean To: Thomas Gleixner Cc: Ioana Ciornei , Alexander Stein , Ulf Hansson , Geert Uytterhoeven , Johan Hovold , "Rafael J. Wysocki" , "Rob Herring (Arm)" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] irqchip: convert ls-extirq to a platform driver Message-ID: <20260113184357.xwtlnp6ya3ujrhn3@skbuf> References: <20251205155735.2366732-1-ioana.ciornei@nxp.com> <87y0m1iclb.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y0m1iclb.ffs@tglx> Hi Thomas, On Tue, Jan 13, 2026 at 07:36:48PM +0100, Thomas Gleixner wrote: > On Tue, Jan 13 2026 at 17:33, Vladimir Oltean wrote: > > On Fri, 5 Dec 2025 at 17:58, Ioana Ciornei wrote: > > > > I agree with Thomas' comments on patch 1 that the commit message is telling us > > the conclusion without telling us what the problem is. > > > > However, between this solution and Alexander's, this is clearly preferable, > > because it does not break device trees. > > I'm fine with that, though the extra cleanups Alexander did are nice... > > > I think this patch set has stalled possibly due to the holiday season, but my > > understanding that a v2 is due with an updated commit message and nothing else, > > correct? > > Yes. I've marked it "wait for update" and that's the state since > Dec. 5th. > > Thanks, > > tglx Thanks for the response. I've since looked at the code, and Alexander's cleanups are more than "nice", they are required, because when you convert a driver from IRQCHIP_DECLARE() to platform_driver, you introduce the possibility for it to be unbound from the device, and when you do that, the memory that ls_extirq_probe() has allocated needs to be freed. Ioana's patch doesn't do that; Alexander's does (although possibly unintended). I suspect the best parts of their approaches needs to be squashed into a single change and both authors credited (separate changes would mean introducing the memory leak just to fix it in the next patch). Ioana, Alexander, could you please start a discussion to see who can submit the follow up to this thread? Thanks! Vladimir