[PATCH v4 28/59] do_sys_openat2(): get rid of useless check, switch to CLASS(filename)

Al Viro
2026-01-08T07:36:54Z

do_file_open() will do the right thing when given ERR_PTR() as name...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
fs/open.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/fs/open.c b/fs/open.c
index 3d2e2a2554c5..ac8dedea8daf 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -1425,18 +1425,12 @@ static int do_sys_openat2(int dfd, const char __user *filename,
struct open_how *how)
{
struct open_flags op;
- struct filename *tmp __free(putname) = NULL;
- int err;
-
- err = build_open_flags(how, &op);
+ int err = build_open_flags(how, &op);
if (unlikely(err))
return err;

- tmp = getname(filename);
- if (IS_ERR(tmp))
- return PTR_ERR(tmp);
-
- return FD_ADD(how->flags, do_file_open(dfd, tmp, &op));
+ CLASS(filename, name)(filename);
+ return FD_ADD(how->flags, do_file_open(dfd, name, &op));
}

int do_sys_open(int dfd, const char __user *filename, int flags, umode_t mode)
--
2.47.3