From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Petre Rodan" <petre.rodan@subdimension.ro>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andreas Klinger" <ak@it-klinger.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/13] iio: pressure: mprls0025pa: fix interrupt flag
Date: Wed, 14 Jan 2026 12:14:48 +0000 [thread overview]
Message-ID: <20260114121448.00000249@huawei.com> (raw)
In-Reply-To: <aWdsTf5l5hyw1qr0@smile.fi.intel.com>
On Wed, 14 Jan 2026 12:13:33 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Jan 14, 2026 at 12:05:37PM +0200, Petre Rodan wrote:
> > Interrupt falling/rising flags should only be defined in the device tree.
>
> ...
>
> > if (data->irq > 0) {
> > ret = devm_request_irq(dev, data->irq, mpr_eoc_handler,
> > - IRQF_TRIGGER_RISING,
> > - dev_name(dev),
> > - data);
> > + IRQF_TRIGGER_NONE, dev_name(dev), data);
>
> No, this is still incorrect, should be plain 0 here.
Yeah. My mistake in agreeing with your reply in v1.
I'll randomly blame lack of coffee ;)
See the help text above IRQF_TRIGGER_NONE in interrupt.h which talks about not
specifying up at all (i.e. 0) meaning go with whatever is already there.
Jonathan
>
> > if (ret)
> > return dev_err_probe(dev, ret,
> > "request irq %d failed\n", data->irq);
>
next prev parent reply other threads:[~2026-01-14 12:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 10:05 [PATCH v2 00/13] iio: pressure: mprls0025pa: driver code cleanup Petre Rodan
2026-01-14 10:05 ` [PATCH v2 01/13] iio: pressure: mprls0025pa: fix spi_transfer struct initialisation Petre Rodan
2026-01-14 10:05 ` [PATCH v2 02/13] iio: pressure: mprls0025pa: fix SPI CS delay violation Petre Rodan
2026-01-14 10:05 ` [PATCH v2 03/13] iio: pressure: mprls0025pa: fix interrupt flag Petre Rodan
2026-01-14 10:13 ` Andy Shevchenko
2026-01-14 12:14 ` Jonathan Cameron [this message]
2026-01-14 10:05 ` [PATCH v2 04/13] iio: pressure: mprls0025pa: fix scan_type struct Petre Rodan
2026-01-14 10:05 ` [PATCH v2 05/13] iio: pressure: mprls0025pa: fix pressure calculation Petre Rodan
2026-01-14 10:14 ` Andy Shevchenko
2026-01-14 10:05 ` [PATCH v2 06/13] iio: pressure: mprls0025pa: cleanup includes Petre Rodan
2026-01-14 10:05 ` [PATCH v2 07/13] iio: pressure: mprls0025pa: remove redundant declarations Petre Rodan
2026-01-14 10:05 ` [PATCH v2 08/13] iio: pressure: mprls0025pa: rename buffer variable Petre Rodan
2026-01-14 10:05 ` [PATCH v2 09/13] iio: pressure: mprls0025pa: introduce tx buffer Petre Rodan
2026-01-14 10:05 ` [PATCH v2 10/13] iio: pressure: mprls0025pa: move memset to core Petre Rodan
2026-01-14 10:05 ` [PATCH v2 11/13] iio: pressure: mprls0025pa: stricter checks for the status byte Petre Rodan
2026-01-14 10:05 ` [PATCH v2 12/13] iio: pressure: mprls0025pa: change measurement sequence Petre Rodan
2026-01-14 10:20 ` Andy Shevchenko
2026-01-14 10:05 ` [PATCH v2 13/13] iio: pressure: mprls0025pa: add copyright line Petre Rodan
2026-01-14 12:21 ` [PATCH v2 00/13] iio: pressure: mprls0025pa: driver code cleanup Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114121448.00000249@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=ak@it-klinger.de \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox