From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90B6B355804 for ; Wed, 14 Jan 2026 05:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768368598; cv=none; b=abkRRPwcn/u21Taze7ORV+jH1IjhFFfHSlH9PzMN6f/BDOtlkP35c3DnU+ox4LvtIAAtFoA+9zKUjMgvb/LQYcl3h4wN9GjMkpfKAl6LCmRmlH++RZneEcKrSdVUsHVwVBTmgCKSQc9jVGeSqqZo+mwyyUi1dlwCK4CtQjC34qY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768368598; c=relaxed/simple; bh=2lmSTDfg+wQqdp/UdoPxHgrXvc40KPtMzRkQ989ksWk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mGZTAk+tXTV/zoHRWY47mGYWb91+D3WAVAmwEZ5JkwJ6shV/wlNQUjQJlDQrWOEPrQjVe8VxC60bS2Ze7jA4k3CdNRlwmU+CTlVJbY9d0MGJk/vadD7i6X03dxECoJeHsHkuLTXLVGyaBJYgm6oP/n1orb7rVsJsncEpIDysHrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au; spf=pass smtp.mailfrom=canb.auug.org.au; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b=Nsj6JSAk; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canb.auug.org.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="Nsj6JSAk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=202503; t=1768368588; bh=2eTIDJrpJmtO4I4yIQ6EAzCMXTtMUfaWhK+hTV1281U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Nsj6JSAkGNZamLnT0ARAq7ISm6a7Hlhjd4A2n8YS9H9AVivXPTR6k4SloPp+Uwl0m 4olmOVRIMgFyX8f4jOql59THnsSZr7txG8WGAt1tXmzZO9Cp4bjk4QNt0ngXv4IHQz ulEAtK+OxqOaDkbU7mtko//9P9Imrl8mQLN7IpTcw9U9PirbH7b5IUm7HHMaVLcbvv 1sUH1RI3RJr+BsWv8nS1Qc0xw8WZHRb2g1O9p53+FNNUG259AumsmBfwoFpP2R+tOo 6weBI3bYdCKr456mURxeLDqGO8vON6kk/FcAJ90Wkyc3zn95iZNox5wNvTlS+Pp2E+ 6juIsGKjKhH8Q== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4drZSC4qFzz4wGs; Wed, 14 Jan 2026 16:29:47 +1100 (AEDT) Date: Wed, 14 Jan 2026 16:29:46 +1100 From: Stephen Rothwell To: Andrew Morton Cc: Ian Rogers , Joe Perches , Kuan-Wei Chiu , Dwaipayan Ray , Lukas Bulwahn , Andy Whitcroft , linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator Message-ID: <20260114162946.4c81298e@canb.auug.org.au> In-Reply-To: <20260113193319.701e5799059eb642bbfc9a04@linux-foundation.org> References: <20251205053457.8556-1-irogers@google.com> <195a2cba2b461a0ab99ae004bdf079b038db8b07.camel@perches.com> <45e299a4c4326d46360955758df7d3df58613255.camel@perches.com> <20260113193319.701e5799059eb642bbfc9a04@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/F.OZJvHCZJ4/L_cSOuzwYrf"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/F.OZJvHCZJ4/L_cSOuzwYrf Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Andrew, On Tue, 13 Jan 2026 19:33:19 -0800 Andrew Morton wrote: > > git is wrong. I say so coz I invented the --- convention.=20 > submitting-patches.rst says >=20 > - A marker line containing simply ``---``. >=20 > The astonishingly old https://www.ozlabs.org/~akpm/stuff/tpp.txt says > "... scripts will treat a ^--- string as ...". I regret not > explicitly using "^---$". >=20 > I'd like checkpatch to emit a warning in this case. If a line starts > with --- then please let's warn the user that downstream tooling will > screw this up. =20 https://en.wikipedia.org/wiki/Signature_block#Standard_delimiter I have used dash-dash-space for as long as I can remember (which varies these days ;-) ). --=20 Cheers, Stephen Rothwell --Sig_/F.OZJvHCZJ4/L_cSOuzwYrf Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmlnKcoACgkQAVBC80lX 0GxOhAgAiqcGiSeCBLmNWh3muhdxC7G0M3YqjWhMveagD/R8XpeAb3ZovEhY3Yl/ NEMjX19cN5NykUsJkTXcSf7rubGbJr8oDZlE0p9U0M9XP5eTNzgigulY75AS9x7x F441D6IIiRuBg6TOHo/Kr6Ycohj5h70GGLSAUTjG1hrji0cvmcI+RcY0uvfxKj4w K4jUVGQTSJG+GRkq0//hd2u2iarJ3uKLfRuu9PgPK6Yo39xXqkw844Vwj4LgZewG zBCD6mB94nmaik00l9E5P7l7CHyPPNoSAQqKl8gsRRiwywgsv9EZ6CHx+7Sixq3b /6vLg5vP2RSHWTJ5bZ11JIekH5UWOQ== =LPyZ -----END PGP SIGNATURE----- --Sig_/F.OZJvHCZJ4/L_cSOuzwYrf--