From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4080F19E839 for ; Thu, 15 Jan 2026 00:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768437827; cv=none; b=JcfbV0qUctCmC7Dw8mU4Ww5i7OWdPfu0zYdWgad7F8qv1U1XGjaUWJbyviSlMd3PtliQdx42q4h30hu4rQD6bgJ4U4FrXJEJLstokNB7APfUAru0LnOc2VZSf9JK837TKCKDChb6A3PxUUHenu8gGpL7b76XwagGo/lRD72S+a4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768437827; c=relaxed/simple; bh=Uk2NSQPdfgTq0jMeR9dvSjO2NK7HoD4YahlyEpAv2ao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kfc6tGKMDhC+pUFEUor2KmbW32wuKUsWEsi08CrUViMQgKc1szM1D2S8p0M6e/pszttgG5puwXzOvl7NXUpgucJYoVrRE10eCTzc6rzfGXjiprEN30wdaGynKQZ9MBcKmElV1lARUtxuM5Fv/Z77ISKJBqx289WCsuZoVRNQpg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QPt0K3wK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=mhiTf6vj; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QPt0K3wK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="mhiTf6vj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768437825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k4eXF+yg0VGRJrpW2uvJQuHP3qJwRIyGLrzkDgdoUSU=; b=QPt0K3wKX6+yL1IFQ/OAp+6G32SC0pbD2muKsOVxJrhSvXgvbrJdnj4K8+zt/v2bzn8qa9 69LuY2N575SJ99EN0vgzf3SrLiYy+n9CfhLA8NasXISpvX7rrmGxhU0GDWfG/722n6Uoz6 qQT4uQz9c0LZdF+pUHN/GUQwO/XKSyw= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-j2SD4m0IPj6sED_UdYY19Q-1; Wed, 14 Jan 2026 19:43:44 -0500 X-MC-Unique: j2SD4m0IPj6sED_UdYY19Q-1 X-Mimecast-MFC-AGG-ID: j2SD4m0IPj6sED_UdYY19Q_1768437823 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-81d9b88caf2so249613b3a.1 for ; Wed, 14 Jan 2026 16:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768437823; x=1769042623; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k4eXF+yg0VGRJrpW2uvJQuHP3qJwRIyGLrzkDgdoUSU=; b=mhiTf6vjqntaPBUwGX/XrtXlkc0ZT6uyA98HQr9DeTbxumXUvDLZ2Q6jN065wIzU8k Gp85pamycz9BBLy1STkgl2k4bT/b/D6qTjeAH+Msr2OirNY5Dg0uoPvpY7CrcJPRsnvj W+XLnguwsOG05wqs0v87AVzQKfhMe1zUJXKDLkLAkpYARn+WR2pwbdVdDuPjA+d4zuKx 9A4DfIytj5eaDXGRBO4akXkFa5D6vJHkNnNCzA/JCSmx8xlQ5rtfgOHJha+3TCdqj/Ft zQbuaVq+GiU1W6VjLjDqEK4muXJvr6Mb/kXJOqPB8F0tLbaBuZau/e3uEP6+WBa0Fz+E Kdhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768437823; x=1769042623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=k4eXF+yg0VGRJrpW2uvJQuHP3qJwRIyGLrzkDgdoUSU=; b=qVBV+grOnI2dh+QD6PAX8ikKbcAc2tqfLcw8jmSiz8LfQE1rIbat8ReP4V35pXMkkJ E1KHHi5ENOTRBafb1mX3nwiOqzZTnj5mfVdW1BkA6CNJx358gA8zs9BkzY75RJoGAzSZ dT9RKNGpMQKl+NRZ95VANwKVaHI7XQBP1DL7exdZOF4a6LvKSw3yB5MAOdhQTG1hM9Mu GEWgydbfXdqcOASQbUw49qdhr36qyLNzwPai05x4pTA7jYNma6JkzP4qs1hPSAC2OpGF R4Spcn7Tpg6lkxGN7PbnEv9zQ2Xc9NYqLLcXpvIFFdL/QC8UytB9xKHl8RA1ZsH3SJyz fyBQ== X-Forwarded-Encrypted: i=1; AJvYcCWpW5gUTALmYn65mP89ge+Atbb0MfLZ5LezCWE+5GQ/+9TpRwrgO2sBzher51Supmv+OuI34kTpwDUj/fo=@vger.kernel.org X-Gm-Message-State: AOJu0YwZR+NmqQY1gXU2fb7QsiUxKrmnuqBgq9jrgqffHk6CmF8j92bh c+w+4DnEtG1+B4nPBXgnZMCBUmuO3Of+WeSUbfTlTloT4V6QUyktxgAXgn8Un2bN7g738JaDU/e vRVGy+jxRVsD9kVC6z9XKfvfZ+VWJpPfqU/GVFa2j0fuqXJR0asR3p/gjbzThUIluoA== X-Gm-Gg: AY/fxX7Mm4G7Ho1OMIkjwHOjnjddkbV1/b2sU9F73GFxyOicdsu1cFO104LOAydcY37 n9WrB2yI3iFJ0RXHkQmqQAfI2nHzLBDlZ2DDwzj5DPhMBjNeki2r9x2bOTDNIeH6IO4tU0LS2ZF W7xCMr9vAsq4WZv0gIDVB2FIW1nUjE2XkNaHZFP804Re0JHY4ZoLBe2FGGMYmQW+zUqtUnNOnut PUZqRqylaD1xY20GmpR0lPRwWFyOzqf6sYUUh63MdH3HmRq4kYQG2z6tvdCEGGkAkLEvZ9qhmg5 yShpkImUgcWd9mMIiF0sy2ni8M3OowPjqguc1Au8vj4k3uv6bh+//4+L1ZsAD8cAtaF1B+XdKJx i X-Received: by 2002:a05:6a00:4196:b0:81f:4abd:f15b with SMTP id d2e1a72fcca58-81f8200640amr3916152b3a.58.1768437822985; Wed, 14 Jan 2026 16:43:42 -0800 (PST) X-Received: by 2002:a05:6a00:4196:b0:81f:4abd:f15b with SMTP id d2e1a72fcca58-81f8200640amr3916117b3a.58.1768437822405; Wed, 14 Jan 2026 16:43:42 -0800 (PST) Received: from localhost ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f8e4b6ca9sm692388b3a.4.2026.01.14.16.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 16:43:42 -0800 (PST) From: Coiby Xu To: linux-integrity@vger.kernel.org Cc: Heiko Carstens , Mimi Zohar , Roberto Sassu , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , linux-security-module@vger.kernel.org (open list:SECURITY SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] evm: Don't enable fix mode when secure boot is enabled Date: Thu, 15 Jan 2026 08:43:24 +0800 Message-ID: <20260115004328.194142-3-coxu@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115004328.194142-1-coxu@redhat.com> References: <20260115004328.194142-1-coxu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Similar to IMA fix mode, forbid EVM fix mode when secure boot is enabled. Reported-and-suggested-by: Mimi Zohar Suggested-by: Roberto Sassu Signed-off-by: Coiby Xu --- security/integrity/evm/evm_main.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c index 73d500a375cb..00bba266231d 100644 --- a/security/integrity/evm/evm_main.c +++ b/security/integrity/evm/evm_main.c @@ -72,17 +72,25 @@ static struct xattr_list evm_config_default_xattrnames[] = { LIST_HEAD(evm_config_xattrnames); +static char *evm_cmdline __initdata; +core_param(evm, evm_cmdline, charp, 0); + static int evm_fixmode __ro_after_init; -static int __init evm_set_fixmode(char *str) +static void __init evm_set_fixmode(void) { - if (strncmp(str, "fix", 3) == 0) - evm_fixmode = 1; - else - pr_err("invalid \"%s\" mode", str); + if (!evm_cmdline) + return; - return 1; + if (strncmp(evm_cmdline, "fix", 3) == 0) { + if (arch_integrity_get_secureboot()) { + pr_info("Secure boot enabled: ignoring evm=fix"); + return; + } + evm_fixmode = 1; + } else { + pr_err("invalid \"%s\" mode", evm_cmdline); + } } -__setup("evm=", evm_set_fixmode); static void __init evm_init_config(void) { @@ -1119,6 +1127,8 @@ static int __init init_evm(void) evm_init_config(); + evm_set_fixmode(); + error = integrity_init_keyring(INTEGRITY_KEYRING_EVM); if (error) goto error; -- 2.52.0