From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11DFD2C15B8 for ; Thu, 15 Jan 2026 09:33:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469588; cv=none; b=NN62sA3tDY+Ika2a5zJSk1nkwJnptnbojGLcL0zrG0MhRkTzDMXCOcM5gLbQ8j6Dptccn5ykko3vMklZuuW08cMUZW1994bQvLB2eroanp/xt2P1FvIXiCHDQRa31L4nWSYSZrUrNkvroCbDcYaT8uyDkiFOFjL3ybcsLWG0egg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469588; c=relaxed/simple; bh=5S/eCr84IqvxFoOtD38rMw+D2s1EBwWgY6WhDrkn7+Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RMNnvOCw7a7fV01eGMLKQJPQ9w4+RcQN8kI7ImtZIITxlfixL1GKDX4FgpzJeKDRags51khT0nx5/fzH83UbKRPc1QVZWI6aGRWyUlPGx9AtL2vBilU7/6UlmnXjhcNm4/8sydDRmAPI4L5UQ9aJ79opu5NFE4MebD6f8zAjZDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gSV3IiK2; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AWiH1aLF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gSV3IiK2"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AWiH1aLF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768469586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E3+emnN/FUkaljXR8TzqIDHk76UR0X2pbJSmye/ZyuY=; b=gSV3IiK2NPwSJeXUSu3Q7nbfyUJNem6KtptfMSHBSOfeKfX9v/NqX3jVpKVzcmgbzJJNAF tE9nJpxDhsBlOHpUxEXUbYjaq3IOrXmSx+boFn/HM+iWrbOS+XaiZn7RIWaSQkfPlM7tuB b83GglLGXvVxSVocTbTGQZorC0TdANw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-N6X8sfKHMrGbRxmUO_1YJg-1; Thu, 15 Jan 2026 04:33:04 -0500 X-MC-Unique: N6X8sfKHMrGbRxmUO_1YJg-1 X-Mimecast-MFC-AGG-ID: N6X8sfKHMrGbRxmUO_1YJg_1768469583 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47ee056e5cfso4418495e9.1 for ; Thu, 15 Jan 2026 01:33:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768469583; x=1769074383; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=E3+emnN/FUkaljXR8TzqIDHk76UR0X2pbJSmye/ZyuY=; b=AWiH1aLFyzFT3ErQALbzAZ07BS7VdeyjOHXJIKRWk3FG1pmY8guJOf31OTjhgHMvip mOr2e3+9qnMWwLGf3lgt5FTe7pDmAhJYagvn0k7r0UvulpC0kv9aop0dgNIukrC8lGq3 P3BulUasV7cByPZO35WFulJZQmeBj1UIEQhs3zTj9sSeHlrNR5GIJiei2cbY9uOnDKZX GncXWpQNHk6i4N4y0hGCsWTeVNcw/qyjD5H+sepJ58bCX/CGiKdlVyU++3DFwzt7zkBg S3dRTKo/MfzL3vHD7QtZ1E+aKZfu99BO6bRkcsVlmFZ8zOTaqOUXGNc5IXVkd1s3CL8h Lc4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768469583; x=1769074383; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E3+emnN/FUkaljXR8TzqIDHk76UR0X2pbJSmye/ZyuY=; b=QVr25yKK2M5rSpNP1Z/m8JWrV7QChad0zx01qXPJTx4JGzTP0JKxVv4UInO5vjQWpL BtIOL9zDu6m3UFqSIl/NaiAUUuhYFb4eYseZB15WX0T+HFRtPYlvbWydG6DCkkiCkJM9 M+sZNQmDoZpjciSCLI2ivyqftiko0QuDg5brP6sErafRNwIGK9i4P/XAoSGK6fc4FSm0 ijtqbv0OVUAxKtspXzpX7C1N48/ilDuPfgrvXa5AnY88GTORIRVP8xXoPx1qsHaPv+ma uurVrrpFgp2ucyO0nIHDjdhbcrV+iGr+ihCP0BCeKkcvbXmx5ufJ17Gcqz/2r+rfOjau 02og== X-Gm-Message-State: AOJu0Yyg0ndqLAgjkob2XkeFB7LoXSlbFc7Gcsk7kv8Bv0hK3t+R2XCW 6jhJ0SXLyVy4HJeAQbYiDZ610MZl7tZ464yceIT0fU5Rl0pp+bC+4Uclp/sfBpPi2kt53CzwL/b Ap0BP00RceVkF/8cRFSVRg9f9KHeTtvZTzDkCwMVs++r/KMj5WU8csg+NMqLFwdh/7Q== X-Gm-Gg: AY/fxX5gy6MC3Ca2BLpgC8HnTC9TY8Klgo60lg+HJDAE9Q6qZGD1NPqNJGa25Is6ZW4 rtlnffubE41nFCeyxqMXlrS6qbh/ao49uVEDyUvgoohjNqFyfVrPLC3x0sxz9mtXKukqHGEdVIn 8gbYinHxGKOo7WmVJU9beWxPE/BqlY5k3Fg1fPg2X6gQmSf9W0eDE8ga70Xz7pLfuK6YlH2hbWl Bd4siASr8OLx4IWDCic3KvsKhsm+YtDrczxlckLvQWmgMTvOGoAFPpXO4fijjCRc5Z65RR7yh/0 HU5IQp69/On+TAgicC4RMPlNki1IrpfsM++pVx2tBgWosw2nR7gV6fBbk1QDGq4mj8sAFa1nq0o XifuitFBrTFz9X1OB/q85xI/c2HNJzQ== X-Received: by 2002:a05:600c:6610:b0:477:b642:9dc9 with SMTP id 5b1f17b1804b1-47ee48271b8mr47954245e9.28.1768469583323; Thu, 15 Jan 2026 01:33:03 -0800 (PST) X-Received: by 2002:a05:600c:6610:b0:477:b642:9dc9 with SMTP id 5b1f17b1804b1-47ee48271b8mr47953965e9.28.1768469582848; Thu, 15 Jan 2026 01:33:02 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee97b2bebsm19745355e9.18.2026.01.15.01.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 01:33:02 -0800 (PST) Date: Thu, 15 Jan 2026 04:32:58 -0500 From: "Michael S. Tsirkin" To: "David Hildenbrand (Red Hat)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Broadcom internal kernel review list , linux-doc@vger.kernel.org, virtualization@lists.linux.dev, Andrew Morton , Oscar Salvador , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Arnd Bergmann , Greg Kroah-Hartman , Jerrin Shaji George , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Zi Yan Subject: Re: [PATCH v2 00/23] mm: balloon infrastructure cleanups Message-ID: <20260115043240-mutt-send-email-mst@kernel.org> References: <20260115092015.3928975-1-david@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260115092015.3928975-1-david@kernel.org> On Thu, Jan 15, 2026 at 10:19:50AM +0100, David Hildenbrand (Red Hat) wrote: > I started with wanting to remove the dependency of the balloon > infrastructure on the page lock, but ended up performing various other > cleanups, some of which I had on my todo list for years. > > This series heavily cleans up and simplifies our balloon infrastructure, > including our balloon page migration functionality. > > With this series, we no longer make use of the page lock for PageOffline > pages as part of the balloon infrastructure (preparing for memdescs > where PageOffline pages won't have any such lock), and simplifies > migration handling such that refcounting can more easily be adjusted > later (long-term focus is for PageOffline pages to not have a refcount > either). > > Plenty of related cleanups. > > Heavily compile-tested and heavily runtime-tested with virtio-balloon. > PPC CMM and the VMware balloon are untested and I'd appreciate a helping > hand from people that have suitable environments. > > Not CCing maintainers for the vmscan.c and migrate.c change as they > are rather trivial and I don't want to patchbomb them. besides MAINTAINERS thing: Acked-by: Michael S. Tsirkin > -- > > This is based on mm/mm-unstable. > > v1 -> v2: > * Rebased to latest mm/mm-unstable without any conflicts > * Minor patch description/subject and comment fixups > * Retested > > Cc: Andrew Morton > Cc: Oscar Salvador > Cc: Lorenzo Stoakes > Cc: "Liam R. Howlett" > Cc: Vlastimil Babka > Cc: Mike Rapoport > Cc: Suren Baghdasaryan > Cc: Michal Hocko > Cc: Jonathan Corbet > Cc: Madhavan Srinivasan > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: Jerrin Shaji George > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Xuan Zhuo > Cc: "Eugenio Pérez" > Cc: Zi Yan > > David Hildenbrand (Red Hat) (23): > vmw_balloon: adjust BALLOON_DEFLATE when deflating while migrating > vmw_balloon: remove vmballoon_compaction_init() > powerpc/pseries/cmm: remove cmm_balloon_compaction_init() > mm/balloon_compaction: centralize basic page migration handling > mm/balloon_compaction: centralize adjust_managed_page_count() handling > vmw_balloon: stop using the balloon_dev_info lock > mm/balloon_compaction: use a device-independent balloon (list) lock > mm/balloon_compaction: remove dependency on page lock > mm/balloon_compaction: make balloon_mops static > mm/balloon_compaction: drop fs.h include from balloon_compaction.h > drivers/virtio/virtio_balloon: stop using balloon_page_push/pop() > mm/balloon_compaction: remove balloon_page_push/pop() > mm/balloon_compaction: fold balloon_mapping_gfp_mask() into > balloon_page_alloc() > mm/balloon_compaction: move internal helpers to balloon_compaction.c > mm/balloon_compaction: assert that the balloon_pages_lock is held > mm/balloon_compaction: mark remaining functions for having proper > kerneldoc > mm/balloon_compaction: remove "extern" from functions > mm/vmscan: drop inclusion of balloon_compaction.h > mm: rename balloon_compaction.(c|h) to balloon.(c|h) > mm/kconfig: make BALLOON_COMPACTION depend on MIGRATION > mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION > mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOON > MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT > - BALLOON" > > .../admin-guide/mm/memory-hotplug.rst | 8 +- > Documentation/core-api/mm-api.rst | 2 +- > MAINTAINERS | 12 +- > arch/powerpc/platforms/pseries/Kconfig | 2 +- > arch/powerpc/platforms/pseries/cmm.c | 53 +---- > drivers/misc/Kconfig | 2 +- > drivers/misc/vmw_balloon.c | 105 +++------- > drivers/virtio/Kconfig | 2 +- > drivers/virtio/virtio_balloon.c | 64 ++---- > include/linux/balloon.h | 77 +++++++ > include/linux/balloon_compaction.h | 160 --------------- > include/linux/vm_event_item.h | 8 +- > mm/Kconfig | 23 +-- > mm/Makefile | 2 +- > mm/{balloon_compaction.c => balloon.c} | 194 +++++++++++++----- > mm/memory_hotplug.c | 4 +- > mm/migrate.c | 2 +- > mm/vmscan.c | 1 - > mm/vmstat.c | 8 +- > 19 files changed, 314 insertions(+), 415 deletions(-) > create mode 100644 include/linux/balloon.h > delete mode 100644 include/linux/balloon_compaction.h > rename mm/{balloon_compaction.c => balloon.c} (59%) > > > base-commit: f8ed52ac0cfbddff992bb9600941bfe51e1e385a > -- > 2.52.0