From: Christoph Hellwig <hch@lst.de>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, hch@lst.de,
tytso@mit.edu, willy@infradead.org, jack@suse.cz,
djwong@kernel.org, josef@toxicpanda.com, sandeen@sandeen.net,
rgoldwyn@suse.com, xiang@kernel.org, dsterba@suse.com,
pali@kernel.org, ebiggers@kernel.org, neil@brown.name,
amir73il@gmail.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, iamjoonsoo.kim@lge.com,
cheol.lee@lge.com, jay.sim@lge.com, gunho.lee@lge.com,
Hyunchul Lee <hyc.lee@gmail.com>
Subject: Re: [PATCH v5 09/14] ntfs: update runlist handling and cluster allocator
Date: Fri, 16 Jan 2026 10:21:38 +0100 [thread overview]
Message-ID: <20260116092138.GA21396@lst.de> (raw)
In-Reply-To: <20260111140345.3866-10-linkinjeon@kernel.org>
> + for (index = start_index; index < end_index; index++) {
> + folio = filemap_lock_folio(vol->lcnbmp_ino->i_mapping, index);
> + if (IS_ERR(folio)) {
> + page_cache_sync_readahead(vol->lcnbmp_ino->i_mapping, ra, NULL,
You probably only want to kick off a read for -ENOENT here, and not
any error?
> + index, end_index - index);
> + folio = read_mapping_folio(vol->lcnbmp_ino->i_mapping, index, NULL);
> + if (!IS_ERR(folio))
> + folio_lock(folio);
> + }
either way, this seems like a nice primitive for doing reasonably
efficient reads from the page cache, and I could think of a few
other places to it. Maybe factor it into helper, even if you keep
it in the ntfs code for now?
next prev parent reply other threads:[~2026-01-16 9:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 14:03 [PATCH v5 00/14] ntfs filesystem remake Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 01/14] Revert "fs: Remove NTFS classic" Namjae Jeon
2026-01-16 8:00 ` Christoph Hellwig
2026-01-11 14:03 ` [PATCH v5 02/14] ntfs: update in-memory, on-disk structures and headers Namjae Jeon
2026-01-16 8:23 ` Christoph Hellwig
2026-01-18 4:54 ` Namjae Jeon
2026-01-19 7:05 ` Christoph Hellwig
2026-01-20 4:27 ` Namjae Jeon
2026-01-20 6:40 ` Christoph Hellwig
2026-01-20 7:03 ` Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 03/14] ntfs: update super block operations Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 04/14] ntfs: update inode operations Namjae Jeon
2026-01-16 8:30 ` Christoph Hellwig
2026-01-18 4:54 ` Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 05/14] ntfs: update directory operations Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 06/14] ntfs: update file operations Namjae Jeon
2026-01-16 8:53 ` Christoph Hellwig
2026-01-18 4:56 ` Namjae Jeon
2026-01-19 7:10 ` Christoph Hellwig
2026-01-20 5:11 ` Namjae Jeon
2026-01-20 6:42 ` Christoph Hellwig
2026-01-20 7:02 ` Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 07/14] ntfs: update iomap and address space operations Namjae Jeon
2026-01-16 9:14 ` Christoph Hellwig
2026-01-18 5:00 ` Namjae Jeon
2026-01-19 7:17 ` Christoph Hellwig
2026-01-20 4:28 ` Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 08/14] ntfs: update attrib operations Namjae Jeon
2026-01-16 9:18 ` Christoph Hellwig
2026-01-18 5:00 ` Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 09/14] ntfs: update runlist handling and cluster allocator Namjae Jeon
2026-01-16 9:21 ` Christoph Hellwig [this message]
2026-01-18 5:00 ` Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 10/14] ntfs: add reparse and ea operations Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 11/14] ntfs: update misc operations Namjae Jeon
2026-01-16 9:28 ` Christoph Hellwig
2026-01-18 5:00 ` Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 12/14] ntfs3: remove legacy ntfs driver support Namjae Jeon
2026-01-16 9:28 ` Christoph Hellwig
2026-01-11 14:03 ` [PATCH v5 13/14] ntfs: add Kconfig and Makefile Namjae Jeon
2026-01-16 9:30 ` Christoph Hellwig
2026-01-18 5:08 ` Namjae Jeon
2026-01-19 7:19 ` Christoph Hellwig
2026-01-20 4:27 ` Namjae Jeon
2026-01-11 14:03 ` [PATCH v5 14/14] MAINTAINERS: update ntfs filesystem entry Namjae Jeon
2026-01-16 9:30 ` Christoph Hellwig
2026-01-16 9:33 ` [PATCH v5 00/14] ntfs filesystem remake Christoph Hellwig
2026-01-18 5:19 ` Namjae Jeon
2026-01-19 7:02 ` Christoph Hellwig
2026-01-20 4:26 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116092138.GA21396@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=cheol.lee@lge.com \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=ebiggers@kernel.org \
--cc=gunho.lee@lge.com \
--cc=hyc.lee@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jack@suse.cz \
--cc=jay.sim@lge.com \
--cc=josef@toxicpanda.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=pali@kernel.org \
--cc=rgoldwyn@suse.com \
--cc=sandeen@sandeen.net \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox