From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE98A219A8D for ; Fri, 16 Jan 2026 12:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.153.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768567424; cv=none; b=nQ7b2pOgbvZZ2c7DApaAGKNgntT/2MJ6Z/3nqM3JIPTJ4fF8XbHB4LKKadJwnEMC80XsiBAILoyxY0pK0g5ODn9+C2PmHX2XbXURGEsFYq5jki8IUQUVbH8/vnK9NtD0It6QF+kIl0hQjQzYRwQSyFJlOg5Zh0dH69/yKsB937Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768567424; c=relaxed/simple; bh=qQSqSV3dpyEpnVQocpQUCgXUEh2InLoYB4lbSqMhfMs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e4vkhH6cOIPTbE74hSumiPkTFPZZuUXSn3l4XeMGUJi5hvC9iGztoQ+o+EjnMMpleWJ1YTIO+e6EeVhrOX6K6RIyvtL80WncaoBE0C2V0/SxutgPyoEYpslxx8Eyy1zfplZlaHwkbs00Aa7hIct/VRmANBKB3ZtHMtY2kinXAZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meta.com; spf=pass smtp.mailfrom=meta.com; dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com header.b=EfwuKXIZ; arc=none smtp.client-ip=67.231.153.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meta.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=meta.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com header.b="EfwuKXIZ" Received: from pps.filterd (m0109331.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60G1PXl22441486; Fri, 16 Jan 2026 04:43:11 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=s2048-2025-q2; bh=fSYZH1ozqbZTBotT0opude6YNp7FdNOb+qhc2h9/BWQ=; b=EfwuKXIZEm0H 5Ntrh+1Xc1i6lxLZN4iR3XsEI/EYuU9Dfvg8XLRWSz4kdmwm5mj953bG9lUYl3Ga H94unUIbTLz/Uq60b58AQ14nLBtBC6YR+M92OH3FMlH3+NJ036Nu72kB1heMyJfl n9/N8ui8CI27oBurMjp/E13Hea75TIGVcQ7l4E0MCn0To0S0w1RHGnsWiHecQsnK f+D6OW3MFxCpOE71cTPoXH5LLkt9eg7Onl90Op0Fupxup1cZa8YL8sLDp/OQw2qE Nauo1HUJn1dItlUVZlzfo8su7Ome4EHrJnufYSngyOcFTQpf1wie7xxmcgN3BRlk COxb8bOmBQ== Received: from mail.thefacebook.com ([163.114.134.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 4bq974ck7c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 16 Jan 2026 04:43:11 -0800 (PST) Received: from devbig003.atn7.facebook.com (2620:10d:c085:208::7cb7) by mail.thefacebook.com (2620:10d:c08b:78::2ac9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Fri, 16 Jan 2026 12:43:10 +0000 From: Chris Mason To: Vladimir Kondratiev CC: Chris Mason , Thomas Gleixner , Xu Lu , Subject: Re: [PATCH] irqchip/aslint-sswi: request IO memory resource Date: Fri, 16 Jan 2026 04:42:49 -0800 Message-ID: <20260116124257.78357-1-clm@meta.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251209142336.1061606-1-vladimir.kondratiev@mobileye.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: ixGnJ5Zu8bMbeUpddptYrhh5v0OZIwq_ X-Authority-Analysis: v=2.4 cv=Lb8xKzfi c=1 sm=1 tr=0 ts=696a325f cx=c_pps a=CB4LiSf2rd0gKozIdrpkBw==:117 a=CB4LiSf2rd0gKozIdrpkBw==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=JvO64EORAAAA:8 a=bea1HBjLksDbNAaNjncA:9 a=Qz6KxWHdQ2_aS5WpiCfK:22 X-Proofpoint-ORIG-GUID: ixGnJ5Zu8bMbeUpddptYrhh5v0OZIwq_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE2MDA4OCBTYWx0ZWRfXxboWkLNP7+XW MlCJItGqxld7t/avR+cfVEX91EsiXgYXGMSnmfjbtheW7T7oH9iuTbmamuwUY5xfcr7qvfnW6vo gbBjY6Ijm1L44PcAEIH/UiimhD69MlA9zKxPtV04LZs8/WuNfXGBxjywoBH5lRMwJZS17rwEHBF JilEbjioTBAnStyaLXUMukuJaLmx4ydDmJVUZccmMP7AyC9RvXxJXgDCEYb3Cfr3i0lLg8OCYXF ocPOF9xutCH74Ako6D9RdK+J+It8gwYn0DaWml4lJhVKcveTzt85nYqf1hXot6wNrQ0OvgNkYw6 +VBov0YPak6Vl8UvAICobhEvASxBVM4sHtt4AiEmY/DdSEwEVSYduaTwj9XaDx5dTvt2kUt3vVi xRpXQp4PmUebIWuwMEBPmwKodYgWheG4ILt9/7qGsTRvRYCNk/sSyDiKkjZ3cKNXOLPAXurdX4F vOitguZr2smOvytLjdw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_05,2026-01-15_02,2025-10-01_01 On Tue, 9 Dec 2025 16:23:33 +0200 Vladimir Kondratiev wrote: > Make an aclint_sswi instance visible in the resource list, > i.e. /proc/iomem > Hi everyone, I ran tip master through my AI review prompts, and this one was flagged. This is a lot of words for NULL vs ERR_PTR, but it looks right to me: > diff --git a/drivers/irqchip/irq-aclint-sswi.c b/drivers/irqchip/irq-aclint-sswi.c > index fee30f3bc5ac2..325501f34a9bc 100644 > --- a/drivers/irqchip/irq-aclint-sswi.c > +++ b/drivers/irqchip/irq-aclint-sswi.c > @@ -109,7 +109,7 @@ static int __init aclint_sswi_probe(struct fwnode_handle *fwnode) > if (!is_of_node(fwnode)) > return -EINVAL; > > - reg = of_iomap(to_of_node(fwnode), 0); > + reg = of_io_request_and_map(to_of_node(fwnode), 0, NULL); > if (!reg) > return -ENOMEM; Should this error check be updated? of_iomap() returns NULL on failure, but of_io_request_and_map() returns IOMEM_ERR_PTR() on failure which is non-NULL. When of_io_request_and_map() fails, the condition (!reg) will be false and the function continues with an invalid ERR_PTR value. This gets passed to aclint_sswi_parse_irq() which stores (reg + offset) into per_cpu sswi_cpu_regs, leading to a crash when IPIs are later sent. Other callers of of_io_request_and_map() in drivers/irqchip/ use IS_ERR() for the error check. For example, sun6i_r_intc_init() in irq-sun6i-r.c: base = of_io_request_and_map(node, 0, NULL); if (IS_ERR(base)) { pr_err("%pOF: Failed to map MMIO region\n", node); return PTR_ERR(base); }