From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33D84A92E; Fri, 16 Jan 2026 19:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768590123; cv=none; b=KZRNvGWDQ38OcpIRlhckfl5gJzh3ztz3+9yX+UIdOiPA4q2z7JzsyEFPndGiI5WRoWd+yMXs7/J3V8OBuRWD1u2e2FiSO6T3TRRkXnbOZvKDrBVJFLxKTIMnfne0Wh+iHi3k5OpymA3rRMBIcLwH5gVRwxBqw4AJMSpFGYF8wqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768590123; c=relaxed/simple; bh=Z7pn9hHPvIKBxiWZ46T+k8jygbiSiwg2YvyDSdtlcjg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=p6mjlcRv9Pqqe2KN/dpEgJagQaT2+DL/D8WX3+uJQzdGaQlAzOufe53JAY5nZaVSkgj6v+Uq/vY3+Br9/vaTAXwTj3J5YZSVDaQeWek6RBigvZS1SSVmOOjPQtTk3m88ZtdsohjjpePaWU5I7sP/4WpDe8tW3eAJuFu9+BIbwiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t03XsJU8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t03XsJU8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FF48C116C6; Fri, 16 Jan 2026 19:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768590122; bh=Z7pn9hHPvIKBxiWZ46T+k8jygbiSiwg2YvyDSdtlcjg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t03XsJU80zF0hllmo4AkN7s/el+rYBNqttwxAgQW9DgNoDCbQId7i2WzjE7eOQoCf ih15/bWPkB7aR7nuURO9aNFTWcM5fQROk06QOrFAKsPetPUpPc5gLYpkkpKl0o3a5N iqGUsca5Q8ZvTTKSsM+mVQQNmjypB9sDRlMKY5C3RPhVj5O6IyquYMOZuDonw0mJqA sq4saii3rqPkDVB+ADR3DC+aJ4neTwBlvjBMVjBnKDj8Cd5JVDTPKL+x77NigS8sYm PWK9ZW7xU08Y6301pIZFXtxPbmiGrSjWZAAemyn0H4rZxCa3GRKFsx7swYjgKZ9S6w +odVNY5lcF9hw== Date: Fri, 16 Jan 2026 19:01:53 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Petre Rodan , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Andreas Klinger , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Marcelo Schmitt Subject: Re: [PATCH v3 00/13] iio: pressure: mprls0025pa: driver code cleanup Message-ID: <20260116190153.082b9cc0@jic23-huawei> In-Reply-To: References: <20260114-mprls_cleanup-v3-0-bc7f1c2957c2@subdimension.ro> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 14 Jan 2026 19:09:20 +0200 Andy Shevchenko wrote: > On Wed, Jan 14, 2026 at 06:55:29PM +0200, Petre Rodan wrote: > > This series contains a collection of patches to the MPR sensor based > > on feedback I received for other drivers. > > > > major changes: > > - trigger flag fix (define edge direction only in the device tree) > > - fix SPI timing violation > > - fix scan_type struct > > - fix pressure calculation > > (does not affect users that define a sensor via the pressure-triplet) > > - stricter check for the status byte + better error return levels > > - drop the use of devm_kzalloc() > > - stick to the datasheet parameters while performing the measurement > > sequence > > > > minor changes: > > - includes added and removed > > - rename generic 'buffer' variable to 'rx_buf' > > > > Tested on two sensors - MPRLS0015PA0000SA and MPRLS0001BA00001A > > This version looks good to me, > Reviewed-by: Andy Shevchenko > > The change I mentioned can be sent as a followup. > Applied to the togreg branch of iio.git. (I wrote this earlier but apparently didn't hit send for some reason)