From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FEF01E0E08 for ; Fri, 16 Jan 2026 07:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768548912; cv=none; b=A8jlvoPazy+iMJ9vSdZ8pnkDvs9SK4yzdDu63MT40yHpxSQYrKg7q3C0Q7lHUqAswv4cckap/V2TD0jNnXpKsWYuiTEbC6dtr5ChEKpmpSoLbCXe0AdNGZXK31cjZV9MXJE9JNQD3EbsqxzPCOdAsnPRSajv47cApPdlASLtHaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768548912; c=relaxed/simple; bh=KlEftqiHOFUguXlCVyPXX3/WLKxjAhneI2i8/WF2Sbs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Sd87wpiG/8bozBT9iVA1xzYKBujRi4yo4DpH+KZvQ2rsCb8MKWiafdyIC8SWTZxjC3Jwh73ff8grvwopHnOOIicuaiC4Ce7ypct5aQZmNeTR4x33SoD5CxN62rk7bLlYoZXcthXIIEMWbp8Sr8DLB64VIMy3kgzQUlqLnwHMa18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EKyaCjWS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EKyaCjWS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51292C116C6; Fri, 16 Jan 2026 07:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768548911; bh=KlEftqiHOFUguXlCVyPXX3/WLKxjAhneI2i8/WF2Sbs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EKyaCjWSM5Mk9Vg+dKkdoCTQH4bgECtNsmY0IeKMmdKCT/QQrYH8oqCKWsFy9dlGz 54JaABvjnGHHCbbkL3CFjlHXZmI7JY4d/19oOSvRUs4nzZ/+NjUvhiWLzcj1SNWvAB ANITnIXumzInbHj9euvN96YhFzS+HMRAQ/9j3Yk0= Date: Fri, 16 Jan 2026 08:35:06 +0100 From: Greg Kroah-Hartman To: Dominik Karol =?utf-8?Q?Pi=C4=85tkowski?= Cc: Dave Penkler , Michael Rubin , Dan Carpenter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/12] gpib: agilent_82350b: Unify *allocate_private Message-ID: <2026011646-catalyst-unsigned-24af@gregkh> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> <20260115191925.52268-2-dominik.karol.piatkowski@protonmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260115191925.52268-2-dominik.karol.piatkowski@protonmail.com> On Thu, Jan 15, 2026 at 07:20:04PM +0000, Dominik Karol Piątkowski wrote: > Return values for *allocate_private functions as well as calling code in > gpib driver are all over the place. Unify them by returning -errno if > something fails, zero otherwise. Use the returned value as early return > value in case of error. Replace kmalloc/memset pairs to kzalloc. Wait, there is no kzalloc change here. You used the same changelog for all of these patches :(