From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F25625485A for ; Fri, 16 Jan 2026 07:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768549001; cv=none; b=PELDkyrO/2g5zb6opX8So3TgjxW51l8CnVc1e2GH0LKS+ST6JrPPIl6DjaCVM+qsdCSE/dmkJiWsWvHZPh2aWAAu62rr2jHvnuX/wb2EsloAsPsTp//8DVDqf3U65bZgFb2OTQTDiedgseo6O21xhLAyZIr+IIkbvWna/SiJaAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768549001; c=relaxed/simple; bh=JTDtbnI/xZnIL3/iOicxdki7qyVOfaI+uuGNoaEcZog=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gfzp4tn7RLDWTkINhEfsAciJz/Nve59IaiO/1zPQzP1cxi48jfYp34ZcIIQDb66qlLj8yLjLnPa4MFCb4Somiv2m4L2rgOAU42YLEfQAijEtMkcE+zOry8e0ooaUPUq8CNolqNQtgV9P1cfYcRmfEOk65+1DOWFH2Q72Oy35lME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TtEuGJ89; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TtEuGJ89" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C115C116C6; Fri, 16 Jan 2026 07:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768549000; bh=JTDtbnI/xZnIL3/iOicxdki7qyVOfaI+uuGNoaEcZog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TtEuGJ89VGZO4qOPejx1nFsiM3fe4CjTj3dKAdMarRSZXh+raErQF7mf8N8e5wbK4 1BZckDNC8ngBGO/OcOOoS/BMqH6a989XCdUQx0TkTow2Jc8q1A0pkUCqAounFcSQsF SkQNPgVPECV/95fRLo7BHW5OOTi8ZGBm5wnLKIn4= Date: Fri, 16 Jan 2026 08:36:36 +0100 From: Greg Kroah-Hartman To: Dominik Karol =?utf-8?Q?Pi=C4=85tkowski?= Cc: Dave Penkler , Michael Rubin , Dan Carpenter , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/9] gpib: agilent_82350b: Unify *allocate_private Message-ID: <2026011649-glitter-unawake-3f50@gregkh> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> <20260113190759.54355-2-dominik.karol.piatkowski@protonmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260113190759.54355-2-dominik.karol.piatkowski@protonmail.com> On Tue, Jan 13, 2026 at 07:08:43PM +0000, Dominik Karol Piątkowski wrote: > Return values for *allocate_private functions as well as calling code in > gpib driver are all over the place. Unify them by returning -errno if > something fails, zero otherwise. Use the returned value as early return > value in case of error. > > Signed-off-by: Dominik Karol Piątkowski > --- > drivers/gpib/agilent_82350b/agilent_82350b.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpib/agilent_82350b/agilent_82350b.c b/drivers/gpib/agilent_82350b/agilent_82350b.c > index 01a5bb43cd2d..f5f102863e47 100644 > --- a/drivers/gpib/agilent_82350b/agilent_82350b.c > +++ b/drivers/gpib/agilent_82350b/agilent_82350b.c > @@ -599,8 +599,9 @@ static int agilent_82350b_generic_attach(struct gpib_board *board, > > board->status = 0; > > - if (agilent_82350b_allocate_private(board)) > - return -ENOMEM; > + retval = agilent_82350b_allocate_private(board); > + if (retval < 0) > + return retval; This should be: if (retval) return retval; right? And the function only returns either 0 or -ENOMEM, so your changelog text is not correct. thanks, greg k-h