From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56E1D286D64 for ; Fri, 16 Jan 2026 07:34:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768548874; cv=none; b=d9Wfmp/M37YxjCebBrLROqWl10ofawySHP277Q8t1L+JAoWoO+1h+uaD5rQgRkgbfBAWJ/9th9l1jwHp9jjkaq6Q5DTuG68mPl6jGYridrVKfWr74Lv94up6uIHPHjBePN8Pv0DGoFqfps6c0QpjiZsrk3laMM3fE3a/s47D9F4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768548874; c=relaxed/simple; bh=Ou2ZERoPxlj0ohVahbvKFHQZFovyVt4yyqUfqh4CLO4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nHYMD+cbvBQUJF3xmtUIb+3Qfm1WENJgduocbjYM5dAOAiFuUX8H5nH/1Z+GzkZsaBFKLtPn3suuUCFS2l30mKSlhT32DzhSxHfYgbvZZuHYy960WoHcxUXUU/cLzj2NxqyINiTgk/SrWGTQNniv8DMCiLY2APtI9C8Ty9vkiDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Dj4uFccd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Dj4uFccd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C887C116C6; Fri, 16 Jan 2026 07:34:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768548873; bh=Ou2ZERoPxlj0ohVahbvKFHQZFovyVt4yyqUfqh4CLO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dj4uFccd83lLVR5yJMQZ3dmlAStywm2wkPWdbV6kThbMOxJgw0GoSwDE/nFMFCjRz fq9UX6NLseusBPv2iguDBNvmg8/8HfBba+z4THATv/pjMLqV1sGesB58YMznNWZvNp U7L92duarfCPaj0AawUZ4WtSUYXe9d1xdoK6n+3E= Date: Fri, 16 Jan 2026 08:34:29 +0100 From: Greg Kroah-Hartman To: Dominik Karol =?utf-8?Q?Pi=C4=85tkowski?= Cc: Dave Penkler , Michael Rubin , Dan Carpenter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/12] gpib: agilent_82350b: Unify *allocate_private Message-ID: <2026011657-cling-flavoring-2f5b@gregkh> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> <20260115191925.52268-2-dominik.karol.piatkowski@protonmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260115191925.52268-2-dominik.karol.piatkowski@protonmail.com> On Thu, Jan 15, 2026 at 07:20:04PM +0000, Dominik Karol Piątkowski wrote: > Return values for *allocate_private functions as well as calling code in > gpib driver are all over the place. Unify them by returning -errno if > something fails, zero otherwise. Use the returned value as early return > value in case of error. Replace kmalloc/memset pairs to kzalloc. This is multiple things in the same patch, which is not a good idea. Each change should just do one logical thing, this should be broken up into much smaller pieces. thanks, greg k-h