From: Jakub Kicinski <kuba@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Tao Wang <tao03.wang@horizon.auto>,
alexandre.torgue@foss.st.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, horms@kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net v2] net: stmmac: fix transmit queue timed out after resume
Date: Sat, 17 Jan 2026 09:06:34 -0800 [thread overview]
Message-ID: <20260117090634.26148eb4@kernel.org> (raw)
In-Reply-To: <aWqmIRFsHkQKkXF-@shell.armlinux.org.uk>
On Fri, 16 Jan 2026 20:57:05 +0000 Russell King (Oracle) wrote:
> Thoughts - should the kernel default to having flow control enabled
> or disabled in light of this? Should this feature require explicit
> administrative configuration given the severity of network disruption?
FWIW in DC historically we have seen a few NICs which have tiny buffers
so back-pressuring up to the top of rack switch is helpful. Switches
have more reasonable buffers. That's just NIC Tx pause, switch Rx pause
(from downlink ports, not fabric!). Letting switches generate pause is
a recipe for.. not having a network. We'd need to figure out why Netgear
does what it does in your case, IMHO.
next prev parent reply other threads:[~2026-01-17 17:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 7:02 [PATCH net Resend] net: stmmac: fix transmit queue timed out after resume Tao Wang
2026-01-13 4:05 ` Jakub Kicinski
2026-01-14 11:00 ` [PATCH net v2] " Tao Wang
2026-01-14 11:26 ` Russell King (Oracle)
2026-01-15 7:08 ` Tao Wang
2026-01-15 12:09 ` Russell King (Oracle)
2026-01-15 19:40 ` Russell King (Oracle)
2026-01-15 21:04 ` Maxime Chevallier
2026-01-15 21:35 ` Maxime Chevallier
2026-01-16 0:50 ` Russell King (Oracle)
2026-01-16 13:37 ` Russell King (Oracle)
2026-01-16 18:08 ` Russell King (Oracle)
2026-01-16 18:27 ` Maxime Chevallier
2026-01-16 19:22 ` Russell King (Oracle)
2026-01-16 20:57 ` Russell King (Oracle)
2026-01-17 17:06 ` Jakub Kicinski [this message]
2026-01-17 20:50 ` Russell King (Oracle)
2026-01-16 7:29 ` Tao Wang
2026-01-15 3:16 ` Jakub Kicinski
2026-01-15 7:19 ` Tao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260117090634.26148eb4@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tao03.wang@horizon.auto \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox