Re: [v2,2/5] net: phy: realtek: simplify C22 reg access via MDIO_MMD_VEND2

Chris Mason
2026-01-18T00:36:12Z

On 1/17/26 7:17 PM, Jakub Kicinski wrote:
> On Sat, 17 Jan 2026 19:10:15 -0500 Chris Mason wrote:
>>>> Yeah. Just that this is not part of the series submitted.
>>>> It's rather a (halucinated) partial revert of
>>>> [v2,4/5] net: phy: realtek: demystify PHYSR register location
>>>
>>> Oh wow, that's a first. No idea how this happened. Is the chunk if
>>> hallucinated from another WIP patch set?
>>>
>>> Chris, FWIW this is before we added lore indexing so I don't think
>>> it got it from the list. Is it possible that semcode index is polluted
>>> by previous submissions? Still, even if, it's weird that it'd
>>> hallucinate a chunk of a patch.
>>
>> We've definitely had it mix up hunks from other commits, but not since
>> I changed the prompts to make it re-read the files before writing
>> review-inline.txt.
>
> To be clear as Daniel mentioned the chunk in patch 4 is the other way,
> so it "reverted" the direction too. At least we have a chance to use
> the "mark as false positive" in the system :)
>
> Daniel, series applied, thanks! The pw-bot is down, I think K is
> repacking repos so expect a delay in the official "applied" msg.

Yeah, it looked forward in the series and noticed the later patch
reverting those hunks. If you read the logs, it goes back and forth
trying to decide if an issue it found was worth reporting given that it
was changed in the later commit.

And then, I think it just forgot which hunks were which. I'll try to
beef up the section double checking diff contents.

-chris