From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
To: markus.elfring@web.de
Cc: almaz.alexandrovich@paragon-software.com,
jiashengjiangcool@gmail.com, linux-kernel@vger.kernel.org,
ntfs3@lists.linux.dev, stable@vger.kernel.org
Subject: [PATCH v2] fs/ntfs3: Fix infinite loop in hdr_find_split due to zero-sized entry
Date: Sun, 18 Jan 2026 19:01:45 +0000 [thread overview]
Message-ID: <20260118190145.41997-1-jiashengjiangcool@gmail.com> (raw)
In-Reply-To: <65bf90b1-8806-4f8c-b7e7-d90193d28e88@web.de>
The function hdr_find_split iterates over index entries to calculate a
split point. The loop increments the offset 'o' by 'esize', which is
derived directly from the on-disk 'e->size' field.
If a corrupted or malicious filesystem image contains an index entry
with a size of 0, the variable 'o' will fail to advance. This results
in an infinite loop if the condition 'o < used_2' remains true, causing
a kernel hang (Denial of Service).
This patch adds a sanity check to ensure 'esize' is at least the size
of the NTFS_DE structure, consistent with validation logic in sibling
functions like hdr_find_e.
Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
Changelog:
v1 -> v2:
1. Add a Fixes tag.
---
fs/ntfs3/index.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
index 7157cfd70fdc..da6927e6d360 100644
--- a/fs/ntfs3/index.c
+++ b/fs/ntfs3/index.c
@@ -577,6 +577,9 @@ static const struct NTFS_DE *hdr_find_split(const struct INDEX_HDR *hdr)
return p;
esize = le16_to_cpu(e->size);
+
+ if (esize < sizeof(struct NTFS_DE))
+ return NULL;
}
return e;
--
2.25.1
next prev parent reply other threads:[~2026-01-18 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-17 18:48 [PATCH] fs/ntfs3: Fix infinite loop in hdr_find_split due to zero-sized entry Jiasheng Jiang
2026-01-18 13:24 ` Markus Elfring
2026-01-18 19:01 ` Jiasheng Jiang [this message]
2026-01-19 6:37 ` [PATCH v2] " Greg KH
2026-01-19 9:48 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260118190145.41997-1-jiashengjiangcool@gmail.com \
--to=jiashengjiangcool@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=ntfs3@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox