Re: [PATCH 3/4] s390/vdso: Trim includes in linker script

Thomas Weißschuh
2026-01-16T08:15:24Z

On Fri, Jan 16, 2026 at 08:45:02AM +0100, Arnd Bergmann wrote:
> On Fri, Jan 16, 2026, at 08:40, Thomas Weißschuh wrote:
> > Some of the included files are unnecessary or too broad.
> >
> > This is a preparation for a new validation step to validate the
> > consistency of __BITS_PER_LONG. vdso.lds.S may be preprocessed with a
> > 32-bit compiler, but __BITS_PER_LONG is always 64.
> >
> > Trim the includes to the necessary ones.
> >
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> It's certainly a good idea to limit the use of asm/page.h and the
> other headers here.
>
> > There are other ways to solve this issue, for example using
> > KBUILD_CPPFLAGS += -m64.
>
> I think we should probably do that as well, especially since my
> kernel.org cross-compilers still default to a 32-bit s390 target
> for historic reasons, but the kernel no longer supports 32-bit
> userland.

Agreed. However I'd like to keep this series as small as possible.
The same change should also be done to a bunch of other architectures.

Thomas