public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND net v5 0/4] vsock/virtio: fix TX credit handling
@ 2026-01-16 20:15 Stefano Garzarella
  2026-01-16 20:15 ` [PATCH RESEND net v5 1/4] vsock/virtio: fix potential underflow in virtio_transport_get_credit() Stefano Garzarella
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Stefano Garzarella @ 2026-01-16 20:15 UTC (permalink / raw)
  To: netdev
  Cc: virtualization, Michael S. Tsirkin, Eugenio Pérez,
	Stefan Hajnoczi, Paolo Abeni, kvm, Eric Dumazet, linux-kernel,
	Jason Wang, Claudio Imbrenda, Simon Horman, David S. Miller,
	Arseniy Krasnov, Asias He, Stefano Garzarella, Jakub Kicinski,
	Xuan Zhuo

Resend with the right cc (sorry, a mistake on my env)

The original series was posted by Melbin K Mathew <mlbnkm1@gmail.com> till
v4: https://lore.kernel.org/netdev/20251217181206.3681159-1-mlbnkm1@gmail.com/

Since it's a real issue and the original author seems busy, I'm sending
the v5 fixing my comments but keeping the authorship (and restoring mine
on patch 2 as reported on v4).

From Melbin K Mathew <mlbnkm1@gmail.com>:

This series fixes TX credit handling in virtio-vsock:

Patch 1: Fix potential underflow in get_credit() using s64 arithmetic
Patch 2: Fix vsock_test seqpacket bounds test
Patch 3: Cap TX credit to local buffer size (security hardening)
Patch 4: Add stream TX credit bounds regression test

The core issue is that a malicious guest can advertise a huge buffer
size via SO_VM_SOCKETS_BUFFER_SIZE, causing the host to allocate
excessive sk_buff memory when sending data to that guest.

On an unpatched Ubuntu 22.04 host (~64 GiB RAM), running a PoC with
32 guest vsock connections advertising 2 GiB each and reading slowly
drove Slab/SUnreclaim from ~0.5 GiB to ~57 GiB; the system only
recovered after killing the QEMU process.

With this series applied, the same PoC shows only ~35 MiB increase in
Slab/SUnreclaim, no host OOM, and the guest remains responsive.

Melbin K Mathew (3):
  vsock/virtio: fix potential underflow in virtio_transport_get_credit()
  vsock/virtio: cap TX credit to local buffer size
  vsock/test: add stream TX credit bounds test

Stefano Garzarella (1):
  vsock/test: fix seqpacket message bounds test

 net/vmw_vsock/virtio_transport_common.c |  30 +++++--
 tools/testing/vsock/vsock_test.c        | 112 ++++++++++++++++++++++++
 2 files changed, 133 insertions(+), 9 deletions(-)

-- 
2.52.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-01-21  9:48 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-16 20:15 [PATCH RESEND net v5 0/4] vsock/virtio: fix TX credit handling Stefano Garzarella
2026-01-16 20:15 ` [PATCH RESEND net v5 1/4] vsock/virtio: fix potential underflow in virtio_transport_get_credit() Stefano Garzarella
2026-01-16 20:15 ` [PATCH RESEND net v5 2/4] vsock/test: fix seqpacket message bounds test Stefano Garzarella
2026-01-16 20:15 ` [PATCH RESEND net v5 3/4] vsock/virtio: cap TX credit to local buffer size Stefano Garzarella
2026-01-16 20:15 ` [PATCH RESEND net v5 4/4] vsock/test: add stream TX credit bounds test Stefano Garzarella
2026-01-19 18:17 ` [PATCH RESEND net v5 0/4] vsock/virtio: fix TX credit handling Jakub Kicinski
2026-01-20  9:37   ` Stefano Garzarella
2026-01-20 23:18     ` Jakub Kicinski
2026-01-21  9:45       ` Stefano Garzarella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox