From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E54E478869; Tue, 20 Jan 2026 20:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768942373; cv=none; b=V5NEJaBgPtUPzHDSFiMmXdc3IVqa0bmzUrC85DM4PNUATu9SNh6qtzBFXTPhH1kMm+RsUrg+Sej01WO4w58Ff1rvhmNT4DY1hFvRFAOZ+k9HZgS4G4qcb5eZYsa/ZfyE7j7P/CCT/26ba++JtvJ9qJzadD0ABfkHTFm3+RhdZQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768942373; c=relaxed/simple; bh=cWBmd+6SVqCMDlWlRDRyy1mmdiX760SlRrPD4p0g28o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=stFqBtX2hkZ2p6pmErGlYEndvLYY6geUENH5QGg6CKSzVd/yrtOQYtKl6LBJ2AjV6uGiAmG43bMGeR88RaU9SZXVZOX04a2oBatkCZ22JIpCV+FyZHqWAnWl26Vs7j75p/WMnc9vPoZqlyCeiJVHcQEc0J86kUTVRl5Cdx+sNzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VHl86lUh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VHl86lUh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC9B0C16AAE; Tue, 20 Jan 2026 20:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768942371; bh=cWBmd+6SVqCMDlWlRDRyy1mmdiX760SlRrPD4p0g28o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VHl86lUhY0auHqalxqSkh8KfGqaWm2aDNOCB5QCqfGX2RGydBdJi/QXetiwhA9ObL cUl/0gsQws6Ck8C/OhTzY078OVX6uLp5D5iXT2rLdNZacqIoDXrGy/mRXbTQcWe0jq +l7DCmWtmdRocejG6UUu46R5foCZGqBRhiql743qMYSdMaAG9tb5ZhNS88uzQqr5qf 442pqt/7QoBU9bJ4OqUnw+ANiGXdw/ZIeiLeXjEc0QgSwBhdQVQTGqJuydvdckybD4 8DgXiqY7eWwO+m7RQBXuyFo5SWxMBCcqkxO5ZZw+gLhNWf+VszWbJ0VZOe0fufHO7e nGIJ1F09daVVQ== Date: Tue, 20 Jan 2026 12:52:49 -0800 From: Eric Biggers To: David Howells Cc: Lukas Wunner , Ignat Korchagin , Jarkko Sakkinen , Herbert Xu , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , "Jason A . Donenfeld" , Ard Biesheuvel , Stephan Mueller , linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 01/12] crypto: Add ML-DSA crypto_sig support Message-ID: <20260120205249.GA2657@quark> References: <20260120145103.1176337-1-dhowells@redhat.com> <20260120145103.1176337-2-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260120145103.1176337-2-dhowells@redhat.com> On Tue, Jan 20, 2026 at 02:50:47PM +0000, David Howells wrote: > +config CRYPTO_MLDSA > + tristate "ML-DSA (Module-Lattice-Based Digital Signature Algorithm)" > + select CRYPTO_SIG > + select CRYPTO_LIB_MLDSA > + select CRYPTO_LIB_SHA3 > + help > + ML-DSA (Module-Lattice-Based Digital Signature Algorithm) (FIPS-204). The selection of CRYPTO_LIB_SHA3 is unnecessary. > +struct crypto_mldsa_ctx { > + u8 pk[MAX(MAX(MLDSA44_PUBLIC_KEY_SIZE, > + MLDSA65_PUBLIC_KEY_SIZE), > + MLDSA87_PUBLIC_KEY_SIZE)]; > + unsigned int pk_len; > + enum mldsa_alg strength; > + u8 key_set; > +}; 'key_set' should have type 'bool'. Or just use pk_len == 0 to mean the key hasn't been set yet. - Eric