From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012019.outbound.protection.outlook.com [40.93.195.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BBF73D301B for ; Tue, 20 Jan 2026 22:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.19 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768946744; cv=fail; b=K9NETOEdyW+RMM1wymNhW6Ov/5BytegAwouBQFTSyHZo9anz+AgBW4/SHdnCIfPndGSQ/iA9LIBlY5gvtVmZxa0z8ACTZhljrnhwL3OYwTJG6chMPmFJpgJRgWiy48GiV3Y9ceQP6tqXTgLdkgXezDYEr5pwZ9X3KT0FvNc6K50= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768946744; c=relaxed/simple; bh=v1TSzLLwAv2qUOilB99mCwVjbzIEaMrLLZ4w0f6dTsM=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=EDi3AyLvFQITRsyVedrzXS1fRwpDZ9nh9NsuCNXTaXiVj3AJV9q5Fyj9I3sDzYxJrMY8dTQQooWgcmbRWyxdnZqTyIdR4RhOnV7muM8U1xEP6qYxuLx75yYSfQpo3coNxQy9AnXwA0+bYbNogCwJf36tFr9KaxX32CMfS55LiU4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=LVrBNSV9; arc=fail smtp.client-ip=40.93.195.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="LVrBNSV9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QIH/2PhzvudaqwUlMSWrAq7qXiDrr5HVDwtZrWpGo8BSN7Pnz+NkqT4OUwIAZLpbYmmSH9VLvVl+vbqBg1y+q8XrljR9+dc7CuceSK0xW8qJIeIrSZ4YUiTGCRB7t2/IIrlGYCwBT5hfJHTdCcVGxNjA4Sk7naZYqbxL6cKrSmZKaC9QFrbrt/2HTSe4SU3i7RoOd1TAQdbq3n5mWoY9UX2+bpJwYvpHNGRCD1H3bhUEF9QPdxmcVip41z7+wfgalu4Q/ICPiNuhBaZJV/2n8SZ418SycP9frbsRjA1u3IMuMRa6vaAu40FRqiATQSOe0gswDctb76xhYGVqrMGoYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SOljswjMh9rLcFYW5MaE71qT6V5//T8d3mGKn9XrZvM=; b=vt44puETLBoCJI3SN++3AG/VJahZnAJz2wy4NN0yJuzP7s7NZao3VcIyr9Q6w3JtjvI2poNUXqdTZ9Zvkbtq+yN96VwdWcKxWt5plFO3cSPMz8IimZpUCLGTNcO4n2FsgXOzmmT/xQDoNiFhwGxPqEBEG9F8dYzyyQxrTyWGUqZs3xCBYJr+f4J1cMBZ2URWNoZzSHK7Ltj2nQSsqQBQ1j3PUcDH2VaXfZ5GZssnb4PR/y8ZTqyPYt1Kc5Wgi7HJLIU0krX0ZGkm5EbdpWLy1B0b/q7Jh7L5Xu2nki64qPWpY0t/EUeJ3mOI8PVa/BEjjObDO7uhmayLVYlAFb/8ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SOljswjMh9rLcFYW5MaE71qT6V5//T8d3mGKn9XrZvM=; b=LVrBNSV9SzjT+KnlMeV5vPtTlcJUdQaf0NzQiODK+0eYdt9fjyKqg7k6qeL/67+xboD1K9G1bpmUY31g5bM8/8LTKpJRJgnpydereGjTE78Xm7AFovrRudQbpiNEuhlLz/idTot9kM+Ibm6Y18NRcdxP9aa8Fgjdlc6sRJdQzpc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) by CY1PR12MB9627.namprd12.prod.outlook.com (2603:10b6:930:104::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.9; Tue, 20 Jan 2026 22:05:38 +0000 Received: from DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f]) by DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f%6]) with mapi id 15.20.9542.008; Tue, 20 Jan 2026 22:05:38 +0000 Date: Tue, 20 Jan 2026 17:05:34 -0500 From: Yazen Ghannam To: Mario Limonciello Cc: Jean Delvare , linux-kernel@vger.kernel.org, Borislav Petkov Subject: Re: [PATCH v3 5/5] firmware: dmi: Read additional information when decoding DMI table Message-ID: <20260120220534.GA1775505@yaz-khff2.amd.com> References: <20260110134835.1296600-1-superm1@kernel.org> <20260110134835.1296600-6-superm1@kernel.org> <20260116213032.GC471170@yaz-khff2.amd.com> <20260120214520.GA1753876@yaz-khff2.amd.com> <3f427986-1d7a-49b1-b661-e5004f1c7f0d@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f427986-1d7a-49b1-b661-e5004f1c7f0d@kernel.org> X-ClientProxiedBy: MN2PR06CA0016.namprd06.prod.outlook.com (2603:10b6:208:23d::21) To DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6373:EE_|CY1PR12MB9627:EE_ X-MS-Office365-Filtering-Correlation-Id: 2516bb86-8d00-4eee-931e-08de58700b33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aWE/z4sW4pQ4bOggxzZxhkTGvP9sI8BW6pfx3uapRdfQRRHHzy5kD1T1EtrX?= =?us-ascii?Q?IucGE4bKLNVY1NoUWAaXRnjxgc/iBAtgC9fBWvjLtCnYDIpI2PN5WnVr2eJ/?= =?us-ascii?Q?q8qX3iCzqu57yr0ApXSkPHA0rUWrxz8Q6E3VkYgMqmY4CDapSnHnWy8rmEGX?= =?us-ascii?Q?u7u5m/ZWkc03qY8owZCb5jl7CBarP4FuvYKffcHncMTqkXNSO9dYCydTseB0?= =?us-ascii?Q?JnGzR8UBmnkJ5Q9RxBS3a6qzAgw7tzQy7sgqhz9ruDGvliOAoOPzoyXO99f+?= =?us-ascii?Q?YNwS20jArHJpHRIE9qDmzoZKqSQOxTIm9Z5oqOwtU3UKg2kiCAdrnHW7t1PV?= =?us-ascii?Q?VBoXyyMJxW8FLRw7foaW66S9a3QF8D3WJpys3A1tRYvaQoTn4JacspKnc1j4?= =?us-ascii?Q?eChJQC8XNoi8AsBIOXkEuJKmJnFsdk40apfY8KiPd+qLZIGJorztzX2xckzK?= =?us-ascii?Q?AuqyV7Rk4fuy95nZrqBxe9LYntO4+D22l+Ze2Skzto7pb1MF/zPu6tjh8gdK?= =?us-ascii?Q?IlGjYW0Z7YojcLUzhq+4pSOvGC2c97gd4RcrV8PkP7INZOJQv7Tksv6UqXFG?= =?us-ascii?Q?BA67FH4+/DRWZPO15Cd90ozgNouc436jIgjli3EsTUVnOzE4P6OkGo9nbeWC?= =?us-ascii?Q?D/OPpOIFfp3lk5z5nw2dye+7hWU+PLhqV/U6OyIukk6grfHOWOeD95kIfD2B?= =?us-ascii?Q?75WOTHeWajQUEc7asQWXQDU9fWbYT/gfP1Q1CALX7/6sRlpXDuDE+xs0ZJB5?= =?us-ascii?Q?DPZJ8M9dI1biPecfpFmHnI96ZYXeUzoUuBESneRtd/pmKV3yvAbsp9MyBGD8?= =?us-ascii?Q?jdN/tHCiS/TbtukmhcFDBY1Qorn0Sw7VupP+5mSKV7k37s4sGlnDyi3lfAMt?= =?us-ascii?Q?4gI2hwawZZL4Roq+pbd6FfKdD0UyiLOENLkb5iIKapGeKaEuu79ReUTTPHGu?= =?us-ascii?Q?BPRyJzxHh0DmuLjcMw4TZWtLyH7Zv79aXVIIhmkCYx6Ms+hmwKNOZ/yj7Xye?= =?us-ascii?Q?0dKB0cL7I6hsiJQU47pNCix8mUrysxjXxD01J2PaioAtwmIyoxSWILL5VJ9p?= =?us-ascii?Q?lPJq76g/dKw1Howd3k/Dc+JLM00ibe8mbuQ8kp08h0tMftGCwKMiWBpEC47X?= =?us-ascii?Q?pYZESz6oIvMLw2SHY8+P8M74LRiIpykj3NuC0JSq1M3YI5//BxFJzrrvq1/N?= =?us-ascii?Q?HjBFF1K5EV67wB8SeM8fwI3qjg4O+X3pW98rHeCw5eCmZOBetsHsY9ThcQJ2?= =?us-ascii?Q?zrLjj+yENSaR1bGCHi7nahX4EO9VdFDYl52M/zh6COUEMQfJIdryiIDDMHDG?= =?us-ascii?Q?pvoLogeRd2ZkYLDi3zum0lAQy2pQPZI60EK0umZqbva6fUjDeRWsYBNjXxgg?= =?us-ascii?Q?XPkwV97CmxFNLmWsAH/TLHOWe41oFuynW9pZXUQWSBUT0rm3Zx+T8uFVIQ2E?= =?us-ascii?Q?13iPO+t2kNXeTyqo5ACglRcK8fGE24PhwqbyyiKhGDX+SdOeKp/2r7XSE53a?= =?us-ascii?Q?+hJ1qV3uDGVRKH7wRI/fRrKUV0Okeych1L82Ndfmy5YmbI/DrAASNRwz+J6P?= =?us-ascii?Q?7FkX900UeIZ6WAgijmk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6373.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g4bIa/K1OlI8tB6km47FtfgDce/MpdKJRV6afnf0dHak8GKXPu4mc87SKiS3?= =?us-ascii?Q?WReV+02MEqRKNC8k7jel+pwC/K993rNlM6Gym6jSshd/oHICpBRKl+U9Bo+q?= =?us-ascii?Q?I0pPP291QgWxo9aGSlS7TyIGUaTMbrfEFKwor5irGSxnedsUq1bhBc2UzjM9?= =?us-ascii?Q?unaN5k9KmefpYhcME/v3ga6XABtJ7jlOV29GJ0Ls/thrL8X4Gvu5Nnct5Ljx?= =?us-ascii?Q?NGVGPkckCBrH6kzutGTzXABI9L/DZb/6d61sdMFd6FQ3yjp+usehtkvzXB4G?= =?us-ascii?Q?7okvtDy5K/NHhK+3/aYocActjsqGZFnpkLq1mbKgoX5761iyCY36p4jJsX8J?= =?us-ascii?Q?ihxJKRCxm/k8KFL3ngy06nBpoVTMGCI9JLNX7qAZfkI12pKwb4pJfRJelRM7?= =?us-ascii?Q?YBoXUJuPeS8+UN+k6aRgfuSI+QlqSUbN9TkQHJddNj3DGD02wOwIK5wyWtwA?= =?us-ascii?Q?Hae4n5dXqpLubHtAlqV0RuPyYQQLKw9A9eOrxrsw6OsGuqaYEr5icKds1jTV?= =?us-ascii?Q?qXJ8gOOM4NwGrgTgSPbdxuCTftptRTpR1cTWA2qqxoLj8+0BQ1uKd8uMlHhs?= =?us-ascii?Q?JDbedBD7mG3AcC3igkJXffFzZIVh6I8+EeWsDPFkxn55AoLm34GPX4vL48gF?= =?us-ascii?Q?6si1IdO/ofMs5SfiXDJkUDxmcgsGwJODIxuAukp0hHQiLgRsKPOkqf3mCBYw?= =?us-ascii?Q?ycGLEO50DAsk01lp+xH7QqGS8OavXY2gT9JXtgh2acMCDtbazRke0LvMMMKV?= =?us-ascii?Q?iI5MwXWkXa6HE88+RrR2ZcAIj6P49Nho9diN1d05xmZiDQHgEt0VzO768OTt?= =?us-ascii?Q?RDx0hWa4cKuFGvhmmmfbu+RvGksTBDxaGW0ni3zwtagrcp0U6InSksyWK8NK?= =?us-ascii?Q?UiwWbqVT1R7sdHnc+DMq6tDQePoTJrTa904FkaVpe7rFwudj5j5PWAxfHNQz?= =?us-ascii?Q?q0lLg933QqjgiZSyk515DoLTzCgCsqJ/DpMsJAdXWHO2n82Hv7O6VdO4jhTS?= =?us-ascii?Q?aSjgOKfPgpG0V/vV6Of+lVMNPojznN3TZ3GBeaIOVnqTwzoVftcylJlW4XXn?= =?us-ascii?Q?StnBorHnJ6Q3fq5yfK0Xo+mwX+YCcbYgXuALiaiuJAM/NjEz0K6lDz/UDlpW?= =?us-ascii?Q?eU7CQbuTaMo9fv41r4xaTuPTc1Sl2ZdnM91lfNULBHJNZPfOcdS6cSQ41wdz?= =?us-ascii?Q?PfFMx90Uhx3DDiDgg8aAdsnAqPLEBU9ZtlZXYvcMkP07ianM+LjoH6/yh2u9?= =?us-ascii?Q?RbgzAEEdxIV4o40JEAvtuRilDFIcjufrWjtugzl97enjaAtJMIKRp8YeiQy0?= =?us-ascii?Q?lGPLDBldwPP8NhC8Ynp1F6Sjk+uIeYVy58J8OAPazwjVO48njvyu7N48CLRa?= =?us-ascii?Q?paq4DNoUZuKLTxo0aS7Gjo5IE56MA/wqlMJFdSqKXlPS3dLuEbeV2FOm9DL2?= =?us-ascii?Q?jcDyi3ZOEuCjnuwmDBdZ4nsUtgpdTazdV84mt1GgGgqyNC2wl3u4PGaO/Z4j?= =?us-ascii?Q?PJJvdzkyDQX51zPYDAL0KC3lxkYyXR9D568UUOg4ANJKEqwat+qaNrqIJUNG?= =?us-ascii?Q?38rFLDhtXqFMMt2qwKNlE+bmWT6cywwsVYLLyF7HAQUEh0RXsuluXneQA6oX?= =?us-ascii?Q?X7QkvkeZp9RBa674Tb9jk1fqtPf/3QDI30BZJptc5VhmIrgh2ublIVxr0ipA?= =?us-ascii?Q?7r19aBOjkrd7LTXgSAksz3qmcj7ieFX274Ge6wZRIhU1VKeJ38fC2Mlcmh34?= =?us-ascii?Q?TLQeRWMqkA=3D=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2516bb86-8d00-4eee-931e-08de58700b33 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2026 22:05:38.2153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DM5Q3CLfkPKpBq+vxGR4WRAaca43ciggE2Xrd5Z9u2jFvNXPl/w9pRGnPvS+Ydz6DVquE4TDIkFoojlG2q6s/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9627 On Tue, Jan 20, 2026 at 03:55:54PM -0600, Mario Limonciello wrote: > On 1/20/26 3:45 PM, Yazen Ghannam wrote: > > On Fri, Jan 16, 2026 at 04:30:32PM -0500, Yazen Ghannam wrote: > > > On Sat, Jan 10, 2026 at 07:48:34AM -0600, Mario Limonciello (AMD) wrote: > > > > > > > [...] > > > > > ACPI tables do this a lot. So there are examples of iterating over > > > variable length entries. > > > > Here's another implementation. What do you think? > > Oh you beat me to it, been busy this week. > > I do like that we can localize the printing code to amd.c. I'll test it and > let you know if it works. > > If it does; I'll roll it into the series. > Good deal, thanks! [...] > > + > > + string_ptr = dmi_string_nosave(&info->header, entry->str_num); > > + > > + /* Only one AGESA string is expected. */ > > + if (!strncmp(string_ptr, "AGESA", 5)) { > > + pr_info("%s\n", string_ptr); > > + break; > > + } > > + [...] > > +static inline const char * > > + dmi_string_nosave(const struct dmi_header *dm, u8 s) { return NULL; } Found a bug. :/ The default return value should be "dmi_empty_string". Thanks, Yazen