From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Prashanth K <prashanth.k@oss.qualcomm.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] usb: dwc3: Log dwc3 address in traces
Date: Wed, 21 Jan 2026 00:10:21 +0000 [thread overview]
Message-ID: <20260121001015.62ue4o75ntzmt7yr@synopsys.com> (raw)
In-Reply-To: <f1375e71-923c-4f59-84f7-6cf11629a443@oss.qualcomm.com>
On Mon, Jan 19, 2026, Prashanth K wrote:
> On 1/16/2026 11:21 PM, Thinh Nguyen wrote:
> > diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
> > index b6ba984bafcd..8e5d474fd54a 100644
> > --- a/drivers/usb/dwc3/trace.h
> > +++ b/drivers/usb/dwc3/trace.h
> > @@ -37,19 +37,22 @@ DEFINE_EVENT(dwc3_log_set_prtcap, dwc3_set_prtcap,
> > );
> >
> > DECLARE_EVENT_CLASS(dwc3_log_io,
> > - TP_PROTO(void *base, u32 offset, u32 value),
> > - TP_ARGS(base, offset, value),
> > + TP_PROTO(struct dwc3 *dwc, void *base, u31 offset, u32 value),
> > + TP_ARGS(dwc, base, offset, value),
> > TP_STRUCT__entry(
> > + __field(phy_addr_t, base_address)
>
> Shouldn't we be using 'resource_size_t' instead ? Anyways its just
> typedef of 'phys_addr_t'.
>
It seems more fitting to use phys_addr_t here for printing the address.
I'd use resource_size_t when calculating for the resource size. Let me
know if there's an issue.
BR,
Thinh
next prev parent reply other threads:[~2026-01-21 0:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 10:07 [PATCH v4 0/3] Add the address in traces Prashanth K
2026-01-14 10:07 ` [PATCH v4 1/3] usb: dwc3: Remove of dep->regs Prashanth K
2026-01-14 10:07 ` [PATCH v4 2/3] usb: dwc3: Add dwc pointer to dwc3_readl/writel Prashanth K
2026-01-14 10:07 ` [PATCH v4 3/3] usb: dwc3: Log dwc3 address in traces Prashanth K
2026-01-14 11:40 ` Greg Kroah-Hartman
2026-01-14 22:54 ` Thinh Nguyen
2026-01-14 23:54 ` Thinh Nguyen
2026-01-15 6:37 ` Greg Kroah-Hartman
2026-01-15 16:22 ` Thinh Nguyen
2026-01-16 5:37 ` Prashanth K
2026-01-16 17:51 ` Thinh Nguyen
2026-01-19 6:55 ` Prashanth K
2026-01-21 0:10 ` Thinh Nguyen [this message]
2026-01-14 11:42 ` Greg Kroah-Hartman
2026-01-14 22:30 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121001015.62ue4o75ntzmt7yr@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prashanth.k@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox