From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59FA5329385; Wed, 21 Jan 2026 02:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768963204; cv=none; b=NGVbz/85+BP3fbsjD2j58vdtmJgwsNCgzm3cxYFg1Obr72qXF4D3Iuf8MJArLQbx5kLGLzgEgzf1dtCs3MtkmGnwJaV8NzLAxR+KDRBUBy8N34TaK8r1M8bX1Cefk+7CzxBvDn05czC122WwKAIFE5YXtOYvsf1x4qLWv5CTGE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768963204; c=relaxed/simple; bh=+kYehEeL0rHC2CLtfdhajEXhmnfOr//n+Q/64DRdOXI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kS+t6zHI6LFReS6QVOCNr1YMuLD59aqS6te+mrAx0OHt63Px3viWpxo5yoid5qhF38F4m1o1TFQkI+lkMxW8NGDf0jBxLp0p76VFGNLvujtQvrOVtMEEgDMqCIEqj6hm0/AklYa+FXCsBlMKMNA2MQCI4eCJCfdvK4pCRlGLy+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W3yHlX6G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W3yHlX6G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEDA1C16AAE; Wed, 21 Jan 2026 02:40:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768963203; bh=+kYehEeL0rHC2CLtfdhajEXhmnfOr//n+Q/64DRdOXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W3yHlX6GldOjZe0vr0DQP/Bo9VeeugQY0W2qB2WKa3FZ2juQ8Eh34BHHFwLa/LzVf wJzVWOSbIlBq7cJwzj2sMygGhCSFWXJFi6Dc1nF1c5h1O0iOfmOc/vWTj5oiMzO6Ub DCmO1QaiM4CNyPnrHXWv4kDBsBzWAEONBjoXjmEiaaW8oJnQZbXI//HLCPbycQQT5H Wmh4MgTCVCOeeJUTxOol89pTYoI48I6AgZVkSEFWxWTlDHMBPmaGdd5GW0y96bqM7v VwTxvxzXc/e5dMmfuOB4cDJp55oiqP61dXc0OXINn0tmGqTXVHhEOCxQu8gM9doSwY bCadwb1P/jKmA== Date: Tue, 20 Jan 2026 20:40:02 -0600 From: Rob Herring To: Miquel Raynal Cc: Geert Uytterhoeven , Mark Brown , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Vaishnav Achath , Thomas Petazzoni , =?iso-8859-1?Q?Herv=E9?= Codina , Wolfram Sang , Vignesh Raghavendra , Santhosh Kumar K , Pratyush Yadav , Pascal Eberhard , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 01/13] spi: dt-bindings: cdns,qspi-nor: Add Renesas RZ/N1D400 to the list Message-ID: <20260121024002.GA1845406-robh@kernel.org> References: <20260115-schneider-6-19-rc1-qspi-v2-0-7e6a06e1e17b@bootlin.com> <20260115-schneider-6-19-rc1-qspi-v2-1-7e6a06e1e17b@bootlin.com> <87qzrpucae.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87qzrpucae.fsf@bootlin.com> On Fri, Jan 16, 2026 at 10:39:21AM +0100, Miquel Raynal wrote: > Hello Geert, > > >> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > >> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > >> @@ -80,6 +80,10 @@ properties: > >> # controllers are meant to be used with flashes of all kinds, > >> # ie. also NAND flashes, not only NOR flashes. > >> - const: cdns,qspi-nor > >> + - items: > >> + - const: renesas,r9a06g032-qspi > >> + - const: renesas,rzn1-qspi > >> + - const: cdns,qspi-nor > > > > Doesn't the need for (at least) the CQSPI_NO_INDIRECT_MODE flag mean > > that this device is not compatible with cdns,qspi-nor, and thus the > > cdns,qspi-nor fallback must not be used? > > I understand the question. It is true that I use driver data to limit > the number of features the IP can use and this data is associated to the > Renesas compatible, but I believe all other flavours of this IP would > also not work without driver data attached to their front > compatible. None of the SoCs with the Cadence QSPI IP actually would run > without their own driver data. For me the fallback compatible is > relevant because it describes the hardware as "this is a derivative of > the Cadence controller" (and it is clearly the case, and this is also > mentioned in the reference manual), even though I agree using > cdns,qspi-nor would definitely not work alone. But again, none of the > other flavours would anyway. Fallbacks should be usable on their own. We've generally moved away from having these generic licensed IP compatibles because they always have per platform changes. Rob