From: "Mario Limonciello (AMD)" <superm1@kernel.org>
To: Yazen Ghannam <yazen.ghannam@amd.com>, Jean Delvare <jdelvare@suse.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
"Mario Limonciello (AMD)" <superm1@kernel.org>
Subject: [PATCH v4 4/6] firmware: dmi: Add pr_fmt() for dmi_scan.c
Date: Wed, 21 Jan 2026 00:04:29 -0600 [thread overview]
Message-ID: <20260121060431.432350-5-superm1@kernel.org> (raw)
In-Reply-To: <20260121060431.432350-1-superm1@kernel.org>
Several prints inconsistently use DMI: or dmi: or nothing. To make
it clear which prints come from dmi_scan.c, add a pr_fmt macro.
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
---
v4:
* Adjust "DMI not present or invalid" message too (Yazen)
---
drivers/firmware/dmi_scan.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 80aded4c778bc..ed6235ac576b6 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -1,4 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
+
+#define pr_fmt(fmt) "DMI: " fmt
+
#include <linux/types.h>
#include <linux/string.h>
#include <linux/init.h>
@@ -634,7 +637,7 @@ static int __init dmi_present(const u8 *buf)
dmi_ver >> 16, (dmi_ver >> 8) & 0xFF);
}
dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
- pr_info("DMI: %s\n", dmi_ids_string);
+ pr_info("%s\n", dmi_ids_string);
return 0;
}
}
@@ -663,7 +666,7 @@ static int __init dmi_smbios3_present(const u8 *buf)
dmi_ver >> 16, (dmi_ver >> 8) & 0xFF,
dmi_ver & 0xFF);
dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
- pr_info("DMI: %s\n", dmi_ids_string);
+ pr_info("%s\n", dmi_ids_string);
return 0;
}
}
@@ -758,7 +761,7 @@ static void __init dmi_scan_machine(void)
dmi_early_unmap(p, 0x10000);
}
error:
- pr_info("DMI not present or invalid.\n");
+ pr_info("not present or invalid.\n");
}
static __ro_after_init BIN_ATTR_SIMPLE_ADMIN_RO(smbios_entry_point);
@@ -810,7 +813,7 @@ static int __init dmi_init(void)
kobject_del(tables_kobj);
kobject_put(tables_kobj);
err:
- pr_err("dmi: Firmware registration failed.\n");
+ pr_err("Firmware registration failed.\n");
return ret;
}
@@ -831,7 +834,7 @@ void __init dmi_setup(void)
return;
dmi_memdev_walk();
- pr_info("DMI: Memory slots populated: %d/%d\n",
+ pr_info("Memory slots populated: %d/%d\n",
dmi_memdev_populated_nr, dmi_memdev_nr);
dump_stack_set_arch_desc("%s", dmi_ids_string);
}
--
2.43.0
next prev parent reply other threads:[~2026-01-21 6:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 6:04 [PATCH v4 0/6] Print AGESA version at bootup Mario Limonciello (AMD)
2026-01-21 6:04 ` [PATCH v4 1/6] firmware: dmi: Correct an indexing error in dmi.h Mario Limonciello (AMD)
2026-01-21 6:04 ` [PATCH v4 2/6] firmware: dmi: Adjust dmi_decode() to use enums Mario Limonciello (AMD)
2026-01-21 6:04 ` [PATCH v4 3/6] firmware: dmi: Add missing DMI entry types Mario Limonciello (AMD)
2026-01-21 6:04 ` Mario Limonciello (AMD) [this message]
2026-01-21 6:04 ` [PATCH v4 5/6] x86/CPU/AMD: Prefix messages with x86/amd Mario Limonciello (AMD)
2026-01-21 10:49 ` Borislav Petkov
2026-01-21 14:28 ` Mario Limonciello (AMD) (kernel.org)
2026-01-21 14:37 ` Borislav Petkov
2026-01-21 6:04 ` [PATCH v4 6/6] x86/CPU/AMD: Print AGESA string from DMI additional information entry Mario Limonciello (AMD)
2026-01-21 11:30 ` kernel test robot
2026-01-21 14:26 ` Yazen Ghannam
2026-01-21 14:28 ` Mario Limonciello (AMD) (kernel.org)
2026-01-21 20:50 ` Mario Limonciello
2026-01-21 21:30 ` Yazen Ghannam
2026-01-21 22:06 ` Mario Limonciello (AMD) (kernel.org)
2026-01-21 15:44 ` kernel test robot
2026-01-21 18:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121060431.432350-5-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=bp@alien8.de \
--cc=jdelvare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox