From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F353126DE for ; Wed, 21 Jan 2026 13:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769000957; cv=none; b=AQRAa6qBGd8Xt3SZNcD1+EGcfpAKxZIbxstiWlQb7DBVFodM9dIsYhO+PgZJPUCkycI+S/TJzOyqy2zb2jH2fYilsgmoGRsjuP1h2UVNh6k6qToSxVnaq+xtt8/tWL2S9J+GpRetYHIqW9vW5G1LhU/OxTCbci1u6fbZFk8US3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769000957; c=relaxed/simple; bh=fATiihlOjI3MvLNyPnfBpP8QVGWkXCWdBDBKmFXlrVk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HtQMYu4M2Ypnk2Efya30oESCKbKaHV1lSAZ2Y2QQq1tcIaRe+++U7mtDaHjJOppyfyo33mzPbhSbYf2ayTpfkjrqoc4IoW3OL/mTfQiCvF26ZL4eq69qKdlxf6dWl56Iy9OtXv2MQEa+iKT6VnjBOvCwoct6LP9lBZuH9YREdk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pn2VjeSD; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pn2VjeSD" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-65807298140so2663623a12.2 for ; Wed, 21 Jan 2026 05:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769000953; x=1769605753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=P4+UV6wR1tAB/YyUs6TPuGVmRVeqrBL/GPaWOyEoV2M=; b=Pn2VjeSDAhPWSAKmEXP0TYUyfA0YMdkF2TJ61LjmVUis6HlDVeCgvD+UpBYTnukMRs doGGb1tp6ibP5JiNp8sJD+N3zmCuYZG6Sgs9xuuVQyuu0D3wl/5SCq4kcJavk0VufthS U0WE1E6WxyOFuEHwES8HCel4ixfc9xm5Jfw2JhFmjUZsn6zA9rbkVTnOC/PHQ4K4KNC3 PtsNMwyJBB9E6DTw+s//TIiTF+8ojV8HzagvFMrT7paylAiVftGOPbVygPlaTDgmCU5U 5E3mBHA+3JJa/G44pOE3kzQAZpX1uSIrHaag7TaICCYXZYyXBYiRNhuhT1ZyKeMwKXiM 1jJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769000953; x=1769605753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=P4+UV6wR1tAB/YyUs6TPuGVmRVeqrBL/GPaWOyEoV2M=; b=utB0WWP2GG/kv9dheFuep6+0T9Dfv7GJT2JSA7ZzZId2jdwXbEWfLJSi92S4P/+BpI CkoLaIXsOt+HZoDWplBOC/I1VN1jCsqaSE/zqaAkc9eZ0ZHd1ZWcYntu0Hc1cKTDrxWr aExc9mqgkN+AVZCSrGrWj6DkOp1yN2aQQPH9LDmv9LO1+aaaHsuXXs3MwZZ7nbQMq3jw vPmsO3roRkVpYFwSi/Lwy6XI6Ba23qxvkmdUK9JRTfZX359LmGz+kC5ALGT3s8Jm0DLd xbQFhdEnHXnx5E7sWkIVFLRrQ/s79hFPpxr/1Ws6k1J4p/dnpkAkLlAJiBP8r5nFoVs0 cL6Q== X-Forwarded-Encrypted: i=1; AJvYcCWAAKQUbxBmDJp+RV/OJD+2pa7OrJwYAF/FLk2ISIn805FEtIWJ2AteyYkqioJzN59hOyn8sLAReIV7ZVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzOzYLeFc6rNHJ4HnhBC5pquZlrJFCNk/56eTZQuEtimq2HHsWH pV058bTKHpylOjsmlZDDDziRKJGklB/jbpPvnxLxo/LpVnfGlBSJyN8deX1HyQ== X-Gm-Gg: AZuq6aLpxLGCjGE/x7qpbp2nWUv3lR9RHJF/A3qkAziMzPkVLl19miu90N7CG3WtarG 8B08FIg4qQ8iGBW29+uGU1izAPaYgnGYahSCci8a3mWI1bJbQdYwHmMsVTQormo9EvwY3Ai3xhP ftt841tKafkxR89Jsw/gZapLgthv4vWcpd0c9MkSK622R7W88fgkyDKEIXDK7WjcnHEWsWkdPzm yAwOUBUzLPlJi/LX+mH60mTuodNkIoY0xoiUh0/h9vnf3TY9za08Pg2QzhCKMoJiBKIWGr2B6J6 SwWqAyiIr51p5NUDGPg76ZG0NHZl7EXSvQE5HyfaIwGHfL2Hiy0rckg6GyOouFdOX0J4grPW6dp R2VDQbqoy+xbcv+pq8KE1TSkg8oxtI0C4tb1UUEUIKM1BXSSVMQH8laLUqdtphKGh/1cU48kRJq UsbelcWHN0XsSg3+BKvbUgNDLEKhDR+kouUSGQhv0bT7S8tIqiXJfXpXlk3ONTtJQ= X-Received: by 2002:a05:6000:1acd:b0:431:8f8:7f1e with SMTP id ffacd0b85a97d-435901751cdmr7939323f8f.48.1768995134371; Wed, 21 Jan 2026 03:32:14 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996dad0sm35896316f8f.27.2026.01.21.03.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 03:32:14 -0800 (PST) Date: Wed, 21 Jan 2026 11:32:12 +0000 From: David Laight To: Matthew Wilcox Cc: zenghongling , muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhongling0719@126.com Subject: Re: [PATCH] mm/hugetlb_vmemmap: Use max() macro to simplify the code Message-ID: <20260121113212.3d685ad2@pumpkin> In-Reply-To: References: <20260121015114.560424-1-zenghongling@kylinos.cn> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 21 Jan 2026 06:17:07 +0000 Matthew Wilcox wrote: > On Wed, Jan 21, 2026 at 09:51:14AM +0800, zenghongling wrote: > > Use the max() macro to simplify the function and improve > > its readability. > > How does this improve readability? I understand what this does in > the ternary form. I have to think far harder about it in the max() > form. I must do a patch for checkpatch.pl to stop it suggesting min/max for trivial cases. Oh - and stop it ever suggesting the _t variants. IMHO it is better to have an explicit cast on one of the parameters. David > > > if (!is_power_of_2(sizeof(struct page))) > > return 0; > > - return size > 0 ? size : 0; > > + return max(size, 0); > > } >