From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3693659F9 for ; Wed, 21 Jan 2026 15:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769010743; cv=none; b=sGjfe1ZqF8z3NRzDB/07p8OvacXG2S3fu3dHgSnxFylHDZGRZ8VJxZSjsLiLFDUTro91WlV8661mGLZh+4pHZmxciQwQGpLcaN5P8qz0ikj8dAcF7DQUHr2RVNf0AuE/2VhALOLyoxBoXOY5kl0jnmbqtyTLY+adiCLUM+0lxgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769010743; c=relaxed/simple; bh=MSrdElO2eNJ+3fVFv82fRnLpxJGYKhhFl9vi/KvX9Z0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RDuv0kDnK3kYatQWPEkuwOgayDtdsF460y6pCZKIVdaOiHz24NISxlk3KkKMbM5LT+6jW5XImVtT6NDqgxaBPfDSKMDgyumZIijnLxuNn/2Uv6x4vx/wpH7fddUYhLgJgyNXetL+ks8SzVxvsrYSw9lOAcBNfCRbEUeMjPDkGgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xr6y7hVM; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xr6y7hVM" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b874c00a39fso186548966b.0 for ; Wed, 21 Jan 2026 07:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769010740; x=1769615540; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2/1aNZ9XJSzadYv8zTigHAL/WcmkL36YjSibotwpTDQ=; b=Xr6y7hVMH0N49OFHt/3XbKrk/K6gDcDoDarSPGKKxjsE0xegr3r8CBnN0OyzrklDlx +m0qgciGbLiM4MSQefSxwP7sKFTpHSZBpkEuW1ANfRMoSsu+M3UBev5MuZPllqEuckeQ IkZvIZIIXCygf0Yi7TBKt2CGXMUcTE/2ZyUl1I6bFSxM66/1gvA1MgqcGsdAyRlaboQX etEOSXJL1xz9MKQzzPcllYROYGxPw2ps7hn4v4ekgebrk/bZEXsBefn7SHSwSxOqsy6u xHDdfGdq6lKkiBIXADfKcxO2LWpfzqsggtJsHSD09EUupanrl2gKNTnwPQpDctqhIly2 XFVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769010740; x=1769615540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2/1aNZ9XJSzadYv8zTigHAL/WcmkL36YjSibotwpTDQ=; b=hEOARMC5nGNrvI7OcRge2jIhLZbrEbukQrs3Z080y/pbupFEn0nOEf1hYwrWC7puLV dhdVz9lngsokV8zdusV0l6MLyL/XuqsAbiPPrSboKJQV7NEFQb2qRLww0tD4U0aT4kkq iOgojAEBjUbPUEfmxinTIdB/n3ibqHNRVU4Lm+UQ7HvISzmIKup436fpAeSKhW5H6jSY Tn6E3EYqjcH1E3vXhRbgKqk/HUMAVCcsfcQeJtWaLYQOzuo4gNwbl0BoD1rhS5kI3iUG DnHwMK96qFOWEKHv5EKigRBp+PjCh2oHL2Uu6YKxtqWQIE7kd0rxoKmr6UWHFAC/Qydv FiWQ== X-Forwarded-Encrypted: i=1; AJvYcCUgY7PxDZdJeixoyqCnDST5+Fas1HyydHab6zg16vdUPhELxSPZ/672YwxisVH0mPjKvj1Jm68JYmnTw8A=@vger.kernel.org X-Gm-Message-State: AOJu0YzSldngFXOQ+piYpsMLd4uoitdL/T4nj0XXfZXluKl+489b7cb0 8OHsKo0J1NRnKZP4cvptMNG+3s1McU6F+zaqU9NwCeJ7STPO8jXyw+udt/834g== X-Gm-Gg: AZuq6aIe5Q+TNfIHAs+V5JewXXGfyLG+4GltAoX4HJ8jghQPiAY8uelKu1/6lkh0UML foizYXH0J65e+2FqDuV2Z1rVTPhExy6kgIB1OgS7avRhSUDSYy/ouRJc0Suq6PErpfcIlDFn8xA WRc2AL8Rf9EYTa/wi9sD7PtXjeD8v8iGt3CRl7/lEWWtIc7E4ZCCzTMLZOUVxHLlxwCjuVDw2H/ PyCzEfPpItTThhUQ0YI8fDDWQz91gLcX44pWV3Oa29BxVWJrXiPyQxoYqZcRIU96LY46texUYfK Z9nmLrfe5Eqo5SCYYPZV9gySseXnCHw8Cn2xZeln+eFaxD2IsNu+ylKeaO2G9+hUK0RVrxn/Koz swXbJiFcQwUUQHhc3jREpVcUtq8fTL4LAiQSCrdIp6+UwKEx+q/PkeczOZ91U/EjB3M621PtIUo 6UKrXkDy76dvbpr7kLYcr+RxuwX7WLX4Rg7m5ERov7fDJt+G3POzzKOdEJqeCxscg= X-Received: by 2002:a5d:6502:0:b0:435:8dd5:ad4f with SMTP id ffacd0b85a97d-4358dd5af25mr7713381f8f.9.1769004539390; Wed, 21 Jan 2026 06:08:59 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4358f138e26sm11918651f8f.17.2026.01.21.06.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 06:08:59 -0800 (PST) Date: Wed, 21 Jan 2026 14:08:57 +0000 From: David Laight To: Brian Gerst Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, tip-bot2 for Uros Bizjak , linux-tip-commits@vger.kernel.org, Uros Bizjak , "Borislav Petkov (AMD)" , Michael Kelley , x86@kernel.org Subject: Re: [tip: x86/cleanups] x86/segment: Use MOVL when reading segment registers Message-ID: <20260121140857.3544d19e@pumpkin> In-Reply-To: References: <20260105090422.6243-1-ubizjak@gmail.com> <176891088183.510.8607818928752445249.tip-bot2@tip-bot2> <3A54B6DC-2462-41DA-8C34-D38CCD2A9A2B@zytor.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 21 Jan 2026 06:49:16 -0500 Brian Gerst wrote: > On Wed, Jan 21, 2026 at 2:29=E2=80=AFAM H. Peter Anvin wr= ote: > > > > On January 20, 2026 4:08:01 AM PST, tip-bot2 for Uros Bizjak wrote: =20 > > >The following commit has been merged into the x86/cleanups branch of t= ip: > > > > > >Commit-ID: 53ed3d91a141f5c8b3bce45b0004fbbfefe77956 > > >Gitweb: https://git.kernel.org/tip/53ed3d91a141f5c8b3bce45b0004= fbbfefe77956 > > >Author: Uros Bizjak > > >AuthorDate: Mon, 05 Jan 2026 10:02:32 +01:00 > > >Committer: Borislav Petkov (AMD) > > >CommitterDate: Tue, 20 Jan 2026 12:34:58 +01:00 > > > > > >x86/segment: Use MOVL when reading segment registers > > > > > >Use MOVL when reading segment registers to avoid 0x66 operand-size ove= rride > > >insn prefix. The segment value is always 16-bit and gets zero-extended= to the > > >full 32-bit size. > > > > > >Example: > > > > > > 4e4: 66 8c c0 mov %es,%ax > > > 4e7: 66 89 83 80 0b 00 00 mov %ax,0xb80(%rbx) > > > > > > 4e4: 8c c0 mov %es,%eax > > > 4e6: 66 89 83 80 0b 00 00 mov %ax,0xb80(%rbx) > > > > > >Also, use the %k0 modifier which generates the SImode (signed integer) > > >register name for the target register. > > > > > > [ bp: Extend and clarify commit message. ] > > > > > >Signed-off-by: Uros Bizjak > > >Signed-off-by: Borislav Petkov (AMD) > > >Reviewed-by: H. Peter Anvin (Intel) > > >Tested-by: Michael Kelley > > >Link: https://patch.msgid.link/20260105090422.6243-1-ubizjak@gmail.com > > >--- > > > arch/x86/include/asm/segment.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > >diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/seg= ment.h > > >index f59ae71..9f5be2b 100644 > > >--- a/arch/x86/include/asm/segment.h > > >+++ b/arch/x86/include/asm/segment.h > > >@@ -348,7 +348,7 @@ static inline void __loadsegment_fs(unsigned short= value) > > > * Save a segment register away: > > > */ > > > #define savesegment(seg, value) \ > > >- asm("mov %%" #seg ",%0":"=3Dr" (value) : : "memory") > > >+ asm("movl %%" #seg ",%k0" : "=3Dr" (value) : : "memory") > > > > > > #endif /* !__ASSEMBLER__ */ > > > #endif /* __KERNEL__ */ > > > =20 > > > > Incidentally, why aren't we using =3Drm here? Segment moves support mem= ory operands. =20 >=20 > You would have to be really careful to only use short (16-bit) > variables, because it will not zero-extend with a memory operand. >=20 It would be much safer to have something that returned the value of the segment register (zero extended to 32 bits). David