From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3858B3644A1 for ; Wed, 21 Jan 2026 16:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769012816; cv=none; b=V8LQqq7wTTpJEyGwD6d9srtt14VfMEMNSnOhSuDI8+qpxs+HHH18feXi8GA+jxjiIlFixNgrVrguBlNKl8d9fSmnidLxpidr7KFAZ7qZMmdZD02t1IdlQMWO6Ulh91BBGDAdw9eQDyOtzj/dZ31njr/IUQPhNq3QQt+Eu+O9lxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769012816; c=relaxed/simple; bh=Jj/tYwdXEXUOg64lKr4IrDKHw613UPzJ/qBPeEVnSIo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YtYA4quuB6hNvtTRUyPVO/FeBZaWfO0iP9PXD1wJui/YmBV3acjncE8hqEb8yaEiOVcmdAVU6hAxf/grXNOf90kcRru2s3sDHitvlG0OIlJ+Pkjnqiej2o7xfc+yv6fB32I9p0+rqae9QocOyG5afWzdH768wpRRqgmffIZhuos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=emJL49rU; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="emJL49rU" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-655af782859so11118367a12.2 for ; Wed, 21 Jan 2026 08:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769012812; x=1769617612; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7MFyGEBMKUH9OPAqYqwZCoqkE5S+eIGaZJE0/gf+bsI=; b=emJL49rUjNTqfL2aFXD7TP2qnR/Abqaxcg4XRGq1qHNTyupEtmjKPzuJsbErXwjrM+ kwFq5jkc8sxXO9FNa3g+4hbAJY0dhisnbSl6fJ5H7ObhCzQi5X8ii09KX3OhnhTxPP3m BAL+h6+jzdZSuSPkdy3F8h2ryfUxoeobe1l/cTNeincRQsuNbgCvSQ7eBWuaNJvzL4Sn T/B1f/X613nP8NW/09iv2E/pXkdrnIIxg4vuatuL61t4orW0LS+x1wOcMEM9IUpJ113C 6i28xWQ3ZMusWjKOBbySw37C8hu4IHzBEE4hxkBHQggaDOfKd0amJWkCACmg6AwXdSw1 rgRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769012812; x=1769617612; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7MFyGEBMKUH9OPAqYqwZCoqkE5S+eIGaZJE0/gf+bsI=; b=LURZZm1TL4+DQ9uHqH+/+rZ/h+GLYArZmy0ngUxevroujEWcx2YURDZU0Jd8j8WMNz 6Cf20Czjt9cpxQZrF3TceseY47pnskHMpJkou6yQGp/IHzR48649ggedIM98WzBi1wT5 Pipg6E0eDW0VuA7DbnJGmsyNBbfdEpi2iVSFdkHYmQvEHAsZl6KE83f5z47rRlHJSWsS HMM1nWqI+UpDjFoZ55M+ZTWc1i6UlreYY117KtKBVNTSZOJI866Qz3EY7lqBVFkzZ9Vz 7p9R24UNDnYZODzt/qwfeqVNNKvXtNGrLLN8PCYTy3nWE3cIINp+KFIoMaoDeCA7GThG S72w== X-Forwarded-Encrypted: i=1; AJvYcCVh9udUQ95DtthS8GmyOXuZA6/F/kyrxYdvEwxuKtg24Eh8azOw/TxnYrV+mWPWsUI++x03Jni8WvitG+I=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7mbqeNtfwvLrZS96T+qhENVya7IvxxtSNbe5HRqH4Xmde3p4B gyxiFbRG7n1/VD49kO6ohzxNJDDjGRAYI3h5MwmvQp2joRXe2w7YLLQ8XquIpA== X-Gm-Gg: AZuq6aLo4CeDH+7rhrc/CUIQtqbAY0Wr/dU7bYJJDNtu3j9NVbOFC64x9y5qHwGlK6x q9RicXwTfbNMyIqxa49qrnp6c4Zi6BI3MPRZMv6tE94EkS7Id7umiI81uTTJA7UWLNpvzzcU+fV jlqHHXt248AO+cNeXtrQ6fD3/iYqI0UUKv66PQJOhgjP+462Jp/ixbHhXQYWGaKdj3wjEIttb5a 0hNL48drHypejQA9zsfTyOrCSE0LsO3lrhq+5BpMJCfmXFkwaNNoVswmcGtVyp6tN6nNzM4dF6P 48pPc3F1xzPZDPgTsycmEHR+DRfUwzdGrwJpbw6vRwOsHXPWm02MYjPDCvcYYL/ywjoCMjX4ZVY 4xwJdp8gKqLY5i8oBY2W0L3gcORj2qvMkYK/AVXjDTYF9NWg9wysURXNLFJjLJC0M0fFLb2MxiT zCfU/TMULvbCIlGrHrn2RMBvOhd38N2eF1ZQXrxpoV25Jl6cgKG5RnJAjvg5P3B0s= X-Received: by 2002:a05:600c:4fc7:b0:480:41f2:b212 with SMTP id 5b1f17b1804b1-48042f7e0e0mr38897745e9.25.1769006884109; Wed, 21 Jan 2026 06:48:04 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4802dc90068sm274897235e9.7.2026.01.21.06.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 06:48:03 -0800 (PST) Date: Wed, 21 Jan 2026 14:48:02 +0000 From: David Laight To: kernel test robot Cc: Ryan Roberts , Catalin Marinas , Will Deacon , Huacai Chen , Madhavan Srinivasan , Michael Ellerman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Kees Cook , "Gustavo A. R. Silva" , Arnd Bergmann , Mark Rutland , "Jason A. Donenfeld" , Ard Biesheuvel , Jeremy Linton , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v4 3/3] randomize_kstack: Unify random source across arches Message-ID: <20260121144802.1287ce3e@pumpkin> In-Reply-To: <20260121102017.539b5531@pumpkin> References: <20260119130122.1283821-4-ryan.roberts@arm.com> <202601210752.6Nsv9et9-lkp@intel.com> <20260121102017.539b5531@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 21 Jan 2026 10:20:17 +0000 David Laight wrote: > On Wed, 21 Jan 2026 07:50:16 +0800 > kernel test robot wrote: > > > Hi Ryan, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on akpm-mm/mm-everything] > > [also build test WARNING on linus/master v6.19-rc6 next-20260119] > > [cannot apply to tip/sched/core kees/for-next/hardening kees/for-next/execve] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Roberts/randomize_kstack-Maintain-kstack_offset-per-task/20260119-210329 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > patch link: https://lore.kernel.org/r/20260119130122.1283821-4-ryan.roberts%40arm.com > > patch subject: [PATCH v4 3/3] randomize_kstack: Unify random source across arches > > config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20260121/202601210752.6Nsv9et9-lkp@intel.com/config) > > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260121/202601210752.6Nsv9et9-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202601210752.6Nsv9et9-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > >> vmlinux.o: warning: objtool: do_syscall_64+0x2c: call to preempt_count_add() leaves .noinstr.text section > > >> vmlinux.o: warning: objtool: __do_fast_syscall_32+0x3d: call to preempt_count_add() leaves .noinstr.text section > > > > When CONFIG_DEBUG_PREEMPT or CONFIG_TRACE_PREEMP_TOGGLE is set > the preempt_count_[en|dis]able() calls inside [put|get]_cpu_var() > become real functions. > > Maybe __preempt_count_[inc|dec]() can be called (with this_cpu_ptr()). Or the code could just use the per-cpu data without disabling preemption. Usually that isn't a good idea at all, but it can't matter in this case. Might give a noticeable performance gain, disabling preemption is non-trivial and/or an atomic operation on some architectures. If anyone is worried about preemption causing the output be repeated, that would be (mostly) mitigated by checking that s[1234] haven't changed prior to writing the new values. I think a 'not locked at all' compare of two of the four values will stop everything except two threads doing system calls at the same time getting the same output from the prng. The whole thing is very unlikely and there will be much easier ways to break the prng. Provided s[1234] are only written with valid values (ie ones which aren't effectively zero) it will continue generating numbers. David > > David >