From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED582345CA0 for ; Wed, 21 Jan 2026 16:31:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769013114; cv=none; b=NXFkI319kMOsIIPa2Z6vqTz01oGp3AlxX730s0ScUe/pPY7/a/I37IADs8iJB+y/JAKQ82q/wEo43H9JcfoI9gz+W3e5D8zw2Gu/G8kYm0GsqtxQ2vOCzFEZG7gwZkIBRVhzVdsEeK+6w3RQYvs1jKYhEkoj7xEhSP9AS6QliCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769013114; c=relaxed/simple; bh=RgX4FgksVcrRMf8IFUNn+O1ar7lFtWajbOexnFwiRbU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LvWdDWzQVh7LpcGHkIaeKyCInX3Wp+S2JuFdH6wk3vOtyknV+17Wum1ZfYG6Zz0qjIFGyQvvtYiHTQ21zREfnL6fBe6pvj71wug4eQpM7rfitvmxR9xPxoNKhTBACSMdBoFc+SeRMyi0GWo4fLe1Cc7FwwsSAZ+W4V7Wtzjimd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F+i+wJNY; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F+i+wJNY" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-38305f05717so374641fa.1 for ; Wed, 21 Jan 2026 08:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769013111; x=1769617911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=m/l5Or+9VZx9wTcwnm6b2pPtRU4tLZm9EvzdoDhgPg0=; b=F+i+wJNYmq0sPRFFmdF5T7xVSNCno3NlA4Llh6TU/hO1Azuw4dJPjoneIQ9HzHFvti wwlP01NFz7moVR7UAyGrxYFf12TRgYKZaCMZppbKdJfyQSFn6c4lOPk9B64jM7QmZImu Q7HesWAeKcHuCMV712Fg5jG8YpoTWVyD2gIfa94PrHpWwRKSkAGnC+kMzEaUPDykZnxl 0+L3VJVhIvfV5PpfmAHAP676IzudMWr6MfVLM1qEtLgDTnLlQDeX82bA/0BTrK8e9wqY UMETfaP44PLSbCMPNiO3FYw1yvHW/qfr2bbiTsNQub43hSTKxdbkJi6waAbDAj48pBpp pLZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769013111; x=1769617911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=m/l5Or+9VZx9wTcwnm6b2pPtRU4tLZm9EvzdoDhgPg0=; b=TW1tK8sJravWHElIj27fPa8pXC69g2/kQPLnZDo2xqfl5sLHU2Nesvt7gDO+6UaE3t 6oWTXQ58ZVgVDIv1ei0/oet7JxB6N7mI5oHCxxA3Egp1op8nmznrNQADV5DpC9yJ80F/ 0rjlzqfuYYd0vn7DQxCY7qa3PRWtQIy6H31wcxBTADA0EC2+3PI+Ez1vbw9+bjWzzlsZ fWt32kvKga2evfmVYCQAzFk2QQ0eK92NjmW72xrVSmAUXATra0qK6BrUxFWDJU6Xg+bR ATA5gua685pJd8w27TKObW9+fzW/bl6nNA0/Xnkx4+/XFRzUmkPt4wzFDC1nCQXqgYc0 OxXg== X-Forwarded-Encrypted: i=1; AJvYcCXM9VLsxUDh3CLYTM7nXBCCWGJ/uAjKkHgGYLvFAUHguF1eTl/k5EQaPwitUbmbR37OOEX9MXY1jk4g7nk=@vger.kernel.org X-Gm-Message-State: AOJu0YwyvDKUAjnqVbtny5lCvJsHg/pV56q6YFGOzbYuI/Fd1bcRk5wn rtBt9xJNkyIlPB0ixos+FqF5GQONsxGGB+iXYVJG1Jjzdwc0wCSlM1maUzmLrQ== X-Gm-Gg: AZuq6aKjs+kA+Bv26n02WrnUzAZdDnZASvnik4Or2nNn5C0cpX5p1Cy22Je3RFxodua Emqq12Tb/0xNmgH/sYTpSm3aWQolHerbS0pgA9rbum7HLI6x9s5TUI952dFtOkVVbDcRkhk+pYq TkdnaGBD6ISBX7KGIJSwSJ5LIxCmbXXHBicuhVz9BM5nvE/uc37XSRJ/USs9atuGqdWi2/mRPEy GcR3XICLkw4W4o50XwFlXQgnBBGI20e67Kyp7PveIRiIIkq4Cv9H8woUQGzvbJY/GD74TrE7Ygy oNGNqF8fHaqnUBz3OnYPW8+Mn4QaFbij1rYMaRcsQjXTYFM9TRo+CtK0+7SqRxGdCJ8ygrw1FbE Wf85Zjml9G8HwHlfQd1Pyh9IAD6+kK9h/L0ivlr9rqDc4BpR4bbEVxBWQkduSqbUGjNOQqZmU4u q1SUnrpRTcyfqDGMbYbbW6qNRJS4MsuKMGXC4ygF/cGrq1hxIGD7gO X-Received: by 2002:a5d:6506:0:b0:435:9d70:f2a2 with SMTP id ffacd0b85a97d-4359d70fb9cmr3236513f8f.25.1769007325521; Wed, 21 Jan 2026 06:55:25 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569921da2sm37281512f8f.1.2026.01.21.06.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 06:55:25 -0800 (PST) Date: Wed, 21 Jan 2026 14:55:24 +0000 From: David Laight To: Greg Kroah-Hartman Cc: dakr@kernel.org, rafael@kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, Gui-Dong Han Subject: Re: [PATCH] driver core: faux: stop using static struct device Message-ID: <20260121145524.2ecd29eb@pumpkin> In-Reply-To: <2026012145-lapping-countless-ef81@gregkh> References: <2026012145-lapping-countless-ef81@gregkh> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 21 Jan 2026 11:29:45 +0100 Greg Kroah-Hartman wrote: > faux_bus_root should not have been a static struct device, but rather a > dynamically created structure so that lockdep and other testing tools do > not trip over it (as well as being the right thing overall to do.) Fix > this up by making it properly dynamic. > > Reported-by: Gui-Dong Han > Signed-off-by: Greg Kroah-Hartman > --- > drivers/base/faux.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/faux.c b/drivers/base/faux.c > index 21dd02124231..23d725817232 100644 > --- a/drivers/base/faux.c > +++ b/drivers/base/faux.c > @@ -29,9 +29,7 @@ struct faux_object { > }; > #define to_faux_object(dev) container_of_const(dev, struct faux_object, faux_dev.dev) > > -static struct device faux_bus_root = { > - .init_name = "faux", > -}; > +static struct device *faux_bus_root; > > static int faux_match(struct device *dev, const struct device_driver *drv) > { > @@ -152,7 +150,7 @@ struct faux_device *faux_device_create_with_groups(const char *name, > if (parent) > dev->parent = parent; > else > - dev->parent = &faux_bus_root; > + dev->parent = faux_bus_root; > dev->bus = &faux_bus_type; > dev_set_name(dev, "%s", name); > device_set_pm_not_required(dev); > @@ -236,9 +234,15 @@ int __init faux_bus_init(void) > { > int ret; Should there be: if (faux_bus_root) return -EBUSY; here? While I guess there shouldn't be two of these, better be safe. David > > - ret = device_register(&faux_bus_root); > + faux_bus_root = kzalloc(sizeof(*faux_bus_root), GFP_KERNEL); > + if (!faux_bus_root) > + return -ENOMEM; > + > + dev_set_name(faux_bus_root, "faux"); > + > + ret = device_register(faux_bus_root); > if (ret) { > - put_device(&faux_bus_root); > + put_device(faux_bus_root); > return ret; > } > > @@ -256,6 +260,6 @@ int __init faux_bus_init(void) > bus_unregister(&faux_bus_type); > > error_bus: > - device_unregister(&faux_bus_root); > + device_unregister(faux_bus_root); > return ret; > }